Series sales form: validate url length.

Fix #699

Author: php-coder

src/main/java/ru/mystamps/web/Db.java

@@ -44,6 +44,10 @@ public static final class SeriesImportRequest {
 		public static final int URL_LENGTH = 285;
 	}
 
+	public static final class SeriesSales {
+		public static final int TRANSACTION_URL_LENGTH = 255;
+	}
+	
 	public static final class SuspiciousActivity {
 		public static final int PAGE_URL_LENGTH     = 100;
 		public static final int METHOD_LENGTH       = 7;

src/main/java/ru/mystamps/web/controller/dto/AddSeriesSalesForm.java

@@ -21,6 +21,7 @@
 import java.util.Date;
 
 import javax.validation.constraints.NotNull;
+import javax.validation.constraints.Size;
 
 import org.springframework.format.annotation.DateTimeFormat;
 
@@ -29,6 +30,7 @@
 
 import ru.mystamps.web.dao.dto.Currency;
 import ru.mystamps.web.service.dto.AddSeriesSalesDto;
+import ru.mystamps.web.validation.ValidationRules;
 
 @Getter
 @Setter
@@ -40,6 +42,7 @@ public class AddSeriesSalesForm implements AddSeriesSalesDto {
 	@NotNull
 	private Integer sellerId;
 
+	@Size(max = ValidationRules.SERIES_SALES_URL_MAX_LENGTH, message = "{value.too-long}")
 	private String url;
 
 	@NotNull

src/main/java/ru/mystamps/web/validation/ValidationRules.java

@@ -67,6 +67,8 @@ public final class ValidationRules {
 	public static final int PARTICIPANT_NAME_MAX_LENGTH = Db.TransactionParticipant.NAME_LENGTH;
 	public static final int PARTICIPANT_URL_MAX_LENGTH  = Db.TransactionParticipant.URL_LENGTH;
 
+	public static final int SERIES_SALES_URL_MAX_LENGTH = Db.SeriesSales.TRANSACTION_URL_LENGTH;
+	
 	public static final int IMPORT_REQUEST_URL_MAX_LENGTH  = Db.SeriesImportRequest.URL_LENGTH;
 
 	/** Maximum uploading image size in kilobytes. */

src/test/robotframework/series/sales/validation.robot

@@ -0,0 +1,28 @@
+*** Settings ***
+Documentation    Verify validation scenarios for adding series sales
+Library          Selenium2Library
+Resource         ../../auth.steps.robot
+Suite Setup      Before Test Suite
+Suite Teardown   After Test Suite
+Force Tags       series  sales  validation
+
+*** Test Cases ***
+Create series sales with too long url
+	[Documentation]         Verify validation of too long url
+	${letter}=              Set Variable  j
+	Input Text              id=url  http://${letter * 255}
+	Submit Form             id=add-series-sales-form
+	Element Text Should Be  id=url.errors  Value is greater than allowable maximum of 255 characters
+
+*** Keywords ***
+Before Test Suite
+	[Documentation]                     Login as admin and open a page with series
+	Open Browser                        ${SITE_URL}  ${BROWSER}
+	Register Keyword To Run On Failure  Log Source
+	Log In As                           login=admin  password=test
+	Go To                               ${SITE_URL}/series/1
+
+After Test Suite
+	[Documentation]  Log out and close browser
+	Log Out
+	Close Browser