CollectionService.isSeriesInCollection(): fix error from PMD about useless local variable.

php-coder · php-coder · commit c456135ef683 · 2017-05-20T21:03:27.000+02:00
Correction for 566a0ec commit. No functional changes.
diff --git a/src/main/java/ru/mystamps/web/service/CollectionServiceImpl.java b/src/main/java/ru/mystamps/web/service/CollectionServiceImpl.java
@@ -103,9 +103,7 @@ public boolean isSeriesInCollection(Integer userId, Integer seriesId) {
 			return false;
 		}
 		
-		boolean isSeriesInCollection = collectionDao.isSeriesInUserCollection(userId, seriesId);
-		
-		return isSeriesInCollection;
+		return collectionDao.isSeriesInUserCollection(userId, seriesId);
 	}
 	
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -103,9 +103,7 @@ public boolean isSeriesInCollection(Integer userId, Integer seriesId) {`
`103`	`103`	`return false;`
`104`	`104`	`}`
`105`	`105`
`106`		`- boolean isSeriesInCollection = collectionDao.isSeriesInUserCollection(userId, seriesId);`
`107`		`-`
`108`		`- return isSeriesInCollection;`
	`106`	`+ return collectionDao.isSeriesInUserCollection(userId, seriesId);`
`109`	`107`	`}`
`110`	`108`
`111`	`109`	`@Override`