Skip to content

Commit c37b93b

Browse files
committed
SeriesInfoExtractorServiceImpl.extractSellerName(): add unit test.
Fix #860
1 parent d84e83d commit c37b93b

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,6 @@ public Integer extractSellerGroup(Integer id, String sellerUrl) {
339339
}
340340
}
341341

342-
// @todo #695 SeriesInfoExtractorServiceImpl.extractSellerName(): add unit tests
343342
protected String extractSellerName(Integer id, String name) {
344343
if (id != null) {
345344
return null;

src/test/groovy/ru/mystamps/web/service/SeriesInfoExtractorServiceImplTest.groovy

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,21 @@ class SeriesInfoExtractorServiceImplTest extends Specification {
430430
Random.id() | _
431431
}
432432

433+
//
434+
// Tests for extractSellerName()
435+
//
436+
437+
@Unroll
438+
@SuppressWarnings('UnnecessaryBooleanExpression') // false positive
439+
def 'extractSellerName() should return "#expected" for id=#id/name=#name'(Integer id, String name, String expected) {
440+
expect:
441+
service.extractSellerName(id, name) == expected
442+
where:
443+
id | name || expected
444+
Random.id() | Random.sellerName() || null
445+
null | 'Seller Name' || 'Seller Name'
446+
}
447+
433448
//
434449
// Tests for extractPrice()
435450
//

0 commit comments

Comments
 (0)