improve: yvert catalog numbers now can be up to 5 characters long and contain letters.

Fix #1421

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/AddSeriesForm.java

@@ -112,7 +112,8 @@ public class AddSeriesForm implements AddSeriesDto, HasImageOrImageUrl, Nullable
 	@Price
 	private BigDecimal scottPrice;
 
-	@CatalogNumbers
+	// @todo #1421 /series/add: add integration test to check that Yvert numbers may contain letters
+	@CatalogNumbers(allowLetters = true)
 	private String yvertNumbers;
 
 	@Price

src/main/resources/liquibase/version/0.4.4.xml

@@ -9,5 +9,6 @@
 	<include file="0.4.4/2020-05-04--series_sale_condition.xml" relativeToChangelogFile="true" />
 	<include file="0.4.4/2020-05-04--collections_series_condition.xml" relativeToChangelogFile="true" />
 	<include file="0.4.4/2020-05-23--modify_condition_field.xml" relativeToChangelogFile="true" />
+	<include file="0.4.4/2020-06-01--yvert_code_length.xml" relativeToChangelogFile="true" />
 
 </databaseChangeLog>

src/main/resources/liquibase/version/0.4.4/2020-06-01--yvert_code_length.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+	xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+		http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd">
+	
+	<changeSet id="modify-yvert_catalog-code-length" author="php-coder" context="scheme">
+		
+		<modifyDataType
+			tableName="yvert_catalog"
+			columnName="code"
+			newDataType="VARCHAR(5)" />
+
+		<!--
+			modifyDataType loses NOT NULL property on MySQL:
+			https://forum.liquibase.org/topic/warning-of-losing-primary-key-autoincrement-for-mysql
+			In order to fix that, we patch the SQL query to specify NOT NULL again.
+		-->
+		<modifySql dbms="mysql">
+			<append value=" NOT NULL" />
+		</modifySql>
+		
+	</changeSet>
+	
+</databaseChangeLog>

src/test/robotframework/series/creation/validation-user.robot

@@ -90,7 +90,7 @@ Invalid Catalog Numbers Should Be Rejected
 	...                            Any number may end with a latin letter in lower case
 	Element Text Should Be         id:michelNumbers.errors    Value must be a list of numbers separated by comma
 	Element Text Should Be         id:scottNumbers.errors     ${alnumMessage}
-	Element Text Should Be         id:yvertNumbers.errors     Value must be a list of numbers separated by comma
+	Element Text Should Be         id:yvertNumbers.errors     ${alnumMessage}
 	Element Text Should Be         id:gibbonsNumbers.errors   Value must be a list of numbers separated by comma
 	Element Text Should Be         id:solovyovNumbers.errors  Value must be a list of numbers separated by comma
 	Element Text Should Be         id:zagorskiNumbers.errors  Value must be a list of numbers separated by comma