Skip to content

Commit be9ed14

Browse files
committed
perf: reduce garbage from validators when we create empty strings while we can use null value instead.
No functional changes.
1 parent 902da18 commit be9ed14

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/main/java/ru/mystamps/web/support/beanvalidation/FieldsMatchValidator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
4646
PropertyAccessor bean = new BeanWrapperImpl(value);
4747

4848
Object firstField = bean.getPropertyValue(firstFieldName);
49-
String firstFieldValue = Objects.toString(firstField, "");
49+
String firstFieldValue = Objects.toString(firstField, null);
5050
if (StringUtils.isEmpty(firstFieldValue)) {
5151
return true;
5252
}
5353

5454
Object secondField = bean.getPropertyValue(secondFieldName);
55-
String secondFieldValue = Objects.toString(secondField, "");
55+
String secondFieldValue = Objects.toString(secondField, null);
5656
if (StringUtils.isEmpty(secondFieldValue)) {
5757
return true;
5858
}

src/main/java/ru/mystamps/web/support/beanvalidation/FieldsMismatchValidator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
4646
PropertyAccessor bean = new BeanWrapperImpl(value);
4747

4848
Object firstField = bean.getPropertyValue(firstFieldName);
49-
String firstFieldValue = Objects.toString(firstField, "");
49+
String firstFieldValue = Objects.toString(firstField, null);
5050
if (StringUtils.isEmpty(firstFieldValue)) {
5151
return true;
5252
}
5353

5454
Object secondField = bean.getPropertyValue(secondFieldName);
55-
String secondFieldValue = Objects.toString(secondField, "");
55+
String secondFieldValue = Objects.toString(secondField, null);
5656
if (StringUtils.isEmpty(secondFieldValue)) {
5757
return true;
5858
}

src/main/java/ru/mystamps/web/support/beanvalidation/NotNullIfFirstFieldValidator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
4747
PropertyAccessor bean = new BeanWrapperImpl(value);
4848

4949
Object firstField = bean.getPropertyValue(firstFieldName);
50-
String firstFieldValue = Objects.toString(firstField, "");
50+
String firstFieldValue = Objects.toString(firstField, null);
5151
if (StringUtils.isEmpty(firstFieldValue)) {
5252
return true;
5353
}
5454

5555
Object secondField = bean.getPropertyValue(secondFieldName);
56-
String secondFieldValue = Objects.toString(secondField, "");
56+
String secondFieldValue = Objects.toString(secondField, null);
5757
if (StringUtils.isNotEmpty(secondFieldValue)) {
5858
return true;
5959
}

0 commit comments

Comments
 (0)