chore: replace jasmine-maven-plugin by Jest

The existing JS unit tests are now being run on CI.

Part of #1484

Author: php-coder

.gitignore

@@ -9,10 +9,6 @@ target/
 .idea
 *.iml
 
-# jasmine-maven-plugin uses phantomjs-maven-plugin.
-# phantomjs-maven-plugin creates this log file.
-phantomjsdriver.log
-
 # minified resources
 src/main/webapp/WEB-INF/static/styles/*.min.css
 src/main/javascript/*.min.js

Dangerfile

@@ -353,32 +353,6 @@ if File.file?(enforcer_output)
 	end
 end
 
-# Handle `mvn jasmine:test` report
-#
-# Example:
-# <testsuite errors="0" name="jasmine.specs" tests="22" failures="3" skipped="0" hostname="localhost" time="0.0" timestamp="2017-03-09T19:52:06">
-#   <testcase classname="jasmine" name="CatalogUtils.expandNumbers() should return string without hyphen as it" time="0.0" failure="true">
-#     <error type="expect.toEqual" message="Expected 'test' to equal '2test'.">Expected 'test' to equal '2test'.</error>
-#   </testcase>
-# </testsuite>
-#
-jasmine_report = 'target/jasmine/TEST-jasmine.xml'
-if File.file?(jasmine_report)
-	doc = Nokogiri::XML(File.open(jasmine_report))
-	testsuite = doc.xpath('/testsuite').first
-	failures  = testsuite['failures'].to_i
-	if failures > 0
-		testsuite.xpath('.//testcase[@failure="true"]').each do |tc|
-			# NOTE: unfortunately jasmine report doesn't contain file name
-			msg = tc.xpath('./error').first.text.sub(/\.$/, '')
-			testcase = tc['name']
-			fail("jasmine-maven-plugin error:\nTest case `#{testcase}` fails with message:\n`#{msg}`\n")
-		end
-		
-		print_errors_summary 'jasmine-maven-plugin', failures, 'https://github.com/php-coder/mystamps/wiki/unit-tests-js'
-	end
-end
-
 # Handle `html5validator` output
 #
 # Example:
@@ -406,6 +380,7 @@ if File.file?(validator_output)
 end
 
 # @todo #1060 Danger: handle Babel errors from frontend-maven-plugin
+# @todo #1484 Danger: handle errors from Jest
 
 # Handle `mvn org.apache.maven.plugins:maven-compiler-plugin:compile` output
 # Handle `mvn org.apache.maven.plugins:maven-compiler-plugin:testCompile` output

NEWS.txt

@@ -1,5 +1,6 @@
 0.x (upcoming release)
 
+- (infrastructure) port JavaScript unit tests from Jasmine to Jest
 
 0.4.6
 - (feature)        users can add a comment to a series

README.md

@@ -45,7 +45,7 @@ If you want to run it locally, follow the instructions:
 * *Database migrations*: Liquibase
 * *Validation*: Hibernate Validator
 * *Logging*: Slf4j (Logback)
-* *Unit tests*: Groovy with Spock Framework or JUnit (for Java code), jasmine (for JavaScript code)
+* *Unit tests*: Groovy with Spock Framework or JUnit (for Java code), Jest (for JavaScript code)
 * *Integration tests*: Selenium3, RobotFramework, WireMock
 * *Deployment*: bash, Ansible, Terraform
 * *Others*: Lombok, Togglz, WebJars, AssertJ

pom.xml

@@ -596,7 +596,6 @@
 		<htmlunit.version>2.46.0</htmlunit.version>
 
 		<jacoco.plugin.version>0.8.6</jacoco.plugin.version>
-		<jasmine.plugin.version>2.2</jasmine.plugin.version>
 
 		<!--
 			Redefine default value from spring-boot-starter-parent:
@@ -757,21 +756,6 @@
 				</configuration>
 			</plugin>
 
-			<plugin>
-				<groupId>com.github.searls</groupId>
-				<artifactId>jasmine-maven-plugin</artifactId>
-				<version>${jasmine.plugin.version}</version>
-				<configuration>
-					<!--
-						Remove explicit specifying of version when phantomjs will be available for Linux
-						https://github.com/searls/jasmine-maven-plugin/issues/278
-					-->
-					<phantomjs>
-						<version>1.9.8</version>
-					</phantomjs>
-				</configuration>
-			</plugin>
-			
 			<!--
 				Usage:
 				./mvnw spotbugs:check (checks the sources and produces report to the console)

src/main/scripts/ci/check-build-and-verify.sh

@@ -65,7 +65,7 @@ POM_STATUS=
 BOOTLINT_STATUS=
 RFLINT_STATUS=
 SHELLCHECK_STATUS=
-JASMINE_STATUS=
+JEST_STATUS=
 HTML_STATUS=
 ENFORCER_STATUS=
 TEST_STATUS=
@@ -86,7 +86,7 @@ POM_TIME=0
 BOOTLINT_TIME=0
 RFLINT_TIME=0
 SHELLCHECK_TIME=0
-JASMINE_TIME=0
+JEST_TIME=0
 HTML_TIME=0
 ENFORCER_TIME=0
 TEST_TIME=0
@@ -149,7 +149,7 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
 				fi
 
 				[ "$AFFECTS_GROOVY_FILES" != 'no' ] || CODENARC_STATUS=skip
-				[ "$AFFECTS_JS_FILES" != 'no' ] || JASMINE_STATUS=skip
+				[ "$AFFECTS_JS_FILES" != 'no' ] || JEST_STATUS=skip
 			fi
 
 			if [ "$AFFECTS_TRAVIS_CFG" = 'no' ]; then
@@ -226,12 +226,12 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
 	fi
 	print_status "$SHELLCHECK_STATUS" "$SHELLCHECK_TIME" 'Run shellcheck'
 
-	if [ "$JASMINE_STATUS" != 'skip' ]; then
+	if [ "$JEST_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
-		"$EXEC_CMD" jasmine >jasmine.log 2>&1 || JASMINE_STATUS=fail
-		JASMINE_TIME=$((SECONDS - START_TIME))
+		"$EXEC_CMD" jest >jest.log 2>&1 || JEST_STATUS=fail
+		JEST_TIME=$((SECONDS - START_TIME))
 	fi
-	print_status "$JASMINE_STATUS" "$JASMINE_TIME" 'Run JavaScript unit tests'
+	print_status "$JEST_STATUS" "$JEST_TIME" 'Run JavaScript unit tests'
 
 	if [ "$HTML_STATUS" != 'skip' ]; then
 		"$EXEC_CMD" html5validator >validator.log 2>&1 || HTML_STATUS=fail
@@ -299,7 +299,7 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
 	[ "$BOOTLINT_STATUS" = 'skip' ]       || print_log bootlint.log       'Run bootlint'
 	[ "$RFLINT_STATUS" = 'skip' ]         || print_log rflint.log         'Run robot framework lint'
 	[ "$SHELLCHECK_STATUS" = 'skip' ]     || print_log shellcheck.log     'Run shellcheck'
-	[ "$JASMINE_STATUS" = 'skip' ]        || print_log jasmine.log        'Run JavaScript unit tests'
+	[ "$JEST_STATUS" = 'skip' ]           || print_log jest.log           'Run JavaScript unit tests'
 	[ "$HTML_STATUS" = 'skip' ]           || print_log validator.log      'Run html5validator'
 	[ "$ENFORCER_STATUS" = 'skip' ]       || print_log enforcer.log       'Run maven-enforcer-plugin'
 	[ "$TEST_STATUS" = 'skip' ]           || print_log test.log           'Run unit tests'
@@ -314,8 +314,8 @@ if [ "$DANGER_STATUS" != 'skip' ]; then
 	print_log danger.log 'Run danger'
 fi
 
-rm -f cs.log pmd.log license.log pom.log bootlint.log rflint.log shellcheck.log jasmine.log validator.log enforcer.log test.log codenarc.log spotbugs.log verify.log danger.log ansible_lint.log
+rm -f cs.log pmd.log license.log pom.log bootlint.log rflint.log shellcheck.log jest.log validator.log enforcer.log test.log codenarc.log spotbugs.log verify.log danger.log ansible_lint.log
 
-if echo "$CS_STATUS$PMD_STATUS$LICENSE_STATUS$POM_STATUS$BOOTLINT_STATUS$RFLINT_STATUS$SHELLCHECK_STATUS$JASMINE_STATUS$HTML_STATUS$ENFORCER_STATUS$TEST_STATUS$CODENARC_STATUS$SPOTBUGS_STATUS$VERIFY_STATUS$DANGER_STATUS$ANSIBLE_LINT_STATUS" | grep -Fqs 'fail'; then
+if echo "$CS_STATUS$PMD_STATUS$LICENSE_STATUS$POM_STATUS$BOOTLINT_STATUS$RFLINT_STATUS$SHELLCHECK_STATUS$JEST_STATUS$HTML_STATUS$ENFORCER_STATUS$TEST_STATUS$CODENARC_STATUS$SPOTBUGS_STATUS$VERIFY_STATUS$DANGER_STATUS$ANSIBLE_LINT_STATUS" | grep -Fqs 'fail'; then
 	exit 1
 fi

src/main/scripts/execute-command.sh

@@ -88,10 +88,12 @@ case ${1:-} in
 			-Denforcer.skip=true \
 			-DskipUnitTests=true
 		;;
-	'jasmine')
+	'jest')
 		exec "$MVN" \
 			--batch-mode \
-			jasmine:test
+			--activate-profiles frontend \
+			frontend:npm \
+			-Dfrontend.npm.arguments='test'
 		;;
 	'pmd')
 		exec "$MVN" \
@@ -144,7 +146,7 @@ case ${1:-} in
 		echo >&2 '- enforcer'
 		echo >&2 '- html5validator'
 		echo >&2 '- integration-tests'
-		echo >&2 '- jasmine'
+		echo >&2 '- jest'
 		echo >&2 '- pmd'
 		echo >&2 '- rflint'
 		echo >&2 '- shellcheck'