Skip to content

Commit 9c77d27

Browse files
committed
docs: resurrect a workaround for pdd and non-utf8 charset
Relate to #1610 [skip ci]
1 parent 9cb5dba commit 9c77d27

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/decisions-log.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
| 07.04.2020 Decision | Add new type of change of commits: `improve` We need this because many changes in a series import are naturally fit into this category: they aren't new features as they are small, they aren't bugs as they were discovered during site usage. Unfortunately there is no related type in the current conventional commits specification. See discussions: [conventional-commits/conventionalcommits.org#66](https://github.com/conventional-commits/conventionalcommits.org/issues/66) and [conventional-commits/conventionalcommits.org#78](https://github.com/conventional-commits/conventionalcommits.org/issues/78) |
2020
| 07.03.2020 Workaround | [php-coder/mystamps#1072](https://github.com/php-coder/mystamps/issues/1072): AJAX-related tests don't work in **htmlunit** and fail with `ReferenceError: "Headers" is not defined`. When the code got updated to use another version of constructor of `Headers` class, tests fail with error `ReferenceError: "fetch" is not defined` error. Bug: [HtmlUnit/htmlunit#78](https://github.com/HtmlUnit/htmlunit/issues/78) Workaround: because "the fetch api is not supported so far", let's use axios library instead. Commits: [f224e94](https://github.com/php-coder/mystamps/commit/f224e944b367036458ce9d7ce0c596504766ef8e) |
2121
| ~~07.03.2020 Workaround~~ | ~~[php-coder/mystamps#1072](https://github.com/php-coder/mystamps/issues/1072): `sendKeys()` method from **htmlunit** fails with `StringIndexOutOfBoundsException: start > length()` exception when we fill a field again. Bug: [HtmlUnit/htmlunit#142](https://github.com/HtmlUnit/htmlunit/issues/142) Workaround: open a page on every test to avoid a state from other tests. Commits: [943afba](https://github.com/php-coder/mystamps/commit/943afba4f60b3df47e678a274186b80702e7562c)~~<br/>UPDATE(19.01.2021): in [dd61abf5](https://github.com/php-coder/mystamps/commit/dd61abf577e115a2d935fd0bc6d1f233046e6e85) the workaround has been reverted as since [c7e61df8](https://github.com/php-coder/mystamps/commit/c7e61df884ee4c1d418c5eacbb0267b98f75f1f0) we have the version that doesn't contain this bug |
22-
| ~~09.02.2020 Workaround~~ | ~~**pdd** fails to parse files in charsets other than UTF-8 with error `invalid byte sequence in UTF-8`. Workaround: exclude `src/test/wiremock` directory. Bug: [yegor256/pdd#143](https://github.com/yegor256/pdd/issues/143) Commits: [30aab7d](https://github.com/php-coder/mystamps/commit/30aab7dc8c265804efef382422e7cae9e53187f3), [ab563b6](https://github.com/php-coder/mystamps/commit/ab563b653279625120121babccdfd915181ee46d)~~<br/>UPDATE(05.06.2023): in commit [195aa4c](https://github.com/php-coder/mystamps/commit/195aa4c28aa12750a6aa50cca259f97eda1f0691) ([#1595](https://github.com/php-coder/mystamps/issues/1595)) we stopped using 0pdd, so this is no longer an issue |
22+
| 09.02.2020 Workaround | ~~**pdd** fails to parse files in charsets other than UTF-8 with error `invalid byte sequence in UTF-8`. Workaround: exclude `src/test/wiremock` directory. Bug: [yegor256/pdd#143](https://github.com/yegor256/pdd/issues/143) Commits: [30aab7d](https://github.com/php-coder/mystamps/commit/30aab7dc8c265804efef382422e7cae9e53187f3), [ab563b6](https://github.com/php-coder/mystamps/commit/ab563b653279625120121babccdfd915181ee46d)~~<br/>~~UPDATE(05.06.2023): in commit [195aa4c](https://github.com/php-coder/mystamps/commit/195aa4c28aa12750a6aa50cca259f97eda1f0691) ([#1595](https://github.com/php-coder/mystamps/issues/1595)) we stopped using 0pdd, so this is no longer an issue~~<br/>UPDATE(12.06.2023): in commit [597aabf5](https://github.com/php-coder/mystamps/commit/597aabf5c2ca7f5406d81fed067e5e49dc91af1f) ([#1610](https://github.com/php-coder/mystamps/issues/1610)) we started to use pdd again, so I put the workaround back |
2323
| 07.02.2020 Workaround | [php-coder/mystamps#1248](https://github.com/php-coder/mystamps/issues/1248): **wiremock** logs warnings for static resources when there is no stub mapping. Workaround: create mappings for such resources. Bug: [tomakehurst/wiremock#1247](https://github.com/tomakehurst/wiremock/issues/1247) Commits: [0018ad4](https://github.com/php-coder/mystamps/commit/0018ad44a21379b8179f94e954795c66b6d50bbc) |
2424
| ~~24.11.2019 Workaround~~ | ~~[php-coder/mystamps#1156](https://github.com/php-coder/mystamps/issues/1156) After updating **html5validator** to 0.3.2, the `--ignore-re` has stopped to work. Workaround: revert and pin the version to 0.3.1 Bug: [svenkreiss/html5validator#64](https://github.com/svenkreiss/html5validator/issues/64) Commits: [9a0d695](https://github.com/php-coder/mystamps/commit/9a0d695ccac1deeba0c4280779bbac11ebf3ac4d)~~<br/> UPDATE(22.12.2020): in [61c97a4f](https://github.com/php-coder/mystamps/commit/61c97a4f2435e7cdf17c0ad6866f7b99cb640e3b) ([#1169](https://github.com/php-coder/mystamps/issues/1169)) html5validator has been updated to 0.3.3 that fixed the issue |
2525
| 16.01.2019 Decision | [php-coder/mystamps#971](https://github.com/php-coder/mystamps/issues/971): One more tool for static analysis has been added: **errorprone**. I've disabled `MissingOverride` check because we use `@Getter` from Lombok that doesn't add `@Override` annotation by default. I think that placing a more complex annotation on every required field doesn't worth the effort. Commits: [6aeba7da9](https://github.com/php-coder/mystamps/commit/6aeba7da9aaf50298ec42b3259274048f452d4bf) |

0 commit comments

Comments
 (0)