Skip to content

Commit 96ecb56

Browse files
authored
chore: document that mysql-connector-java has been fixed
Relate #1184 [skip ci]
1 parent 9322d3e commit 96ecb56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/decisions-log.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
| ~~16.01.2019 Workaround~~ | ~~[php-coder/mystamps#971](https://github.com/php-coder/mystamps/issues/971): I disabled **errorprone** `ParameterName` check to workaround an existing bug in the current version. Commits: [6aeba7da](https://github.com/php-coder/mystamps/commit/6aeba7da9aaf50298ec42b3259274048f452d4bf) Bug: [google/error-prone#780](https://github.com/google/error-prone/issues/780)~~<br/> UPDATE(25.05.2019): in [8a5542eb](https://github.com/php-coder/mystamps/commit/8a5542eb48e0da67837ccbf4d4d318bee4a7f4ff) `ParameterName` check has been enabled again after update to 2.3.3 version |
3737
| 23.12.2018 Decision | [php-coder/mystamps#967](https://github.com/php-coder/mystamps/issues/967) "Show similar series" feature has been added with the following notes:<br/>- there is no limit for a number of series that will be displayed. I thought about limiting to 3 but I decided to leave it as-is for now<br/>- the order of the series isn't defined. In the initial idea, I thought about showing only 3 series in a random order but it's hard to implement in a database-agnostic way<br/>Commits: [054f826e](https://github.com/php-coder/mystamps/commit/054f826ef6706f82b4a7c04d73715d161d0c1a28) |
3838
| 14.10.2018 Workaround | [php-coder/mystamps#76](https://github.com/php-coder/mystamps/issues/76) Because our existing infrastructure lives in Moscow time and data is stored in this format, I've configured **Docker container** to use `Europe/Moscow` timezone instead of UTC that was used by default. Commits: [8c4e9db2](https://github.com/php-coder/mystamps/commit/8c4e9db272b103818d74c94a68ba95d1b082d3a4) |
39-
| 29.09.2018 Workaround | After [upgrade of **mysql-connector-java** to 5.1.47](https://github.com/php-coder/mystamps/commit/21e3a7a361990d6059cb7668c1217f653bd0ae8f), the bug that [causes NullPointerException](https://travis-ci.org/php-coder/mystamps/jobs/435000067) was revealed. I reverted the version back to 5.1.46 Issue: https://bugs.mysql.com/bug.php?id=92089 Commits: [3cb0dac9](https://github.com/php-coder/mystamps/commit/3cb0dac9fb62bbc12331b7ea1378f3b56746714d) |
39+
| ~~29.09.2018 Workaround~~ | ~~After [upgrade of **mysql-connector-java** to 5.1.47](https://github.com/php-coder/mystamps/commit/21e3a7a361990d6059cb7668c1217f653bd0ae8f), the bug that [causes NullPointerException](https://travis-ci.org/php-coder/mystamps/jobs/435000067) was revealed. I reverted the version back to 5.1.46 Issue: https://bugs.mysql.com/bug.php?id=92089 Commits: [3cb0dac9](https://github.com/php-coder/mystamps/commit/3cb0dac9fb62bbc12331b7ea1378f3b56746714d)~~<br />UPDATE(26.10.2023): the bug has been fixed in 5.1.48 and we got it with update to 5.1.49 Issue: [php-coder/mystamps#1184](https://github.com/php-coder/mystamps/issues/1184) Commit: [a8f0af73](https://github.com/php-coder/mystamps/commit/a8f0af730442ba4f12c0af83d6f0358defdf2f8a) |
4040
| 30.12.2017 Workaround | [php-coder/mystamps#772](https://github.com/php-coder/mystamps/issues/772) Because **Travis CI** has **MySQL** version 5.6.43, we can't have a unique index on a column that has a length that exceeds 767 bytes. Our production server is running on 5.7.20 that doesn't have such limitation. In order to be able to run migrations on all the environments, I set type of the `series_import_requests.url` column to `VARCHAR(767)` (instead of `VARCHAR(768)` or `VARCHAR(1024)` as I wanted before). Commits: [33dd9025](https://github.com/php-coder/mystamps/commit/33dd902500501d3fdc3a744229ad921982adbc01) |
4141
| 20.07.2017 Decision | [php-coder/mystamps#423](https://github.com/php-coder/mystamps/issues/423) Most of our **checks on CI** now get executed only when files of a certain type were modified. This should give us a faster feedback loop. Checks are also being run when their configuration has been changed. If check performed by a maven plugin, it will be always run when `pom.xml` is modified. The same logic applies to the tools that are being installed from the `.travis.yml` file. Unfortunately, we have to unconditionally run checks even if a change in a file wasn't related to the plugin/tool configuration. Also there is no way to disable skipping logic and if you need to run a specific check there is no way to force its execution. I was thinking about introducing an environment variable or using a special magic comment from a commit message but I decided to leave it as-is for a now (although it can be added later). Commits: [7da91a53](https://github.com/php-coder/mystamps/commit/7da91a53a1d7f43670d67adfce359814fa7ee27a) |
4242
| 29.05.2017 Workaround | [php-coder/mystamps#588](https://github.com/php-coder/mystamps/issues/588) In order to import **test image** into database I had to move the image file from `src/test/resources` to `src/main/resources` directory because **Liquibase** is executing during the startup and it doesn't distinguish between test and main resources (it just searches in a class path). Commits: [646bb167](https://github.com/php-coder/mystamps/commit/646bb16706d3dc41fe8d613f101ac6679ac5cc92) |

0 commit comments

Comments
 (0)