refactor: remove the elements for showing errors from DOM when there is no errors

This also should simplify our integration tests because now they can wait only for element presence.
Previously they also had to wait for an error message.

Relate to #1411

Author: php-coder

src/main/frontend/src/components/AddCommentForm.js

@@ -98,12 +98,13 @@ class AddCommentFormView extends React.PureComponent {
 					aria-label={ l10n['t_add_comment'] || 'Add a comment' }
 					className={ `form-horizontal ${hasValidationErrors ? 'has-error' : ''}` }
 					onSubmit={ handleSubmit }>
-					<div
-						id="add-comment-failed-msg"
-						role="alert"
-						className={ `alert alert-danger text-center col-sm-8 col-sm-offset-2 ${hasServerError ? '' : 'hidden'}` }>
-						{ l10n['t_server_error'] || 'Server error' }
-					</div>
+					{ hasServerError &&
+						<div id="add-comment-failed-msg"
+							role="alert"
+							className="alert alert-danger text-center col-sm-8 col-sm-offset-2">
+							{ l10n['t_server_error'] || 'Server error' }
+						</div>
+					}
 					<div className="form-group form-group-sm">
 						<label htmlFor="new-comment" className="control-label col-sm-3 required-field">
 							{ l10n['t_comment'] || 'Comment' }
@@ -120,11 +121,11 @@ class AddCommentFormView extends React.PureComponent {
 						</div>
 					</div>
 					<div className="col-sm-offset-3 col-sm-4">
-						<span
-							id="new-comment.errors"
-							className={ `help-block ${hasValidationErrors ? '' : 'hidden'}` }>
-							{ validationErrors.join(', ') }
-						</span>
+						{ hasValidationErrors &&
+							<span id="new-comment.errors" className="help-block">
+								{ validationErrors.join(', ') }
+							</span>
+						}
 						<button
 							type="submit"
 							className="btn btn-primary btn-sm"

src/main/frontend/src/components/AddCommentForm.test.js

@@ -41,7 +41,6 @@ describe('AddCommentFormView', () => {
 			// then
 			const alert = screen.getByRole('alert');
 			expect(alert).toHaveTextContent('Server error');
-			expect(alert).not.toHaveClass('hidden');
 		});
 
 		it('the comment field', () => {
@@ -58,7 +57,6 @@ describe('AddCommentFormView', () => {
 			// @todo #1489 Use toHaveErrorMessage() or toHaveDescription() for checking error messages
 			const fieldErrors = container.querySelector('#new-comment\\.errors');
 			expect(fieldErrors).not.toBeNull();
-			expect(fieldErrors).not.toHaveClass('hidden');
 			expect(fieldErrors).toHaveTextContent('err1, err2');
 		});
 	});

src/main/java/ru/mystamps/web/feature/site/ResourceUrl.java

@@ -32,7 +32,7 @@ public final class ResourceUrl {
 	public static final String STATIC_RESOURCES_URL = "https://stamps.filezz.ru";
 
 	// MUST be updated when any of our resources were modified
-	public static final String RESOURCES_VERSION = "v0.4.5.3";
+	public static final String RESOURCES_VERSION = "v0.4.5.4";
 
 	// CheckStyle: ignore LineLength for next 16 lines
 	private static final String CATALOG_UTILS_JS      = "/public/js/" + RESOURCES_VERSION + "/CatalogUtils.min.js";