refactor: removed unused releaseDay/releaseMonth members.

Author: php-coder

src/main/java/ru/mystamps/web/feature/collection/RowMappers.java

@@ -45,8 +45,6 @@ private RowMappers() {
 		Integer seriesId     = rs.getInt("id");
 		String category      = rs.getString("category");
 		String country       = rs.getString("country");
-		Integer releaseDay   = JdbcUtils.getInteger(rs, "release_day");
-		Integer releaseMonth = JdbcUtils.getInteger(rs, "release_month");
 		Integer releaseYear  = JdbcUtils.getInteger(rs, "release_year");
 		Integer quantity     = rs.getInt("quantity");
 		Boolean perforated   = rs.getBoolean("perforated");
@@ -56,8 +54,6 @@ private RowMappers() {
 			seriesId,
 			category,
 			country,
-			releaseDay,
-			releaseMonth,
 			releaseYear,
 			perforated,
 			quantity,

src/main/java/ru/mystamps/web/feature/collection/SeriesInCollectionDto.java

@@ -26,8 +26,6 @@ public class SeriesInCollectionDto {
 	private final Integer id;
 	private final String category;
 	private final String country;
-	private final Integer releaseDay;
-	private final Integer releaseMonth;
 	private final Integer releaseYear;
 	private final Boolean perforated;
 	private final Integer quantity;

src/main/java/ru/mystamps/web/feature/series/RowMappers.java

@@ -61,8 +61,6 @@ private RowMappers() {
 		throws SQLException {
 
 		Integer seriesId     = rs.getInt("id");
-		Integer releaseDay   = JdbcUtils.getInteger(rs, "release_day");
-		Integer releaseMonth = JdbcUtils.getInteger(rs, "release_month");
 		Integer releaseYear  = JdbcUtils.getInteger(rs, "release_year");
 		Integer quantity     = rs.getInt("quantity");
 		Boolean perforated   = rs.getBoolean("perforated");
@@ -76,8 +74,6 @@ private RowMappers() {
 			seriesId,
 			category,
 			country,
-			releaseDay,
-			releaseMonth,
 			releaseYear,
 			quantity,
 			perforated

src/main/java/ru/mystamps/web/feature/series/SeriesInfoDto.java

@@ -18,35 +18,16 @@
 package ru.mystamps.web.feature.series;
 
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import ru.mystamps.web.common.LinkEntityDto;
 
 @Getter
+@RequiredArgsConstructor
 public class SeriesInfoDto {
 	private final Integer id;
 	private final LinkEntityDto category;
 	private final LinkEntityDto country;
-	private final Integer releaseDay;
-	private final Integer releaseMonth;
 	private final Integer releaseYear;
 	private final Integer quantity;
 	private final Boolean perforated;
-	
-	@SuppressWarnings("checkstyle:parameternumber")
-	public SeriesInfoDto(
-			Integer id,
-			LinkEntityDto category,
-			LinkEntityDto country,
-			Integer releaseDay, Integer releaseMonth, Integer releaseYear,
-			Integer quantity,
-			Boolean perforated) {
-		this.id = id;
-		this.category = category;
-		this.country = country;
-		this.releaseDay = releaseDay;
-		this.releaseMonth = releaseMonth;
-		this.releaseYear = releaseYear;
-		this.quantity = quantity;
-		this.perforated = perforated;
-	}
-	
 }

src/main/resources/sql/collection_dao_queries.properties

@@ -14,8 +14,6 @@ collection.find_series_by_collection_id = \
    SELECT s.id \
         , CASE WHEN 'ru' = :lang THEN COALESCE(cat.name_ru, cat.name) ELSE cat.name END AS category \
         , CASE WHEN 'ru' = :lang THEN COALESCE(count.name_ru, count.name) ELSE count.name END AS country \
-        , s.release_day \
-        , s.release_month \
         , s.release_year \
         , s.quantity \
         , s.perforated \

src/main/resources/sql/series_dao_queries.properties

@@ -134,8 +134,6 @@ series.find_by_ids = \
         , count.id AS country_id \
         , count.slug AS country_slug \
         , CASE WHEN 'ru' = :lang THEN COALESCE(count.name_ru, count.name) ELSE count.name END AS country_name \
-        , s.release_day \
-        , s.release_month \
         , s.release_year \
         , s.quantity \
         , s.perforated \
@@ -154,8 +152,6 @@ series.find_by_category_slug = \
         , count.id AS country_id \
         , count.slug AS country_slug \
         , CASE WHEN 'ru' = :lang THEN COALESCE(count.name_ru, count.name) ELSE count.name END AS country_name \
-        , s.release_day \
-        , s.release_month \
         , s.release_year \
         , s.quantity \
         , s.perforated \

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -149,7 +149,7 @@ public static SeriesInfoDto createSeriesInfoDto() {
 			Random.id(),
 			new LinkEntityDto(Random.id(), SlugUtils.slugify(category), category),
 			new LinkEntityDto(Random.id(), SlugUtils.slugify(country), country),
-			15, 10, Random.issueYear(),
+			Random.issueYear(),
 			16,
 			Random.perforated()
 		);
@@ -172,7 +172,9 @@ public static SeriesFullInfoDto createSeriesFullInfoDto() {
 			info.getId(),
 			info.getCategory(),
 			info.getCountry(),
-			info.getReleaseDay(), info.getReleaseMonth(), info.getReleaseYear(),
+			Random.dayOfMonth(),
+			Random.monthOfYear(),
+			info.getReleaseYear(),
 			info.getQuantity(),
 			info.getPerforated(),
 			"this is a full info",