Skip to content

Commit 707a25a

Browse files
committed
DatabaseImagePersistenceStrategyTest: combine 2 unit tests info one.
No functional changes.
1 parent d0eabf2 commit 707a25a

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

src/test/groovy/ru/mystamps/web/service/DatabaseImagePersistenceStrategyTest.groovy

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -99,22 +99,6 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
9999
// Tests for get()
100100
//
101101

102-
@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
103-
def "get() should pass image to image data dao"() {
104-
given:
105-
Integer expectedImageId = imageInfoDto.id
106-
when:
107-
strategy.get(imageInfoDto)
108-
then:
109-
1 * imageDataDao.findByImageId({ Integer imageId ->
110-
assert imageId == expectedImageId
111-
return true
112-
}, { Boolean preview ->
113-
assert preview == false
114-
return true
115-
})
116-
}
117-
118102
def "get() should return null when image data dao returned null"() {
119103
given:
120104
imageDataDao.findByImageId(_ as Integer, _ as Boolean) >> null
@@ -126,12 +110,20 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
126110

127111
def "get() should return result from image data dao"() {
128112
given:
129-
ImageDto expectedImageDto = TestObjects.createDbImageDto()
113+
Integer expectedImageId = imageInfoDto.id
130114
and:
131-
imageDataDao.findByImageId(_ as Integer, _ as Boolean) >> expectedImageDto
115+
ImageDto expectedImageDto = TestObjects.createDbImageDto()
132116
when:
133117
ImageDto result = strategy.get(imageInfoDto)
134118
then:
119+
1 * imageDataDao.findByImageId({ Integer imageId ->
120+
assert imageId == expectedImageId
121+
return true
122+
}, { Boolean preview ->
123+
assert preview == false
124+
return true
125+
}) >> expectedImageDto
126+
and:
135127
result == expectedImageDto
136128
}
137129

0 commit comments

Comments
 (0)