Skip to content

Commit 6f72c3b

Browse files
committed
revert: "Dangerfile: don't show some warnings/messages to dependabot."
This reverts commit d5e0f52. [ci skip]
1 parent 6997113 commit 6f72c3b

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

Dangerfile

+4-7
Original file line numberDiff line numberDiff line change
@@ -698,18 +698,15 @@ if File.file?(failsafe_report)
698698
end
699699
end
700700

701-
# Don't show some warnings/messages to a bot, it doesn't read them
702-
prFromRealUser = github.pr_author != 'dependabot'
703-
704-
if prFromRealUser && github.pr_body !~ /Addressed to #\d+/
701+
if github.pr_body !~ /Addressed to #\d+/
705702
warn(
706703
"danger check: pull request description doesn't contain a link to original issue.\n"\
707704
"Consider adding a comment in the following format: `Addressed to #XXX` where `XXX` is an issue number"
708705
)
709706
end
710707

711708
commits = git.commits.size
712-
if prFromRealUser && commits > 1
709+
if commits > 1
713710
if git.commits.any? { |c| c.message =~ /^Merge branch/ || c.message =~ /^Merge remote-tracking branch/ }
714711
fail(
715712
"danger check: pull request contains merge commits! "\
@@ -725,7 +722,7 @@ if prFromRealUser && commits > 1
725722
end
726723
end
727724

728-
if prFromRealUser && github.branch_for_head !~ /^gh[0-9]+_/
725+
if github.branch_for_head !~ /^gh[0-9]+_/
729726
warn("danger check: branch `#{github.branch_for_head}` does not comply with our best practices. "\
730727
"Branch name should use the following scheme: `ghXXX_meaningful-name` where `XXX` is an issue number. "\
731728
"**Next time**, please, use this scheme :)"
@@ -741,7 +738,7 @@ if modified_resources && !updated_url
741738
end
742739

743740
all_checks_passed = violation_report[:errors].empty? && violation_report[:warnings].empty? && violation_report[:messages].empty?
744-
if prFromRealUser && all_checks_passed
741+
if all_checks_passed
745742
message(
746743
"@#{github.pr_author} thank you for the PR! All quality checks have been passed! "\
747744
"Next step is to wait when @php-coder will review this code"

0 commit comments

Comments
 (0)