Skip to content

Commit 6af463b

Browse files
committed
ci: decommission of html5validator
The following issue won't be fixed: Closes #541 Closes #760 Part of #1669
1 parent e42e338 commit 6af463b

File tree

2 files changed

+0
-35
lines changed

2 files changed

+0
-35
lines changed

.github/workflows/static-analysis.yml

-15
Original file line numberDiff line numberDiff line change
@@ -130,21 +130,6 @@ jobs:
130130
- name: Run shellcheck
131131
run: ./src/main/scripts/execute-command.sh shellcheck
132132

133-
run-html5validator:
134-
name: Run html5validator
135-
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
136-
runs-on: ubuntu-20.04
137-
steps:
138-
- name: Clone source code
139-
uses: actions/[email protected] # https://github.com/actions/checkout
140-
with:
141-
# Whether to configure the token or SSH key with the local git config. Default: true
142-
persist-credentials: false
143-
- name: Install html5validator
144-
run: pip3 install --user html5validator==0.4.2
145-
- name: Run html5validator
146-
run: ./src/main/scripts/execute-command.sh html5validator
147-
148133
run-ansible-lint:
149134
name: Run ansible-lint
150135
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on

src/main/scripts/execute-command.sh

-20
Original file line numberDiff line numberDiff line change
@@ -52,25 +52,6 @@ case ${1:-} in
5252
--batch-mode \
5353
enforcer:enforce
5454
;;
55-
'html5validator')
56-
# FIXME: remove ignoring of error about alt attribute after resolving #314
57-
# @todo #109 Check src/main/config/nginx/503.*html by html5validator
58-
# @todo #695 /series/import/request/{id}: use divs instead of table for elements aligning
59-
exec html5validator \
60-
--root "$ROOTDIR/src/main/webapp/WEB-INF/views" \
61-
--no-langdetect \
62-
--ignore-re \
63-
'Attribute “(th|sec|togglz|xmlns):[a-z]+” not allowed' \
64-
'Attribute “th:[-a-z]+” not allowed on element "body" at this point' \
65-
'Attribute “(th|sec|togglz):[-a-z]+” is not serializable' \
66-
'Attribute with the local name “xmlns:[a-z]+” is not serializable' \
67-
--ignore \
68-
'An "img" element must have an "alt" attribute' \
69-
'Element "option" without attribute "label" must not be empty' \
70-
'The "width" attribute on the "td" element is obsolete' \
71-
'Attribute "loading" not allowed on element "img" at this point' \
72-
--show-warnings
73-
;;
7455
'integration-tests')
7556
exec "$MVN" \
7657
--batch-mode \
@@ -127,7 +108,6 @@ case ${1:-} in
127108
echo >&2 '- checkstyle'
128109
echo >&2 '- codenarc'
129110
echo >&2 '- enforcer'
130-
echo >&2 '- html5validator'
131111
echo >&2 '- integration-tests'
132112
echo >&2 '- jest'
133113
echo >&2 '- pmd'

0 commit comments

Comments
 (0)