build: enable ErrorProne during code compilation.

See https://errorprone.info

Fix #971

Author: php-coder

pom.xml

@@ -493,6 +493,8 @@
 
 		<dockerfile.plugin.version>1.4.6</dockerfile.plugin.version>
 		<enforcer.plugin.version>1.4.1</enforcer.plugin.version>
+		<error-prone-javac.version>9+181-r4173-1</error-prone-javac.version>
+		<error-prone.version>2.3.2</error-prone.version>
 		<failsafe.plugin.version>2.22.0</failsafe.plugin.version>
 		<fest.assert.version>2.0M8</fest.assert.version>
 		<findbugs.excludeFilterFile>src/main/config/findbugs-filter.xml</findbugs.excludeFilterFile>
@@ -781,6 +783,29 @@
 					<failOnWarning>true</failOnWarning>
 					<!-- Required for using method's parameters inside of @PreAuthorize expressions -->
 					<parameters>true</parameters>
+					<!-- Required for ErrorProne -->
+					<!-- @todo #971 Document ErrorProne tool -->
+					<compilerArgs>
+						<compilerArg>-XDcompilePolicy=simple</compilerArg>
+						<!--
+							The following checks have been disabled:
+							- MissingOverride: produce false positives with @Getter from Lombok
+							- ParameterName: workaround for https://github.com/google/error-prone/issues/780
+						-->
+						<compilerArg>-Xplugin:ErrorProne -Xep:MissingOverride:OFF -Xep:ParameterName:OFF</compilerArg>
+					</compilerArgs>
+					<annotationProcessorPaths>
+						<path>
+							<groupId>com.google.errorprone</groupId>
+							<artifactId>error_prone_core</artifactId>
+							<version>${error-prone.version}</version>
+						</path>
+						<path>
+							<groupId>org.projectlombok</groupId>
+							<artifactId>lombok</artifactId>
+							<version>${lombok.version}</version>
+						</path>
+					</annotationProcessorPaths>
 				</configuration>
 			</plugin>
 
@@ -1189,4 +1214,30 @@
 		<url>https://github.com/php-coder/mystamps</url>
 	</scm>
 
+	<profiles>
+		<profile>
+			<id>jdk8</id>
+			<activation>
+				<jdk>1.8</jdk>
+			</activation>
+			<build>
+				<plugins>
+					<!-- Required for ErrorProne -->
+					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
+						<artifactId>maven-compiler-plugin</artifactId>
+						<configuration>
+							<fork>true</fork>
+							<compilerArgs combine.children="append">
+								<compilerArg>
+									-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${error-prone-javac.version}/javac-${error-prone-javac.version}.jar
+								</compilerArg>
+							</compilerArgs>
+						</configuration>
+					</plugin>
+				</plugins>
+			</build>
+		</profile>
+	</profiles>
+	
 </project>

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -680,7 +680,7 @@ private static boolean isAllowedToAddingImages(SeriesDto series) {
 
 	private static boolean isUserCanAddImagesToSeries(SeriesDto series) {
 		return isAdmin()
-			|| isOwner(series) && isAllowedToAddingImages(series);
+			|| (isOwner(series) && isAllowedToAddingImages(series));
 	}
 
 	private static boolean isAdmin() {

src/main/java/ru/mystamps/web/support/spring/security/CustomUserDetailsService.java

@@ -17,8 +17,8 @@
  */
 package ru.mystamps.web.support.spring.security;
 
+import java.util.ArrayList;
 import java.util.Collection;
-import java.util.LinkedList;
 import java.util.List;
 
 import org.apache.commons.lang3.Validate;
@@ -68,7 +68,7 @@ public org.springframework.security.core.userdetails.UserDetails loadUserByUsern
 
 	private static Collection<? extends GrantedAuthority> getAuthorities(UserDetails userDetails) {
 		// Constants sorted in an ascending order.
-		List<GrantedAuthority> authorities = new LinkedList<>();
+		List<GrantedAuthority> authorities = new ArrayList<>();
 		authorities.add(Authority.CREATE_CATEGORY);
 		authorities.add(Authority.CREATE_COUNTRY);
 		authorities.add(Authority.CREATE_SERIES);