Skip to content

Commit 6337b84

Browse files
committed
UsersActivationServiceImpl: use NOPLogger for unit tests to reduce output to console.
No functional changes.
1 parent 2dc07c7 commit 6337b84

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

src/main/java/ru/mystamps/web/config/ServicesConfig.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,11 @@ public MailService getMailService() {
111111

112112
@Bean
113113
public UsersActivationService getUsersActivationService() {
114-
return new UsersActivationServiceImpl(daoConfig.getUsersActivationDao(), getMailService());
114+
return new UsersActivationServiceImpl(
115+
LoggerFactory.getLogger(UsersActivationServiceImpl.class),
116+
daoConfig.getUsersActivationDao(),
117+
getMailService()
118+
);
115119
}
116120

117121
@Bean

src/main/java/ru/mystamps/web/service/UsersActivationServiceImpl.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.apache.commons.lang3.time.DateUtils;
2727

2828
import org.slf4j.Logger;
29-
import org.slf4j.LoggerFactory;
3029

3130
import org.springframework.transaction.annotation.Transactional;
3231

@@ -44,8 +43,8 @@
4443

4544
@RequiredArgsConstructor
4645
public class UsersActivationServiceImpl implements UsersActivationService {
47-
private static final Logger LOG = LoggerFactory.getLogger(UsersActivationServiceImpl.class);
4846

47+
private final Logger log;
4948
private final UsersActivationDao usersActivationDao;
5049
private final MailService mailService;
5150

@@ -63,7 +62,7 @@ public void add(RegisterAccountDto dto, Locale lang) {
6362
activation.setCreatedAt(new Date());
6463
usersActivationDao.add(activation);
6564

66-
LOG.info("Users activation has been created ({})", activation);
65+
log.info("Users activation has been created ({})", activation);
6766

6867
if (Features.SEND_ACTIVATION_MAIL.isActive()) {
6968
mailService.sendActivationKeyToUser(new SendUsersActivationDto(activation));
@@ -77,7 +76,7 @@ public void remove(String activationKey) {
7776

7877
usersActivationDao.removeByActivationKey(activationKey);
7978

80-
LOG.info("Users activation '{}' has been deleted", activationKey);
79+
log.info("Users activation '{}' has been deleted", activationKey);
8180
}
8281

8382
@Override

src/test/groovy/ru/mystamps/web/service/UsersActivationServiceImplTest.groovy

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ package ru.mystamps.web.service
2020
import spock.lang.Specification
2121
import spock.lang.Unroll
2222

23+
import org.slf4j.helpers.NOPLogger
24+
2325
import ru.mystamps.web.dao.UsersActivationDao
2426
import ru.mystamps.web.dao.dto.AddUsersActivationDbDto
2527
import ru.mystamps.web.dao.dto.UsersActivationDto
@@ -44,7 +46,7 @@ class UsersActivationServiceImplTest extends Specification {
4446
registrationForm = new RegisterAccountForm()
4547
registrationForm.setEmail('[email protected]')
4648

47-
service = new UsersActivationServiceImpl(usersActivationDao, mailService)
49+
service = new UsersActivationServiceImpl(NOPLogger.NOP_LOGGER, usersActivationDao, mailService)
4850
}
4951

5052
//

0 commit comments

Comments
 (0)