refactor(AddSeriesParsedDataDbDto): modify to support multiple image URLs

Part of #698

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/importing/AddSeriesParsedDataDbDto.java

@@ -22,14 +22,15 @@
 import lombok.ToString;
 
 import java.util.Date;
+import java.util.List;
 
 @Getter
 @Setter
 @ToString(exclude = { "createdAt", "updatedAt" })
 public class AddSeriesParsedDataDbDto {
 	private Integer categoryId;
 	private Integer countryId;
-	private String imageUrl;
+	private List<String> imageUrls;
 	private Integer releaseDay;
 	private Integer releaseMonth;
 	private Integer releaseYear;
@@ -39,10 +40,12 @@ public class AddSeriesParsedDataDbDto {
 	private Date createdAt;
 	private Date updatedAt;
 
+	// they aren't useless
+	@SuppressWarnings("PMD.UselessParentheses")
 	public boolean hasAtLeastOneFieldFilled() {
 		return categoryId != null
 			|| countryId != null
-			|| imageUrl != null
+			|| (imageUrls != null && !imageUrls.isEmpty())
 			|| releaseYear != null
 			|| quantity != null
 			|| perforated != null

src/main/java/ru/mystamps/web/feature/series/importing/JdbcSeriesImportDao.java

@@ -185,7 +185,9 @@ public void addParsedData(Integer requestId, AddSeriesParsedDataDbDto data) {
 		params.put("request_id", requestId);
 		params.put("category_id", data.getCategoryId());
 		params.put("country_id", data.getCountryId());
-		params.put("image_url", data.getImageUrl());
+		List<String> imageUrls = data.getImageUrls();
+		String imageUrl = imageUrls == null || imageUrls.isEmpty() ? null : imageUrls.get(0);
+		params.put("image_url", imageUrl);
 		params.put("release_day", data.getReleaseDay());
 		params.put("release_month", data.getReleaseMonth());
 		params.put("release_year", data.getReleaseYear());

src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportServiceImpl.java

@@ -186,8 +186,7 @@ public void saveParsedData(Integer requestId, SeriesExtractedInfo seriesInfo, Li
 		Integer countryId = getFirstElement(seriesInfo.getCountryIds());
 
 		AddSeriesParsedDataDbDto seriesParsedData = new AddSeriesParsedDataDbDto();
-		String imageUrl = getFirstElement(imageUrls);
-		seriesParsedData.setImageUrl(imageUrl);
+		seriesParsedData.setImageUrls(imageUrls);
 		Date now = new Date();
 		seriesParsedData.setCreatedAt(now);
 		seriesParsedData.setUpdatedAt(now);

src/test/groovy/ru/mystamps/web/feature/series/importing/SeriesImportServiceImplTest.groovy

@@ -519,19 +519,15 @@ class SeriesImportServiceImplTest extends Specification {
 	def 'saveParsedData() should save series parsed data'() {
 		given:
 			Integer expectedRequestId = Random.id()
-			String expectedImageUrl = Random.url()
+			List<String> expectedImageUrls = Collections.singletonList(Random.url())
 		when:
-			service.saveParsedData(
-				expectedRequestId,
-				TestObjects.createSeriesExtractedInfo(),
-				Collections.singletonList(expectedImageUrl)
-			)
+			service.saveParsedData(expectedRequestId, TestObjects.createSeriesExtractedInfo(), expectedImageUrls)
 		then:
 			1 * seriesImportDao.addParsedData(
 				expectedRequestId,
 				{ AddSeriesParsedDataDbDto parsedData ->
 					// other members are tested in another test
-					assert parsedData?.imageUrl == expectedImageUrl
+					assert parsedData?.imageUrls == expectedImageUrls
 					assert DateUtils.roughlyEqual(parsedData?.createdAt, new Date())
 					assert DateUtils.roughlyEqual(parsedData?.updatedAt, new Date())
 					return true