refactor(SeriesImportValidation): move series import-related values to the corresponding class.

Addressed to #927

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/importing/RequestImportForm.java

@@ -26,8 +26,6 @@
 import javax.validation.GroupSequence;
 import javax.validation.constraints.Size;
 
-import static ru.mystamps.web.validation.ValidationRules.IMPORT_REQUEST_URL_MAX_LENGTH;
-
 @Getter
 @Setter
 @GroupSequence({
@@ -46,7 +44,7 @@ public class RequestImportForm implements RequestImportDto {
 		// we use IMPORT_REQUEST_URL_MAX_LENGTH here.
 		// Also, as the import saves nothing, this check actually isn't required. Perhaps,
 		// we shouldn't validate on this stage and let it fail later, during a sale creation.
-		max = IMPORT_REQUEST_URL_MAX_LENGTH,
+		max = SeriesImportValidation.IMPORT_REQUEST_URL_MAX_LENGTH,
 		message = "{value.too-long}",
 		groups = Group.Level2.class
 	)

src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportValidation.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2009-2019 Slava Semushin <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.feature.series.importing;
+
+import ru.mystamps.web.feature.series.importing.SeriesImportDb.SeriesImportRequest;
+
+@SuppressWarnings("PMD.CommentDefaultAccessModifier")
+final class SeriesImportValidation {
+	
+	static final int IMPORT_REQUEST_URL_MAX_LENGTH  = SeriesImportRequest.URL_LENGTH;
+	
+	private SeriesImportValidation() {
+	}
+	
+}
+

src/main/java/ru/mystamps/web/validation/ValidationRules.java

@@ -18,7 +18,6 @@
 package ru.mystamps.web.validation;
 
 import ru.mystamps.web.feature.series.SeriesDb.Series;
-import ru.mystamps.web.feature.series.importing.SeriesImportDb.SeriesImportRequest;
 
 public final class ValidationRules {
 
@@ -30,8 +29,6 @@ public final class ValidationRules {
 	@SuppressWarnings({ "PMD.LongVariable", "checkstyle:linelength" })
 	public static final String CATALOG_NUMBERS_AND_LETTERS_REGEXP = "[1-9][0-9]{0,3}[a-z]?(,[1-9][0-9]{0,3}[a-z]?)*";
 
-	public static final int IMPORT_REQUEST_URL_MAX_LENGTH  = SeriesImportRequest.URL_LENGTH;
-	
 	/** Maximum uploading image size in kilobytes. */
 	public static final long MAX_IMAGE_SIZE = 500;