Skip to content

Commit 5a56e2a

Browse files
committed
refactor: update test names and don't mention argument type as there is no ambiguity now.
1 parent 1a85057 commit 5a56e2a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/groovy/ru/mystamps/web/feature/category/CategoryServiceImplTest.groovy

+3-3
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,10 @@ class CategoryServiceImplTest extends Specification {
219219
}
220220

221221
//
222-
// Tests for findAllAsLinkEntities(String)
222+
// Tests for findAllAsLinkEntities()
223223
//
224224

225-
def 'findAllAsLinkEntities(String) should call dao'() {
225+
def 'findAllAsLinkEntities() should call dao'() {
226226
given:
227227
LinkEntityDto category1 = new LinkEntityDto(1, 'first-category', 'First Category')
228228
and:
@@ -238,7 +238,7 @@ class CategoryServiceImplTest extends Specification {
238238
}
239239

240240
@Unroll
241-
def "findAllAsLinkEntities(String) should pass language '#expectedLanguage' to dao"(String expectedLanguage) {
241+
def "findAllAsLinkEntities() should pass language '#expectedLanguage' to dao"(String expectedLanguage) {
242242
when:
243243
service.findAllAsLinkEntities(expectedLanguage)
244244
then:

src/test/groovy/ru/mystamps/web/feature/country/CountryServiceImplTest.groovy

+3-3
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,10 @@ class CountryServiceImplTest extends Specification {
218218
}
219219

220220
//
221-
// Tests for findAllAsLinkEntities(String)
221+
// Tests for findAllAsLinkEntities()
222222
//
223223

224-
def 'findAllAsLinkEntities(String) should call dao'() {
224+
def 'findAllAsLinkEntities() should call dao'() {
225225
given:
226226
LinkEntityDto country1 = new LinkEntityDto(1, 'first-country', 'First Country')
227227
and:
@@ -237,7 +237,7 @@ class CountryServiceImplTest extends Specification {
237237
}
238238

239239
@Unroll
240-
def "findAllAsLinkEntities(String) should pass language '#expectedLanguage' to dao"(String expectedLanguage) {
240+
def "findAllAsLinkEntities() should pass language '#expectedLanguage' to dao"(String expectedLanguage) {
241241
when:
242242
service.findAllAsLinkEntities(expectedLanguage)
243243
then:

0 commit comments

Comments
 (0)