Skip to content

Commit 57be0b6

Browse files
committed
refactor(RawParsedDataDto): modify to support multiple image URLs
Part of #698
1 parent 066256d commit 57be0b6

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

src/main/java/ru/mystamps/web/feature/series/importing/RawParsedDataDto.java

+11-1
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@
2020
import lombok.Getter;
2121
import lombok.RequiredArgsConstructor;
2222

23+
import java.util.List;
24+
2325
@Getter
2426
@RequiredArgsConstructor
2527
public class RawParsedDataDto {
2628
private final String categoryName;
2729
private final String countryName;
28-
private final String imageUrl;
30+
private final List<String> imageUrls;
2931
private final String issueDate;
3032
private final String quantity;
3133
private final String perforated;
@@ -37,4 +39,12 @@ public class RawParsedDataDto {
3739
private final String altPrice;
3840
private final String altCurrency;
3941
private final String condition;
42+
43+
// for backward compatibility
44+
public String getImageUrl() {
45+
if (imageUrls == null || imageUrls.isEmpty()) {
46+
return null;
47+
}
48+
return imageUrls.get(0);
49+
}
4050
}

src/main/java/ru/mystamps/web/feature/series/importing/event/DownloadingSucceededEventListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void onApplicationEvent(DownloadingSucceeded event) {
8888
RawParsedDataDto data = new RawParsedDataDto(
8989
info.getCategoryName(),
9090
info.getCountryName(),
91-
info.getImageUrl(),
91+
info.getImageUrls(),
9292
info.getIssueDate(),
9393
info.getQuantity(),
9494
info.getPerforated(),

src/main/java/ru/mystamps/web/feature/series/importing/extractor/SeriesInfo.java

-8
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ public class SeriesInfo {
4646
private String altPrice;
4747
private String altCurrency;
4848
private String condition;
49-
50-
// for backward compatibility
51-
public String getImageUrl() {
52-
if (imageUrls == null || imageUrls.isEmpty()) {
53-
return null;
54-
}
55-
return imageUrls.get(0);
56-
}
5749

5850
/**
5951
* Check whether any info about a series is available.

src/test/java/ru/mystamps/web/service/TestObjects.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ public static RawParsedDataDto createRawParsedDataDto() {
280280
return new RawParsedDataDto(
281281
Random.categoryName(),
282282
Random.countryName(),
283-
Random.url(),
283+
Collections.singletonList(Random.url()),
284284
Random.issueYear().toString(),
285285
Random.quantity().toString(),
286286
String.valueOf(Random.perforated()),

0 commit comments

Comments
 (0)