Skip to content

Commit 56f8f80

Browse files
committed
ci: decomission of SpotBugs
The following issue won't be fixed: Closes #184 Closes #185 Closes #480 Closes #1190 Closes #1198 Closes #1258 Part of #1669
1 parent cb0d680 commit 56f8f80

File tree

4 files changed

+0
-350
lines changed

4 files changed

+0
-350
lines changed

.github/workflows/static-analysis.yml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -65,35 +65,3 @@ jobs:
6565
restore-keys: maven-repository-
6666
- name: Run maven-enforcer-plugin
6767
run: ./src/main/scripts/execute-command.sh enforcer
68-
69-
run-spotbugs:
70-
name: Run SpotBugs
71-
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
72-
runs-on: ubuntu-20.04
73-
steps:
74-
- name: Clone source code
75-
uses: actions/[email protected] # https://github.com/actions/checkout
76-
with:
77-
# Whether to configure the token or SSH key with the local git config. Default: true
78-
persist-credentials: false
79-
- name: Install JDK
80-
uses: actions/[email protected] # https://github.com/actions/setup-java
81-
with:
82-
distribution: 'adopt' # https://github.com/actions/setup-java#supported-distributions
83-
java-version: '8' # https://github.com/actions/setup-java#supported-version-syntax
84-
- name: Restore existing cache
85-
uses: actions/[email protected] # https://github.com/actions/cache
86-
with:
87-
# https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#input-parameters-for-the-cache-action
88-
key: maven-repository-${{ hashFiles('pom.xml') }}
89-
path: ~/.m2/repository
90-
restore-keys: maven-repository-
91-
- name: Compile sources
92-
run: >-
93-
mvn \
94-
--batch-mode \
95-
-Denforcer.skip=true \
96-
-DskipMinify \
97-
compile
98-
- name: Run SpotBugs
99-
run: ./src/main/scripts/execute-command.sh spotbugs

pom.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,6 @@
680680
<slf4j.version>1.7.36</slf4j.version>
681681

682682
<spock.version>1.0-groovy-2.0</spock.version>
683-
<spotbugs.plugin.version>3.1.11</spotbugs.plugin.version>
684683

685684
<!-- Redefine default value from spring-boot-dependencies in order to have the latest version -->
686685
<!-- LATER: remove overriding once version from Spring Boot will match the used one -->
@@ -747,20 +746,6 @@
747746

748747
<plugins>
749748

750-
<!--
751-
Usage:
752-
./mvnw spotbugs:check (checks the sources and produces report to the console)
753-
-->
754-
<plugin>
755-
<groupId>com.github.spotbugs</groupId>
756-
<artifactId>spotbugs-maven-plugin</artifactId>
757-
<version>${spotbugs.plugin.version}</version>
758-
<configuration>
759-
<includeTests>true</includeTests>
760-
<excludeFilterFile>src/main/config/spotbugs-filter.xml</excludeFilterFile>
761-
</configuration>
762-
</plugin>
763-
764749
<plugin>
765750
<groupId>com.mycila</groupId>
766751
<artifactId>license-maven-plugin</artifactId>

src/main/config/spotbugs-filter.xml

Lines changed: 0 additions & 297 deletions
This file was deleted.

src/main/scripts/execute-command.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ case ${1:-} in
4040
frontend:npm \
4141
-Dfrontend.npm.arguments='install-ci-test'
4242
;;
43-
'spotbugs')
44-
exec "$MVN" \
45-
--batch-mode \
46-
spotbugs:check
47-
;;
4843
'unit-tests')
4944
exec "$MVN" \
5045
--batch-mode \
@@ -63,7 +58,6 @@ case ${1:-} in
6358
echo >&2 '- enforcer'
6459
echo >&2 '- integration-tests'
6560
echo >&2 '- jest'
66-
echo >&2 '- spotbugs'
6761
echo >&2 '- unit-tests'
6862
exit 1
6963
;;

0 commit comments

Comments
 (0)