Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 4c32ef6

Browse files
committedJun 16, 2023
chore: processed c2adb2a style: modify TODO comments to workaround pdd behavior where it uses all lines as an issue title
1 parent 577d002 commit 4c32ef6

File tree

2 files changed

+48
-48
lines changed

2 files changed

+48
-48
lines changed
 

‎pdd.xml

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
<ticket>971</ticket>
1717
<estimate>0</estimate>
1818
<role>DEV</role>
19-
<id>971-32d95143</id>
20-
<lines>895-895</lines>
21-
<body>Document ErrorProne tool --&gt;</body>
19+
<id>971-7e983586</id>
20+
<lines>896-896</lines>
21+
<body>Document ErrorProne tool</body>
2222
<file>pom.xml</file>
2323
<author>@php-coder</author>
2424
<email>slava.semushin@gmail.com</email>
@@ -27,9 +27,9 @@
2727
<ticket>1170</ticket>
2828
<estimate>0</estimate>
2929
<role>DEV</role>
30-
<id>1170-4b91f3a7</id>
31-
<lines>897-898</lines>
32-
<body>ErrorProne: activate experimental checks --&gt;</body>
30+
<id>1170-64f18d35</id>
31+
<lines>900-900</lines>
32+
<body>ErrorProne: activate experimental checks</body>
3333
<file>pom.xml</file>
3434
<author>@php-coder</author>
3535
<email>slava.semushin@gmail.com</email>
@@ -38,9 +38,9 @@
3838
<ticket>1060</ticket>
3939
<estimate>0</estimate>
4040
<role>DEV</role>
41-
<id>1060-542e4feb</id>
42-
<lines>1323-1324</lines>
43-
<body>Document usage of frontend-maven-plugin --&gt;</body>
41+
<id>1060-e52eab60</id>
42+
<lines>1328-1328</lines>
43+
<body>Document usage of frontend-maven-plugin</body>
4444
<file>pom.xml</file>
4545
<author>@php-coder</author>
4646
<email>slava.semushin@gmail.com</email>
@@ -82,9 +82,9 @@
8282
<ticket>869</ticket>
8383
<estimate>0</estimate>
8484
<role>DEV</role>
85-
<id>869-982802a1</id>
86-
<lines>7-7</lines>
87-
<body>Find a better way to deal with SpotBugs warnings in DAO classes --&gt;</body>
85+
<id>869-7bf9fe59</id>
86+
<lines>8-8</lines>
87+
<body>Find a better way to deal with SpotBugs warnings in DAO classes</body>
8888
<file>src/main/config/spotbugs-filter.xml</file>
8989
<author>@php-coder</author>
9090
<email>slava.semushin@gmail.com</email>
@@ -93,9 +93,9 @@
9393
<ticket>493</ticket>
9494
<estimate>0</estimate>
9595
<role>DEV</role>
96-
<id>493-62b014f2</id>
97-
<lines>233-233</lines>
98-
<body>AddCategoryDbDto: port to a new datetime API --&gt;</body>
96+
<id>493-f666e113</id>
97+
<lines>236-236</lines>
98+
<body>AddCategoryDbDto: port to a new datetime API</body>
9999
<file>src/main/config/spotbugs-filter.xml</file>
100100
<author>@php-coder</author>
101101
<email>slava.semushin@gmail.com</email>
@@ -104,9 +104,9 @@
104104
<ticket>493</ticket>
105105
<estimate>0</estimate>
106106
<role>DEV</role>
107-
<id>493-278bfc9b</id>
108-
<lines>244-244</lines>
109-
<body>AddCountryDbDto: port to a new datetime API --&gt;</body>
107+
<id>493-bc96ed45</id>
108+
<lines>249-249</lines>
109+
<body>AddCountryDbDto: port to a new datetime API</body>
110110
<file>src/main/config/spotbugs-filter.xml</file>
111111
<author>@php-coder</author>
112112
<email>slava.semushin@gmail.com</email>
@@ -115,9 +115,9 @@
115115
<ticket>493</ticket>
116116
<estimate>0</estimate>
117117
<role>DEV</role>
118-
<id>493-632130de</id>
119-
<lines>255-255</lines>
120-
<body>AddCollectionDbDto: port to a new datetime API --&gt;</body>
118+
<id>493-42e1fc4c</id>
119+
<lines>262-262</lines>
120+
<body>AddCollectionDbDto: port to a new datetime API</body>
121121
<file>src/main/config/spotbugs-filter.xml</file>
122122
<author>Slava Semushin</author>
123123
<email>slava.semushin@gmail.com</email>
@@ -126,9 +126,9 @@
126126
<ticket>493</ticket>
127127
<estimate>0</estimate>
128128
<role>DEV</role>
129-
<id>493-ce63acfd</id>
130-
<lines>264-264</lines>
131-
<body>AddSuspiciousActivityDbDto: port to a new datetime API --&gt;</body>
129+
<id>493-6ad65c8d</id>
130+
<lines>273-273</lines>
131+
<body>AddSuspiciousActivityDbDto: port to a new datetime API</body>
132132
<file>src/main/config/spotbugs-filter.xml</file>
133133
<author>Slava Semushin</author>
134134
<email>slava.semushin@gmail.com</email>
@@ -137,9 +137,9 @@
137137
<ticket>493</ticket>
138138
<estimate>0</estimate>
139139
<role>DEV</role>
140-
<id>493-c468b8b5</id>
141-
<lines>269-269</lines>
142-
<body>SuspiciousActivityDto: port to a new datetime API --&gt;</body>
140+
<id>493-2b6007d4</id>
141+
<lines>280-280</lines>
142+
<body>SuspiciousActivityDto: port to a new datetime API</body>
143143
<file>src/main/config/spotbugs-filter.xml</file>
144144
<author>Slava Semushin</author>
145145
<email>slava.semushin@gmail.com</email>
@@ -390,9 +390,9 @@
390390
<ticket>1448</ticket>
391391
<estimate>0</estimate>
392392
<role>DEV</role>
393-
<id>1448-3d19f9e8</id>
394-
<lines>39-41</lines>
395-
<body>AddSimilarSeriesForm.similarSeriesId: remove deprecated member NOTE: similarSeriesId is deprecated and exist only for backward compatibility</body>
393+
<id>1448-65ca5ec2</id>
394+
<lines>39-39</lines>
395+
<body>AddSimilarSeriesForm.similarSeriesId: remove deprecated member</body>
396396
<file>src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java</file>
397397
<author>Slava Semushin</author>
398398
<email>slava.semushin@gmail.com</email>
@@ -1919,9 +1919,9 @@
19191919
<ticket>1057</ticket>
19201920
<estimate>0</estimate>
19211921
<role>DEV</role>
1922-
<id>1057-5419ab18</id>
1923-
<lines>31-32</lines>
1924-
<body>SeriesSaleImportForm: wait until setState() finishes (see https://reactjs.org/docs/react-component.html#setstate)</body>
1922+
<id>1057-ea0a43ea</id>
1923+
<lines>32-32</lines>
1924+
<body>SeriesSaleImportForm: wait until setState() finishes</body>
19251925
<file>src/main/frontend/src/components/SeriesSaleImportForm.js</file>
19261926
<author>Slava Semushin</author>
19271927
<email>slava.semushin@gmail.com</email>
@@ -2007,9 +2007,9 @@
20072007
<ticket>1054</ticket>
20082008
<estimate>0</estimate>
20092009
<role>DEV</role>
2010-
<id>1054-25fd6f7f</id>
2011-
<lines>41-45</lines>
2012-
<body>Extract list of exclusions to a common profile Full list of autoconfiguration classes: https://docs.spring.io/spring-boot/docs/2.2.x/reference/html/appendix-auto-configuration-classes.html The difference between test profile is that we don't need H2ConsoleAutoConfiguration</body>
2010+
<id>1054-1c349c8e</id>
2011+
<lines>44-44</lines>
2012+
<body>Extract list of exclusions to a common profile</body>
20132013
<file>src/main/resources/application-postgres.properties</file>
20142014
<author>Slava Semushin</author>
20152015
<email>slava.semushin@gmail.com</email>

‎todos-in-code.tsv

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ Id Ticket "Title" File Lines
22
109-a721e051 109 "Check src/main/config/nginx/503.*html by html5validator" src/main/scripts/execute-command.sh 63-63
33
226-af195ad8 226 "Introduce app.use-public-hostname property" src/main/java/ru/mystamps/web/support/spring/security/SecurityConfig.java 93-93
44
477-6f081e18 477 "Add to collection: integration test for invisible quantity for a series with 1 stamp" src/main/java/ru/mystamps/web/feature/collection/AddToCollectionForm.java 31-31
5-
493-278bfc9b 493 "AddCountryDbDto: port to a new datetime API -->" src/main/config/spotbugs-filter.xml 244-244
6-
493-62b014f2 493 "AddCategoryDbDto: port to a new datetime API -->" src/main/config/spotbugs-filter.xml 233-233
7-
493-632130de 493 "AddCollectionDbDto: port to a new datetime API -->" src/main/config/spotbugs-filter.xml 255-255
8-
493-c468b8b5 493 "SuspiciousActivityDto: port to a new datetime API -->" src/main/config/spotbugs-filter.xml 269-269
9-
493-ce63acfd 493 "AddSuspiciousActivityDbDto: port to a new datetime API -->" src/main/config/spotbugs-filter.xml 264-264
5+
493-2b6007d4 493 "SuspiciousActivityDto: port to a new datetime API" src/main/config/spotbugs-filter.xml 280-280
6+
493-42e1fc4c 493 "AddCollectionDbDto: port to a new datetime API" src/main/config/spotbugs-filter.xml 262-262
7+
493-6ad65c8d 493 "AddSuspiciousActivityDbDto: port to a new datetime API" src/main/config/spotbugs-filter.xml 273-273
8+
493-bc96ed45 493 "AddCountryDbDto: port to a new datetime API" src/main/config/spotbugs-filter.xml 249-249
9+
493-f666e113 493 "AddCategoryDbDto: port to a new datetime API" src/main/config/spotbugs-filter.xml 236-236
1010
511-f20a64c0 511 "/collection/{slug}: wrap a long caption" src/main/webapp/WEB-INF/views/collection/info.html 162-162
1111
517-385bf5f0 517 "CategoryService.suggestCategoryForUser(): suggest the most popular category" src/main/java/ru/mystamps/web/feature/category/CategoryServiceImpl.java 222-222
1212
517-49fc5900 517 "CategoryService.suggestCategoryForUser(): suggest a last created category" src/main/java/ru/mystamps/web/feature/category/CategoryServiceImpl.java 221-221
@@ -89,8 +89,8 @@ Id Ticket "Title" File Lines
8989
857-83098214 857 "TransactionParticipantServiceImpl.findGroupIdByName(): move to a separate service" src/main/java/ru/mystamps/web/feature/participant/ParticipantServiceImpl.java 98-98
9090
857-a6f9cdd0 857 "SeriesImportServiceImpl.saveParsedData(): add unit test for seller group" src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportServiceImpl.java 214-214
9191
857-aa59724c 857 "/series/import/request/{id}(seller.group): add validation for existing group" src/main/java/ru/mystamps/web/feature/series/importing/ImportSellerForm.java 37-37
92+
869-7bf9fe59 869 "Find a better way to deal with SpotBugs warnings in DAO classes" src/main/config/spotbugs-filter.xml 8-8
9293
869-90e5e0f1 869 "show-spring-boot-version-diff.sh: properly handle recursive properties" src/main/scripts/show-spring-boot-version-diff.sh 16-16
93-
869-982802a1 869 "Find a better way to deal with SpotBugs warnings in DAO classes -->" src/main/config/spotbugs-filter.xml 7-7
9494
884-03637f5c 884 "/collection/{slug}/estimation: optimize summing of prices" src/main/webapp/WEB-INF/views/collection/estimation.html 118-118
9595
892-9e92b338 892 "Add integration tests for showing a link to collection estimation page" src/main/webapp/WEB-INF/views/collection/info.html 101-101
9696
927-0bf380a9 927 "Move series package one level up" src/main/java/ru/mystamps/web/feature/series/package-info.java 1-1
@@ -103,7 +103,7 @@ Id Ticket "Title" File Lines
103103
927-d8dc99c9 927 "Move country package one level up" src/main/java/ru/mystamps/web/feature/country/package-info.java 1-1
104104
927-e31062c0 927 "Move account package one level up" src/main/java/ru/mystamps/web/feature/account/package-info.java 1-1
105105
927-e9697c74 927 "Move report package one level up" src/main/java/ru/mystamps/web/feature/report/package-info.java 1-1
106-
971-32d95143 971 "Document ErrorProne tool -->" pom.xml 895-895
106+
971-7e983586 971 "Document ErrorProne tool" pom.xml 896-896
107107
975-c9aec551 975 "SiteParserServiceImpl: add unit tests for constructor" src/main/java/ru/mystamps/web/feature/series/importing/extractor/JsoupSiteParser.java 64-64
108108
975-d6c13208 975 "SiteParserServiceImpl.findParserNames(): add unit tests" src/main/java/ru/mystamps/web/feature/series/importing/extractor/SiteParserServiceImpl.java 54-54
109109
975-e76660de 975 "SiteParserServiceImpl.findForUrl(): add unit tests" src/main/java/ru/mystamps/web/feature/series/importing/extractor/SiteParserServiceImpl.java 33-33
@@ -118,15 +118,15 @@ Id Ticket "Title" File Lines
118118
1000-7b4c3a87 1000 "CI: validate and check Terraform configuration" infra/terraform/my-stamps.tf 1-1
119119
1034-0016977f 1034 "Document how to run with PostgreSQL and docker-compose" infra/docker/postgres.yml 7-8
120120
1054-0d061f99 1054 "Introduce ""mailgun-mock"" profile" src/main/resources/application-postgres.properties 25-25
121-
1054-25fd6f7f 1054 "Extract list of exclusions to a common profile Full list of autoconfiguration classes: https://docs.spring.io/spring-boot/docs/2.2.x/reference/html/appendix-auto-configuration-classes.html The difference between test profile is that we don't need H2ConsoleAutoConfiguration" src/main/resources/application-postgres.properties 41-45
121+
1054-1c349c8e 1054 "Extract list of exclusions to a common profile" src/main/resources/application-postgres.properties 44-44
122122
1054-33066ab3 1054 "Introduce profiles for image persistence strategies" src/main/java/ru/mystamps/web/feature/image/ImageConfig.java 80-80
123123
1054-41eae704 1054 "Extract part of spring.messages configuration to a common profile" src/main/resources/application-postgres.properties 10-10
124124
1054-7817233c 1054 "Extract part of Thymeleaf configuration to a common profile" src/main/resources/application-postgres.properties 19-19
125125
1054-d4786412 1054 "Introduce profiles for liquibase contexts" src/main/resources/application-postgres.properties 29-29
126-
1057-5419ab18 1057 "SeriesSaleImportForm: wait until setState() finishes (see https://reactjs.org/docs/react-component.html#setstate)" src/main/frontend/src/components/SeriesSaleImportForm.js 31-32
127126
1057-ae51bd20 1057 "SeriesSaleImportForm: add tests" src/main/frontend/src/components/SeriesSaleImportForm.js 6-6
128127
1057-afe1bb59 1057 "Series sale import form: show a message when JavaScript is disabled" src/main/webapp/WEB-INF/views/series/info.html 858-858
129-
1060-542e4feb 1060 "Document usage of frontend-maven-plugin -->" pom.xml 1323-1324
128+
1057-ea0a43ea 1057 "SeriesSaleImportForm: wait until setState() finishes" src/main/frontend/src/components/SeriesSaleImportForm.js 32-32
129+
1060-e52eab60 1060 "Document usage of frontend-maven-plugin" pom.xml 1328-1328
130130
1098-de488059 1098 "Optimize a search within user's collection" src/main/java/ru/mystamps/web/feature/series/SeriesController.java 638-638
131131
1123-296bb340 1123 "CollectionService.findSeriesInstances(): add unit tests" src/main/java/ru/mystamps/web/feature/collection/CollectionServiceImpl.java 136-136
132132
1123-42494b3d 1123 "/collection/{slug}: show ""New"" badge only once" src/main/webapp/WEB-INF/views/collection/info.html 161-161
@@ -136,7 +136,7 @@ Id Ticket "Title" File Lines
136136
1160-545c948a 1160 "ContentSecurityPolicyHeaderWriter shouldn't depend from Togglz" src/main/java/ru/mystamps/web/support/spring/security/ContentSecurityPolicyHeaderWriter.java 160-160
137137
1161-69decc53 1161 "Add Feature-Policy header" src/main/java/ru/mystamps/web/support/spring/security/SecurityConfig.java 172-172
138138
1161-a2706b18 1161 "Consider using spring.task.execution properties instead of manual configuration" src/main/java/ru/mystamps/web/config/TaskExecutorConfig.java 31-31
139-
1170-4b91f3a7 1170 "ErrorProne: activate experimental checks -->" pom.xml 897-898
139+
1170-64f18d35 1170 "ErrorProne: activate experimental checks" pom.xml 900-900
140140
1230-8769330d 1230 "/series/import/request/{id}: validate that both alt price/currency are present or absent" src/main/java/ru/mystamps/web/feature/series/importing/ImportSeriesSalesForm.java 48-48
141141
1230-9685721f 1230 "SeriesImportServiceImpl.saveParsedData(): add unit test for alternative price and currency" src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportServiceImpl.java 229-230
142142
1254-f96635a2 1254 "Update workflow to mention RetryDownloading event" src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportController.java 105-105
@@ -196,7 +196,7 @@ Id Ticket "Title" File Lines
196196
1411-1e303594 1411 "Configure MethodValidationPostProcessor to use messages from ValidationMessages.properties" src/main/java/ru/mystamps/web/feature/series/SeriesService.java 35-35
197197
1421-f0722df3 1421 "/series/add: add integration test to check that Yvert numbers may contain letters" src/main/java/ru/mystamps/web/feature/series/AddSeriesForm.java 114-114
198198
1447-3c055652 1447 "Add test to ensure that catalog numbers are trimmed" src/main/java/ru/mystamps/web/support/spring/mvc/PatchRequest.java 52-52
199-
1448-3d19f9e8 1448 "AddSimilarSeriesForm.similarSeriesId: remove deprecated member NOTE: similarSeriesId is deprecated and exist only for backward compatibility" src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java 39-41
199+
1448-65ca5ec2 1448 "AddSimilarSeriesForm.similarSeriesId: remove deprecated member" src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java 39-39
200200
1448-d5a68b83 1448 "AddSimilarSeriesForm: add integration test that similarSeriesIds isn't empty" src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java 60-60
201201
1448-eb3f0fe6 1448 "SeriesServiceImpl.markAsSimilar(): mark multiple series at once in DAO" src/main/java/ru/mystamps/web/feature/series/SeriesServiceImpl.java 444-444
202202
1455-dfea25aa 1455 "Remove export of components to window" src/main/frontend/webpack.config.js 4-4

0 commit comments

Comments
 (0)
Please sign in to comment.