CatalogUtils.toShortForm(): use a constant for representing an empty string to reduce memory allocations.

php-coder · php-coder · commit 43dc133b0203 · 2018-07-06T12:54:11.000+02:00
No functional changes.
diff --git a/src/main/java/ru/mystamps/web/util/CatalogUtils.java b/src/main/java/ru/mystamps/web/util/CatalogUtils.java
@@ -63,7 +63,7 @@ public static String toShortForm(List<String> catalogNumbers) {
 		Validate.isTrue(catalogNumbers != null, "Catalog numbers must be non null");
 		
 		if (catalogNumbers.isEmpty()) {
-			return "";
+			return StringUtils.EMPTY;
 		}
 		
 		Set<String> numbers = new TreeSet<>(STR_AFTER_INT);

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public static String toShortForm(List<String> catalogNumbers) {`
`63`	`63`	`Validate.isTrue(catalogNumbers != null, "Catalog numbers must be non null");`
`64`	`64`
`65`	`65`	`if (catalogNumbers.isEmpty()) {`
`66`		`- return "";`
	`66`	`+ return StringUtils.EMPTY;`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`Set<String> numbers = new TreeSet<>(STR_AFTER_INT);`