Skip to content

Commit 43acf9a

Browse files
committed
refactor: extract a logic for formatting URLs
Part of #1605
1 parent c5f7e6e commit 43acf9a

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/main/java/ru/mystamps/web/feature/site/SitemapController.java

+9-3
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ public void generateSitemapXml(HttpServletResponse response) {
6767
writer.print(INDEX_URL_ENTRY);
6868

6969
for (SitemapInfoDto item : seriesService.findAllForSitemap()) {
70-
writer.print(createUrlEntry(dateFormatter, item));
70+
// CheckStyle: ignore LineLength for next 1 line
71+
writer.print(createUrlEntry(dateFormatter, item, SeriesUrl.INFO_SERIES_PAGE, "{id}"));
7172
}
7273

7374
writer.print("</urlset>\n");
@@ -76,9 +77,14 @@ public void generateSitemapXml(HttpServletResponse response) {
7677
}
7778
}
7879

79-
private static String createUrlEntry(DateFormat dateFormatter, SitemapInfoDto item) {
80+
private static String createUrlEntry(
81+
DateFormat dateFormatter,
82+
SitemapInfoDto item,
83+
String urlFormat,
84+
String urlPatternToReplace
85+
) {
8086
return new StringBuilder("<url><loc>")
81-
.append(SiteUrl.PUBLIC_URL).append(SeriesUrl.INFO_SERIES_PAGE.replace("{id}", item.getId()))
87+
.append(SiteUrl.PUBLIC_URL).append(urlFormat.replace(urlPatternToReplace, item.getId()))
8288
.append("</loc><lastmod>")
8389
.append(createLastModEntry(dateFormatter, item))
8490
.append("</lastmod></url>\n")

0 commit comments

Comments
 (0)