Skip to content

Commit 1a560d3

Browse files
committed
refactor: activate linting for unchecked operations and fix these warnings
Fix #1219
1 parent 4466d86 commit 1a560d3

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,9 +875,10 @@
875875
<showWarnings>true</showWarnings>
876876
<debug>false</debug>
877877
<failOnWarning>true</failOnWarning>
878-
<!-- Required for ErrorProne -->
879-
<!-- @todo #971 Document ErrorProne tool -->
880878
<compilerArgs>
879+
<compilerArg>-Xlint:unchecked</compilerArg>
880+
<!-- Required for ErrorProne -->
881+
<!-- @todo #971 Document ErrorProne tool -->
881882
<compilerArg>-XDcompilePolicy=simple</compilerArg>
882883
<!-- @todo #1170 ErrorProne: activate experimental checks -->
883884
<!--

src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportConfig.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ public SeriesImportController seriesImportController() {
6363
);
6464
}
6565

66+
// CheckStyle: ignore LineLength for next 2 lines
6667
@Bean
67-
public FilterRegistrationBean importSeriesFormTrimmerFilter() {
68-
FilterRegistrationBean bean =
68+
public FilterRegistrationBean<ImportSeriesFormTrimmerFilter> importSeriesFormTrimmerFilter() {
69+
FilterRegistrationBean<ImportSeriesFormTrimmerFilter> bean =
6970
new FilterRegistrationBean<>(new ImportSeriesFormTrimmerFilter());
7071

7172
String pattern = SeriesImportUrl.REQUEST_IMPORT_PAGE.replace("{id}", "*");

src/main/java/ru/mystamps/web/support/spring/security/SecurityConfig.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,11 @@ public Filter getOrderedRequestContextFilter() {
201201

202202
// Bean name will be shown in logs
203203
@Bean(name = "resetLocaleFilter")
204-
public FilterRegistrationBean getResetLocaleFilter(
204+
public FilterRegistrationBean<SessionLocaleResolverAwareFilter> getResetLocaleFilter(
205205
@Qualifier("requestContextFilter") Filter filter) {
206206

207-
FilterRegistrationBean bean = new FilterRegistrationBean(
208-
new SessionLocaleResolverAwareFilter()
209-
);
207+
FilterRegistrationBean<SessionLocaleResolverAwareFilter> bean =
208+
new FilterRegistrationBean<>(new SessionLocaleResolverAwareFilter());
210209

211210
// SessionLocaleResolverAwareFilter should be invoked after RequestContextFilter
212211
// to overwrite locale in LocaleContextHolder
@@ -220,8 +219,9 @@ public FilterRegistrationBean getResetLocaleFilter(
220219
}
221220

222221
@Bean
223-
public FilterRegistrationBean userMdcLoggingFilter() {
224-
FilterRegistrationBean bean = new FilterRegistrationBean(new UserMdcLoggingFilter());
222+
public FilterRegistrationBean<UserMdcLoggingFilter> userMdcLoggingFilter() {
223+
FilterRegistrationBean<UserMdcLoggingFilter> bean =
224+
new FilterRegistrationBean<>(new UserMdcLoggingFilter());
225225
// the filters that need to include userId in their logs, should have the order grater than
226226
// Ordered.LOWEST_PRECEDENCE - 100 to get applied after us
227227
// CheckStyle: ignore MagicNumber for next 1 line

src/main/java/ru/mystamps/web/support/togglz/TogglzConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ public FeatureManager getFeatureManager() {
6464
* @see https://www.togglz.org/documentation/admin-console.html
6565
*/
6666
@Bean
67-
public ServletRegistrationBean getTogglzConsole() {
68-
ServletRegistrationBean servlet = new ServletRegistrationBean();
67+
public ServletRegistrationBean<TogglzConsoleServlet> getTogglzConsole() {
68+
ServletRegistrationBean<TogglzConsoleServlet> servlet = new ServletRegistrationBean<>();
6969
servlet.setName("TogglzConsole");
7070
servlet.setServlet(new TogglzConsoleServlet());
7171
// See also src/main/java/ru/mystamps/web/support/spring/security/SecurityConfig.java

0 commit comments

Comments
 (0)