Skip to content

Commit 128920c

Browse files
committed
Revert "WebDriverFactory: properly fix warning from CheckStyle."
This reverts commit e4467d2. The fix wasn't good enough and causes PMD to complain after enabling inspecting tests. Also looks like CheckStyle doesn't complain about it now. No functional changes.
1 parent c1e2495 commit 128920c

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/main/config/checkstyle-suppressions.xml

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
<!-- false positives due to Lombok usage -->
99
<suppress checks="HideUtilityClassConstructor" files="ru.mystamps.web.controller.dto" />
1010

11-
<!-- I don't want to rename WebDriverFactory to AbstractWebDriverFactory -->
12-
<suppress checks="AbstractClassName" files="ru.mystamps.web.tests.WebDriverFactory" />
13-
1411
<!-- These files will be removed during porting integration tests to Cucumber JVM (see #18) -->
1512
<suppress checks="ImportOrder" files="src/test/java/ru/mystamps/web/tests" />
1613

src/test/java/ru/mystamps/web/tests/WebDriverFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.openqa.selenium.WebDriver;
2222
import org.openqa.selenium.htmlunit.HtmlUnitDriver;
2323

24-
public abstract class WebDriverFactory {
24+
public final class WebDriverFactory {
2525

2626
private static WebDriver driver;
2727

0 commit comments

Comments
 (0)