fix(series import): don't show a field with alternative price when it's empty.

Fix #1279

Author: php-coder

src/main/resources/liquibase/test-data/series_import_parsed_data.xml

@@ -34,4 +34,14 @@
 
 	</changeSet>
 
+	<changeSet id="add-series-parsed-data-for-gh1279" author="php-coder" context="test-data">
+		
+		<insert tableName="series_import_parsed_data">
+			<column name="request_id" valueComputed="(SELECT id FROM series_import_requests WHERE url = 'http://example.com/issue/1279')" />
+			<column name="created_at" valueComputed="${NOW}" />
+			<column name="updated_at" valueComputed="${NOW}" />
+		</insert>
+		
+	</changeSet>
+	
 </databaseChangeLog>

src/main/resources/liquibase/test-data/series_import_requests.xml

@@ -49,4 +49,16 @@
 
 	</changeSet>
 
+	<changeSet id="add-import-request-for-gh1279" author="php-coder" context="test-data">
+		
+		<insert tableName="series_import_requests">
+			<column name="url" value="http://example.com/issue/1279" />
+			<column name="status_id" valueComputed="(SELECT id FROM series_import_request_statuses WHERE name = 'ParsingSucceeded')" />
+			<column name="requested_at" valueComputed="${NOW}" />
+			<column name="requested_by" valueComputed="(SELECT id FROM users WHERE role = 'ADMIN' ORDER by id LIMIT 1)" />
+			<column name="updated_at" valueComputed="${NOW}" />
+		</insert>
+		
+	</changeSet>
+	
 </databaseChangeLog>

src/main/resources/liquibase/test-data/series_sales_import_parsed_data.xml

@@ -38,4 +38,16 @@
 
 	</changeSet>
 
+	<changeSet id="add-series-sale-with-price-and-currency-only" author="php-coder" context="test-data">
+		
+		<insert tableName="series_sales_import_parsed_data">
+			<column name="request_id" valueComputed="(SELECT id FROM series_import_requests WHERE url = 'http://example.com/issue/1279')" />
+			<column name="price" valueNumeric="100" />
+			<column name="currency" value="RUB" />
+			<column name="created_at" valueComputed="${NOW}" />
+			<column name="updated_at" valueComputed="${NOW}" />
+		</insert>
+		
+	</changeSet>
+	
 </databaseChangeLog>

src/main/webapp/WEB-INF/views/series/import/info.html

@@ -495,7 +495,7 @@ <h3 th:text="#{t_gathered_data}">
 									</td>
 								</tr>
 
-								<tr th:if="${hasSalesInfo and (importSeriesForm.seriesSale.altPrice != null or !disabled)}"
+								<tr th:if="${hasSalesInfo and importSeriesForm.seriesSale.altPrice != null}"
 									th:classappend="${#fields.hasErrors('seriesSale.altPrice') or #fields.hasErrors('seriesSale.altCurrency') ? 'has-error' : ''}">
 									<th>
 										<label for="alt-price" class="control-label" th:text="#{t_alternative_price}">

src/test/robotframework/series/import/import-misc.robot

@@ -21,6 +21,14 @@ Seller info should be invisible where seller id has been extracted
 	Element Should Not Be Visible  id:seller-name
 	Element Should Not Be Visible  id:seller-url
 
+Alternative price and currency should be invisible when they are empty
+	Go To                          ${SITE_URL}/series/import/request/5
+	Element Text Should Be         id:request-url  http://example.com/issue/1279
+	Textfield Value Should Be      id:price        100
+	List Selection Should Be       id:currency     RUB
+	Element Should Not Be Visible  id:alt-price
+	Element Should Not Be Visible  id:alt-currency
+
 *** Keywords ***
 Before Test Suite
 	Open Browser                        ${SITE_URL}/account/auth  ${BROWSER}