fix: remove deprecated use of S3 ACLs (#3222)

alexjurkiewicz · web-flow · commit bf4cea84e9c3 · 2023-04-28T12:49:06.000+02:00
* fix: Remove deprecated use of S3 ACLs ACLs were disabled by default in April 2023: https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/ As we don't use ACLs, it's simplest to configure the bucket to not use them, which is the new recommended approach. Fixes #3202. * terraform fmt
diff --git a/modules/runner-binaries-syncer/main.tf b/modules/runner-binaries-syncer/main.tf
@@ -8,9 +8,11 @@ resource "aws_s3_bucket" "action_dist" {
   tags          = var.tags
 }
 
-resource "aws_s3_bucket_acl" "action_dist_acl" {
+resource "aws_s3_bucket_ownership_controls" "this" {
   bucket = aws_s3_bucket.action_dist.id
-  acl    = "private"
+  rule {
+    object_ownership = "BucketOwnerEnforced"
+  }
 }
 
 resource "aws_s3_bucket_lifecycle_configuration" "bucket-config" {

Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,11 @@ resource "aws_s3_bucket" "action_dist" {`
`8`	`8`	`tags = var.tags`
`9`	`9`	`}`
`10`	`10`
`11`		`-resource "aws_s3_bucket_acl" "action_dist_acl" {`
	`11`	`+resource "aws_s3_bucket_ownership_controls" "this" {`
`12`	`12`	`bucket = aws_s3_bucket.action_dist.id`
`13`		`- acl = "private"`
	`13`	`+ rule {`
	`14`	`+ object_ownership = "BucketOwnerEnforced"`
	`15`	`+ }`
`14`	`16`	`}`
`15`	`17`
`16`	`18`	`resource "aws_s3_bucket_lifecycle_configuration" "bucket-config" {`