Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit be03b10

Browse files
authored
Merge pull request #2668 from philips-labs/develop
chore: Release
2 parents 0b0916d + 66624ce commit be03b10

File tree

8 files changed

+1848
-1723
lines changed

8 files changed

+1848
-1723
lines changed

Diff for: README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ For time zones please check [TZ database name column](https://en.wikipedia.org/w
299299

300300
### Ephemeral runners
301301

302-
Currently a beta feature! You can configure runners to be ephemeral, runners will be used only for one job. The feature should be used in conjunction with listening for the workflow job event. Please consider the following:
302+
You can configure runners to be ephemeral, runners will be used only for one job. The feature should be used in conjunction with listening for the workflow job event. Please consider the following:
303303

304304
- The scale down lambda is still active, and should only remove orphan instances. But there is no strict check in place. So ensure you configure the `minimum_running_time_in_minutes` to a value that is high enough to got your runner booted and connected to avoid it got terminated before executing a job.
305305
- The messages sent from the webhook lambda to scale-up lambda are by default delayed delayed by SQS, to give available runners to option to start the job before the decision is made to scale more runners. For ephemeral runners there is no need to wait. Set `delay_webhook_event` to `0`.

Diff for: main.tf

+3-3
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ resource "aws_sqs_queue_policy" "build_queue_dlq_policy" {
101101

102102
resource "aws_sqs_queue" "queued_builds_dlq" {
103103
count = var.redrive_build_queue.enabled ? 1 : 0
104-
name = "${var.prefix}-queued-builds_dead_letter"
104+
name = "${var.prefix}-queued-builds_dead_letter${var.fifo_build_queue ? ".fifo" : ""}"
105105

106106
sqs_managed_sse_enabled = var.queue_encryption.sqs_managed_sse_enabled
107107
kms_master_key_id = var.queue_encryption.kms_master_key_id
108108
kms_data_key_reuse_period_seconds = var.queue_encryption.kms_data_key_reuse_period_seconds
109-
110-
tags = var.tags
109+
fifo_queue = var.fifo_build_queue
110+
tags = var.tags
111111
}
112112

113113
module "ssm" {

Diff for: modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
"devDependencies": {
1818
"@octokit/rest": "^19.0.5",
1919
"@trivago/prettier-plugin-sort-imports": "^3.4.0",
20-
"@types/jest": "^29.2.2",
20+
"@types/jest": "^29.2.3",
2121
"@types/node": "^18.11.9",
2222
"@types/request": "^2.48.8",
2323
"@typescript-eslint/eslint-plugin": "^4.33.0",
2424
"@typescript-eslint/parser": "^4.33.0",
2525
"@vercel/ncc": "^0.34.0",
26-
"aws-sdk": "^2.1250.0",
26+
"aws-sdk": "^2.1256.0",
2727
"eslint": "^7.32.0",
2828
"eslint-plugin-prettier": "4.2.1",
2929
"jest": "^29.3",
30-
"jest-mock": "^29.3.0",
30+
"jest-mock": "^29.3.1",
3131
"prettier": "2.7.1",
3232
"ts-jest": "^29.0.3",
3333
"ts-node-dev": "^2.0.0",

0 commit comments

Comments
 (0)