Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit 96def9a

Browse files
authored
feat: Add SQS queue resource policy to improve security (#1798)
* feat: added sqs queue resource policy to improve security * added policy to deny all actions on queue with unsecured transport method * chore: formatted main.tf
1 parent 8f9c342 commit 96def9a

File tree

1 file changed

+38
-0
lines changed

1 file changed

+38
-0
lines changed

Diff for: main.tf

+38
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,38 @@ resource "random_string" "random" {
1717
upper = false
1818
}
1919

20+
data "aws_iam_policy_document" "deny_unsecure_transport" {
21+
statement {
22+
sid = "DenyUnsecureTransport"
23+
24+
effect = "Deny"
25+
26+
principals {
27+
type = "AWS"
28+
identifiers = ["*"]
29+
}
30+
31+
actions = [
32+
"sqs:*"
33+
]
34+
35+
resources = [
36+
"*"
37+
]
38+
39+
condition {
40+
test = "Bool"
41+
variable = "aws:SecureTransport"
42+
values = ["false"]
43+
}
44+
}
45+
}
46+
47+
resource "aws_sqs_queue_policy" "build_queue_policy" {
48+
queue_url = aws_sqs_queue.queued_builds.id
49+
policy = data.aws_iam_policy_document.deny_unsecure_transport.json
50+
}
51+
2052
resource "aws_sqs_queue" "queued_builds" {
2153
name = "${var.environment}-queued-builds${var.fifo_build_queue ? ".fifo" : ""}"
2254
delay_seconds = var.delay_webhook_event
@@ -33,6 +65,12 @@ resource "aws_sqs_queue" "queued_builds" {
3365
tags = var.tags
3466
}
3567

68+
69+
resource "aws_sqs_queue_policy" "build_queue_dlq_policy" {
70+
queue_url = aws_sqs_queue.queued_builds.id
71+
policy = data.aws_iam_policy_document.deny_unsecure_transport.json
72+
}
73+
3674
resource "aws_sqs_queue" "queued_builds_dlq" {
3775
count = var.redrive_build_queue.enabled ? 1 : 0
3876
name = "${var.environment}-queued-builds_dead_letter"

0 commit comments

Comments
 (0)