Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit 7095487

Browse files
authored
fix: Add missing SG and subnet configuration for Job Retry lambda (#4114)
While the Security group IDs and Subnet IDs can be configured in the Job-retry lambda, the `config` variable did not accept it. I rectify the type definition in the variable. Additionally, I also updated the description of the variable for accuracy.
1 parent e704a6d commit 7095487

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: modules/runners/job-retry/variables.tf

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ variable "config" {
55
`aws_partition`: Partition for the base arn if not 'aws'
66
`architecture`: AWS Lambda architecture. Lambda functions using Graviton processors ('arm64') tend to have better price/performance than 'x86_64' functions.
77
`environment_variables`: Environment variables for the lambda.
8+
`enable_organization_runners`: Enable organization runners.
89
`enable_metric`: Enable metric for the lambda. If `spot_warning` is set to true, the lambda will emit a metric when it detects a spot termination warning.
910
'ghes_url': Optional GitHub Enterprise Server URL.
1011
'github_app_parameters': Parameter Store for GitHub App Parameters.
@@ -15,7 +16,7 @@ variable "config" {
1516
`logging_kms_key_id`: Specifies the kms key id to encrypt the logs with
1617
`logging_retention_in_days`: Specifies the number of days you want to retain log events for the lambda log group. Possible values are: 0, 1, 3, 5, 7, 14, 30, 60, 90, 120, 150, 180, 365, 400, 545, 731, 1827, and 3653.
1718
`memory_size`: Memory size linit in MB of the lambda.
18-
`metrics_config`: Configuraiton to enable metrics creation by the lambda.
19+
`metrics`: Configuration to enable metrics creation by the lambda.
1920
`prefix`: The prefix used for naming resources.
2021
`role_path`: The path that will be added to the role, if not set the environment name will be used.
2122
`role_permissions_boundary`: Permissions boundary that will be added to the created role for the lambda.
@@ -69,6 +70,8 @@ variable "config" {
6970
role_path = optional(string, null)
7071
role_permissions_boundary = optional(string, null)
7172
runtime = optional(string, null)
73+
security_group_ids = optional(list(string), [])
74+
subnet_ids = optional(list(string), [])
7275
s3_bucket = optional(string, null)
7376
s3_key = optional(string, null)
7477
s3_object_version = optional(string, null)

0 commit comments

Comments
 (0)