Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit 56c1ece

Browse files
authored
fix(webhook): depcrated warning on ts-jest mocked (#1615)
- order typsscript import - add prettier plugin to automatically format plugin order - replaces importing mocked from ts-jest/utils by jest-mock
1 parent f2ff2e6 commit 56c1ece

File tree

11 files changed

+188
-94
lines changed

11 files changed

+188
-94
lines changed

Diff for: modules/webhook/lambdas/webhook/.prettierrc

+7-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,10 @@
33
"singleQuote": true,
44
"trailingComma": "all",
55
"semi": true,
6-
}
6+
"importOrderSeparation": true,
7+
"importOrderSortSpecifiers": true,
8+
"importOrder": [
9+
"<THIRD_PARTY_MODULES>",
10+
"^[./]"
11+
]
12+
}

Diff for: modules/webhook/lambdas/webhook/package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
},
1818
"devDependencies": {
1919
"@octokit/webhooks-definitions": "^3.67.3",
20+
"@trivago/prettier-plugin-sort-imports": "^3.1.1",
2021
"@types/aws-lambda": "^8.10.89",
2122
"@types/express": "^4.17.11",
2223
"@types/jest": "^27.4.0",
@@ -30,6 +31,7 @@
3031
"eslint-plugin-prettier": "4.0.0",
3132
"express": "^4.17.2",
3233
"jest": "^27.4.7",
34+
"jest-mock": "^27.4.6",
3335
"nock": "^13.2.1",
3436
"prettier": "2.5.1",
3537
"ts-jest": "^27.1.2",
@@ -43,4 +45,4 @@
4345
"aws-lambda": "^1.0.7",
4446
"tslog": "^3.3.1"
4547
}
46-
}
48+
}

Diff for: modules/webhook/lambdas/webhook/src/lambda.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { APIGatewayEvent, Context } from 'aws-lambda';
22
import { mocked } from 'ts-jest/utils';
3+
34
import { githubWebhook } from './lambda';
45
import { handle } from './webhook/handler';
56
import { logger } from './webhook/logger';

Diff for: modules/webhook/lambdas/webhook/src/lambda.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
import { APIGatewayEvent, Callback, Context } from 'aws-lambda';
2+
13
import { handle } from './webhook/handler';
2-
import { APIGatewayEvent, Context, Callback } from 'aws-lambda';
34
import { logger } from './webhook/logger';
45

56
export interface Response {

Diff for: modules/webhook/lambdas/webhook/src/local.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import express from 'express';
21
import bodyParser from 'body-parser';
2+
import express from 'express';
3+
34
import { handle } from './webhook/handler';
45

56
const app = express();

Diff for: modules/webhook/lambdas/webhook/src/sqs/index.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { SQS } from 'aws-sdk';
2-
import { sendActionRequest, ActionRequestMessage } from '.';
2+
3+
import { ActionRequestMessage, sendActionRequest } from '.';
34

45
const mockSQS = {
56
sendMessage: jest.fn(() => {

Diff for: modules/webhook/lambdas/webhook/src/sqs/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { SQS } from 'aws-sdk';
2-
import { LogFields, logger as logger } from '../webhook/logger';
2+
3+
import { LogFields, logger } from '../webhook/logger';
34

45
export interface ActionRequestMessage {
56
id: number;

Diff for: modules/webhook/lambdas/webhook/src/ssm/index.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
import { GetParameterCommandOutput, SSM } from '@aws-sdk/client-ssm';
12
import nock from 'nock';
3+
24
import { getParameterValue } from '.';
3-
import { SSM, GetParameterCommandOutput } from '@aws-sdk/client-ssm';
45

56
jest.mock('@aws-sdk/client-ssm');
67

Diff for: modules/webhook/lambdas/webhook/src/webhook/handler.test.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
import { handle } from './handler';
2-
import { mocked } from 'ts-jest/utils';
31
import { Webhooks } from '@octokit/webhooks';
4-
import { getParameterValue } from '../ssm';
5-
import { sendActionRequest } from '../sqs';
6-
import workflowjob_event from '../../test/resources/github_workflowjob_event.json';
7-
import checkrun_event from '../../test/resources/github_check_run_event.json';
2+
import { mocked } from 'jest-mock';
83
import nock from 'nock';
94

5+
import checkrun_event from '../../test/resources/github_check_run_event.json';
6+
import workflowjob_event from '../../test/resources/github_workflowjob_event.json';
7+
import { sendActionRequest } from '../sqs';
8+
import { getParameterValue } from '../ssm';
9+
import { handle } from './handler';
10+
1011
jest.mock('../sqs');
1112
jest.mock('../ssm');
1213

Diff for: modules/webhook/lambdas/webhook/src/webhook/handler.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
import { IncomingHttpHeaders } from 'http';
21
import { Webhooks } from '@octokit/webhooks';
3-
import { sendActionRequest } from '../sqs';
42
import { CheckRunEvent, WorkflowJobEvent } from '@octokit/webhooks-types';
5-
import { getParameterValue } from '../ssm';
6-
import { logger as rootLogger, LogFields } from './logger';
3+
import { IncomingHttpHeaders } from 'http';
4+
75
import { Response } from '../lambda';
6+
import { sendActionRequest } from '../sqs';
7+
import { getParameterValue } from '../ssm';
8+
import { LogFields, logger as rootLogger } from './logger';
89

910
const supportedEvents = ['check_run', 'workflow_job'];
1011
const logger = rootLogger.getChildLogger();

0 commit comments

Comments
 (0)