Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit 3fa5896

Browse files
authored
feat: Support t4g Graviton instance type (#1561)
1 parent 2c66eea commit 3fa5896

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Diff for: README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ To be able to support a number of use-cases the module has quite a lot configura
9191

9292
#### ARM64 support via Graviton/Graviton2 instance-types
9393

94-
When using the default example or top-level module, specifying an `instance_type` that matches a Graviton/Graviton 2 (ARM64) architecture (e.g. a1 or any 6th-gen `g` or `gd` type), the sub-modules will be automatically configured to provision with ARM64 AMIs and leverage GitHub's ARM64 action runner. See below for more details.
94+
When using the default example or top-level module, specifying an `instance_type` that matches a Graviton/Graviton 2 (ARM64) architecture (e.g. a1, t4g or any 6th-gen `g` or `gd` type), the sub-modules will be automatically configured to provision with ARM64 AMIs and leverage GitHub's ARM64 action runner. See below for more details.
9595

9696
## Usages
9797

@@ -202,7 +202,7 @@ module "github-runner" {
202202
}
203203
```
204204

205-
**ARM64** support: Specify an `a1` or `*6g*` (6th-gen Graviton2) instance type to stand up an ARM64 runner, otherwise the default is x86_64.
205+
**ARM64** support: Specify an `a1`, `t4g` or `*6g*` (6th-gen Graviton2) instance type to stand up an ARM64 runner, otherwise the default is x86_64.
206206

207207
Run terraform by using the following commands
208208

@@ -347,7 +347,7 @@ The following sub modules are optional and are provided as example or utility:
347347

348348
### ARM64 configuration for submodules
349349

350-
When not using the top-level module and specifying an `a1` or `*6g*` (6th-gen Graviton2) `instance_type`, the `runner-binaries-syncer` and `runners` submodules need to be configured appropriately for pulling the ARM64 GitHub action runner binary and leveraging the arm64 AMI for the runners.
350+
When not using the top-level module and specifying an `a1`, `t4g` or `*6g*` (6th-gen Graviton2) `instance_type`, the `runner-binaries-syncer` and `runners` submodules need to be configured appropriately for pulling the ARM64 GitHub action runner binary and leveraging the arm64 AMI for the runners.
351351

352352
When configuring `runner-binaries-syncer`
353353

Diff for: main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ locals {
55
})
66

77
s3_action_runner_url = "s3://${module.runner_binaries.bucket.id}/${module.runner_binaries.runner_distribution_object_key}"
8-
runner_architecture = substr(var.instance_type, 0, 2) == "a1" || substr(var.instance_type, 1, 2) == "6g" ? "arm64" : "x64"
8+
runner_architecture = substr(var.instance_type, 0, 2) == "a1" || substr(var.instance_type, 0, 3) == "t4g" || substr(var.instance_type, 1, 2) == "6g" ? "arm64" : "x64"
99
github_app_parameters = {
1010
id = module.ssm.parameters.github_app_id
1111
key_base64 = module.ssm.parameters.github_app_key_base64

0 commit comments

Comments
 (0)