Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Commit 272a293

Browse files
committed
feat: Remove support check_run (#2521)
* chore: Remove support check_run * format, lint
1 parent 4844ea6 commit 272a293

File tree

8 files changed

+173
-133
lines changed

8 files changed

+173
-133
lines changed

Diff for: README.md

+5-6
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,14 @@ A logical question would be, why not Kubernetes? In the current approach, we sta
4747

4848
## Overview
4949

50-
The moment a GitHub action workflow requiring a `self-hosted` runner is triggered, GitHub will try to find a runner which can execute the workload. This module reacts to GitHub's [`check_run` event](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#check_run) or [`workflow_job` event](https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#workflow_job) for the triggered workflow and creates a new runner if necessary.
50+
The moment a GitHub action workflow requiring a `self-hosted` runner is triggered, GitHub will try to find a runner which can execute the workload. This module reacts to GitHub's [`workflow_job` event](https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#workflow_job) for the triggered workflow and creates a new runner if necessary.
5151

52-
For receiving the `check_run` or `workflow_job` event by the webhook (lambda), a webhook needs to be created in GitHub. The `workflow_job` is the preferred option, and the `check_run` option will be maintained for backward compatibility. The advantage of the `workflow_job` event is that the runner checks if the received event can run on the configured runners by matching the labels, which avoid instances being scaled up and never used. The following options are available:
52+
For receiving the `workflow_job` event by the webhook (lambda), a webhook needs to be created in GitHub. The `check_run` option is dropped from version 2.x. The following options to sent the event are supported.
5353

54-
- `workflow_job`: **(preferred option)** create a webhook on enterprise, org or app level. Select this option for ephemeral runners.
55-
- `check_run`: create a webhook on enterprise, org, repo or app level. When using the app option, the app needs to be installed to repo's are using the self-hosted runners.
56-
- a Webhook needs to be created. The webhook hook can be defined on enterprise, org, repo, or app level.
54+
- Create a GitHup app, define a webhook and subscribe the app to the `workflow_job` event.
55+
- Create a webhook on enterprise, org or repo level, define a webhook and subscribe the app to the `workflow_job` event.
5756

58-
In AWS a [API gateway](https://docs.aws.amazon.com/apigateway/index.html) endpoint is created that is able to receive the GitHub webhook events via HTTP post. The gateway triggers the webhook lambda which will verify the signature of the event. This check guarantees the event is sent by the GitHub App. The lambda only handles `workflow_job` or `check_run` events with status `queued` and matching the runner labels (only for `workflow_job`). The accepted events are posted on a SQS queue. Messages on this queue will be delayed for a configurable amount of seconds (default 30 seconds) to give the available runners time to pick up this build.
57+
In AWS a [API gateway](https://docs.aws.amazon.com/apigateway/index.html) endpoint is created that is able to receive the GitHub webhook events via HTTP post. The gateway triggers the webhook lambda which will verify the signature of the event. This check guarantees the event is sent by the GitHub App. The lambda only handles `workflow_job` events with status `queued` and matching the runner labels. The accepted events are posted on a SQS queue. Messages on this queue will be delayed for a configurable amount of seconds (default 30 seconds) to give the available runners time to pick up this build.
5958

6059
The "scale up runner" lambda listens to the SQS queue and picks up events. The lambda runs various checks to decide whether a new EC2 spot instance needs to be created. For example, the instance is not created if the build is already started by an existing runner, or the maximum number of runners is reached.
6160

Diff for: modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/yarn.lock

+114-16
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.19.4.tgz#95c86de137bf0317f3a570e1b6e996b427299747"
4949
integrity sha512-CHIGpJcUQ5lU9KrPHTjBMhVwQG6CQjxfg36fGXl3qk/Gik1WwWachaXFuo0uCWJT/mStOKtcbFJCaVLihC1CMw==
5050

51-
51+
"@babel/[email protected]", "@babel/core@^7.12.3":
5252
version "7.17.8"
5353
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.17.8.tgz#3dac27c190ebc3a4381110d46c80e77efe172e1a"
5454
integrity sha512-OdQDV/7cRBtJHLSOBqqbYNkOcydOgnX59TZx4puf41fzcVtN3e/4yqY8lMQsK+5X2lJtAdmA+6OHqsj1hBJ4IQ==
@@ -69,7 +69,7 @@
6969
json5 "^2.1.2"
7070
semver "^6.3.0"
7171

72-
"@babel/core@^7.11.6", "@babel/core@^7.12.3":
72+
"@babel/core@^7.11.6":
7373
version "7.19.3"
7474
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.19.3.tgz#2519f62a51458f43b682d61583c3810e7dcee64c"
7575
integrity sha512-WneDJxdsjEvyKtXKsaBGbDeiyOjR5vYq4HcShxnIbG0qixpoHjI3MqeZM9NDvsojNCEBItQE4juOo/bU6e72gQ==
@@ -108,6 +108,15 @@
108108
"@jridgewell/gen-mapping" "^0.3.2"
109109
jsesc "^2.5.1"
110110

111+
"@babel/generator@^7.19.3", "@babel/generator@^7.19.4":
112+
version "7.19.5"
113+
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.19.5.tgz#da3f4b301c8086717eee9cab14da91b1fa5dcca7"
114+
integrity sha512-DxbNz9Lz4aMZ99qPpO1raTbcrI1ZeYh+9NR9qhfkQIbFtVEqotHojEBxHzmxhVONkGt6VyrqVQcgpefMy9pqcg==
115+
dependencies:
116+
"@babel/types" "^7.19.4"
117+
"@jridgewell/gen-mapping" "^0.3.2"
118+
jsesc "^2.5.1"
119+
111120
"@babel/helper-compilation-targets@^7.17.7":
112121
version "7.18.9"
113122
resolved "https://registry.yarnpkg.com/@babel/helper-compilation-targets/-/helper-compilation-targets-7.18.9.tgz#69e64f57b524cde3e5ff6cc5a9f4a387ee5563bf"
@@ -157,6 +166,14 @@
157166
"@babel/template" "^7.18.10"
158167
"@babel/types" "^7.19.0"
159168

169+
"@babel/helper-function-name@^7.19.0":
170+
version "7.19.0"
171+
resolved "https://registry.yarnpkg.com/@babel/helper-function-name/-/helper-function-name-7.19.0.tgz#941574ed5390682e872e52d3f38ce9d1bef4648c"
172+
integrity sha512-WAwHBINyrpqywkUH0nTnNgI5ina5TFn85HKS0pbPDfxFfhyR/aNQEn4hGi1P1JyT//I0t4OgXUlofzWILRvS5w==
173+
dependencies:
174+
"@babel/template" "^7.18.10"
175+
"@babel/types" "^7.19.0"
176+
160177
"@babel/helper-get-function-arity@^7.16.7":
161178
version "7.16.7"
162179
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.16.7.tgz#ea08ac753117a669f1508ba06ebcc49156387419"
@@ -324,7 +341,7 @@
324341
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.18.9.tgz#f2dde0c682ccc264a9a8595efd030a5cc8fd2539"
325342
integrity sha512-9uJveS9eY9DJ0t64YbIBZICtJy8a5QrDEVdiLCG97fVLpDTpGX7t8mMSb6OWw6Lrnjqj4O8zwjELX3dhoMgiBg==
326343

327-
"@babel/parser@^7.1.0", "@babel/parser@^7.14.7", "@babel/parser@^7.16.0", "@babel/parser@^7.16.7", "@babel/parser@^7.17.3", "@babel/parser@^7.17.8", "@babel/parser@^7.18.10", "@babel/parser@^7.18.6", "@babel/parser@^7.19.3", "@babel/parser@^7.19.4":
344+
"@babel/parser@^7.18.10", "@babel/parser@^7.19.3", "@babel/parser@^7.19.4":
328345
version "7.19.4"
329346
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.19.4.tgz#03c4339d2b8971eb3beca5252bafd9b9f79db3dc"
330347
integrity sha512-qpVT7gtuOLjWeDTKLkJ6sryqLliBaFpAtGeqw5cs5giLldvh+Ch0plqnUMKoVAUS6ZEueQQiZV+p5pxtPitEsA==
@@ -495,6 +512,22 @@
495512
debug "^4.1.0"
496513
globals "^11.1.0"
497514

515+
"@babel/traverse@^7.19.0", "@babel/traverse@^7.19.3", "@babel/traverse@^7.19.4":
516+
version "7.19.4"
517+
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.19.4.tgz#f117820e18b1e59448a6c1fa9d0ff08f7ac459a8"
518+
integrity sha512-w3K1i+V5u2aJUOXBFFC5pveFLmtq1s3qcdDNC2qRI6WPBQIDaKFqXxDEqDO/h1dQ3HjsZoZMyIy6jGLq0xtw+g==
519+
dependencies:
520+
"@babel/code-frame" "^7.18.6"
521+
"@babel/generator" "^7.19.4"
522+
"@babel/helper-environment-visitor" "^7.18.9"
523+
"@babel/helper-function-name" "^7.19.0"
524+
"@babel/helper-hoist-variables" "^7.18.6"
525+
"@babel/helper-split-export-declaration" "^7.18.6"
526+
"@babel/parser" "^7.19.4"
527+
"@babel/types" "^7.19.4"
528+
debug "^4.1.0"
529+
globals "^11.1.0"
530+
498531
499532
version "7.17.0"
500533
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.17.0.tgz#a826e368bccb6b3d84acd76acad5c0d87342390b"
@@ -512,6 +545,15 @@
512545
"@babel/helper-validator-identifier" "^7.19.1"
513546
to-fast-properties "^2.0.0"
514547

548+
"@babel/types@^7.18.10", "@babel/types@^7.19.0", "@babel/types@^7.19.3", "@babel/types@^7.19.4":
549+
version "7.19.4"
550+
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.19.4.tgz#0dd5c91c573a202d600490a35b33246fed8a41c7"
551+
integrity sha512-M5LK7nAeS6+9j7hAq+b3fQs+pNfUtTGq+yFFfHnauFA8zQtLRfmuipmsKDKKLuyG+wC8ABW43A153YNawNTEtw==
552+
dependencies:
553+
"@babel/helper-string-parser" "^7.19.4"
554+
"@babel/helper-validator-identifier" "^7.19.1"
555+
to-fast-properties "^2.0.0"
556+
515557
"@bcoe/v8-coverage@^0.2.3":
516558
version "0.2.3"
517559
resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
@@ -749,7 +791,19 @@
749791
slash "^3.0.0"
750792
write-file-atomic "^4.0.1"
751793

752-
"@jest/types@^29.1.2", "@jest/types@^29.2.0":
794+
"@jest/types@^29.1.2":
795+
version "29.1.2"
796+
resolved "https://registry.yarnpkg.com/@jest/types/-/types-29.1.2.tgz#7442d32b16bcd7592d9614173078b8c334ec730a"
797+
integrity sha512-DcXGtoTykQB5jiwCmVr8H4vdg2OJhQex3qPkG+ISyDO7xQXbt/4R6dowcRyPemRnkH7JoHvZuxPBdlq+9JxFCg==
798+
dependencies:
799+
"@jest/schemas" "^29.0.0"
800+
"@types/istanbul-lib-coverage" "^2.0.0"
801+
"@types/istanbul-reports" "^3.0.0"
802+
"@types/node" "*"
803+
"@types/yargs" "^17.0.8"
804+
chalk "^4.0.0"
805+
806+
"@jest/types@^29.2.0":
753807
version "29.2.0"
754808
resolved "https://registry.yarnpkg.com/@jest/types/-/types-29.2.0.tgz#c0d1ef8bc1e4f4b358e7877e34157371e7881b0b"
755809
integrity sha512-mfgpQz4Z2xGo37m6KD8xEpKelaVzvYVRijmLPePn9pxgaPEtX+SqIyPNzzoeCPXKYbB4L/wYSgXDL8o3Gop78Q==
@@ -980,10 +1034,10 @@
9801034
dependencies:
9811035
"@sinonjs/commons" "^1.7.0"
9821036

983-
"@trivago/prettier-plugin-sort-imports@^3.3.1":
984-
version "3.3.1"
985-
resolved "https://registry.yarnpkg.com/@trivago/prettier-plugin-sort-imports/-/prettier-plugin-sort-imports-3.3.1.tgz#9210335f3883edefdc9f28f4d5b624871771fc34"
986-
integrity sha512-ITGspeOlFnK1dwJVjqOguGW3Ja8hakxOPFudhpP0YfsDHT0yM0u4TU+62Vl83hCatnhB4+fYhlSZyiifUv4xSg==
1037+
"@trivago/prettier-plugin-sort-imports@^3.3.0":
1038+
version "3.3.0"
1039+
resolved "https://registry.yarnpkg.com/@trivago/prettier-plugin-sort-imports/-/prettier-plugin-sort-imports-3.3.0.tgz#ee4e9ec1d8e3076b95fcb94311f42f7a61eecd37"
1040+
integrity sha512-1y44bVZuIN0RsS3oIiGd5k8Vm3IZXYZnp4VsP2Z/S5L9WAOw43HE2clso66M2S/dDeJ+8sKPqnHsEfh39Vjs3w==
9871041
dependencies:
9881042
"@babel/core" "7.17.8"
9891043
"@babel/generator" "7.17.7"
@@ -1530,9 +1584,9 @@ caniuse-lite@^1.0.30001366:
15301584
integrity sha512-XDgbeOHfifWV3GEES2B8rtsrADx4Jf+juKX2SICJcaUhjYBO3bR96kvEIHa15VU6ohtOhBZuPGGYGbXMRn0NCw==
15311585

15321586
caniuse-lite@^1.0.30001400:
1533-
version "1.0.30001420"
1534-
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001420.tgz#f62f35f051e0b6d25532cf376776d41e45b47ef6"
1535-
integrity sha512-OnyeJ9ascFA9roEj72ok2Ikp7PHJTKubtEJIQ/VK3fdsS50q4KWy+Z5X0A1/GswEItKX0ctAp8n4SYDE7wTu6A==
1587+
version "1.0.30001419"
1588+
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001419.tgz#3542722d57d567c8210d5e4d0f9f17336b776457"
1589+
integrity sha512-aFO1r+g6R7TW+PNQxKzjITwLOyDhVRLjW0LcwS/HCZGUUKTGNp9+IwLC4xyDSZBygVL/mxaFR3HIV6wEKQuSzw==
15361590

15371591
chalk@^2.0.0:
15381592
version "2.4.2"
@@ -1707,6 +1761,11 @@ diff-sequences@^29.2.0:
17071761
resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-29.2.0.tgz#4c55b5b40706c7b5d2c5c75999a50c56d214e8f6"
17081762
integrity sha512-413SY5JpYeSBZxmenGEmCVQ8mCgtFJF0w9PROdaS6z987XC2Pd2GOKqOITLtMftmyFZqgtCOb/QA7/Z3ZXfzIw==
17091763

1764+
diff-sequences@^29.2.0:
1765+
version "29.2.0"
1766+
resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-29.2.0.tgz#4c55b5b40706c7b5d2c5c75999a50c56d214e8f6"
1767+
integrity sha512-413SY5JpYeSBZxmenGEmCVQ8mCgtFJF0w9PROdaS6z987XC2Pd2GOKqOITLtMftmyFZqgtCOb/QA7/Z3ZXfzIw==
1768+
17101769
diff@^4.0.1:
17111770
version "4.0.2"
17121771
resolved "https://registry.yarnpkg.com/diff/-/diff-4.0.2.tgz#60f3aecb89d5fae520c11aa19efc2bb982aade7d"
@@ -1739,9 +1798,9 @@ electron-to-chromium@^1.4.188:
17391798
integrity sha512-8nCXyIQY9An88NXAp+PuPy5h3/w5ZY7Iu2lag65Q0XREprcat5F8gKhoHsBUnQcFuCRnmevpR8yEBYRU3d2HDw==
17401799

17411800
electron-to-chromium@^1.4.251:
1742-
version "1.4.283"
1743-
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.283.tgz#d4f263f5df402fd799c0a06255d580dcf8aa9a8e"
1744-
integrity sha512-g6RQ9zCOV+U5QVHW9OpFR7rdk/V7xfopNXnyAamdpFgCHgZ1sjI8VuR1+zG2YG/TZk+tQ8mpNkug4P8FU0fuOA==
1801+
version "1.4.282"
1802+
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.282.tgz#02af3fd6051e97ac3388a4b11d455bc1ca49838f"
1803+
integrity sha512-Dki0WhHNh/br/Xi1vAkueU5mtIc9XLHcMKB6tNfQKk+kPG0TEUjRh5QEMAUbRp30/rYNMFD1zKKvbVzwq/4wmg==
17451804

17461805
emittery@^0.10.2:
17471806
version "0.10.2"
@@ -1978,7 +2037,7 @@ exit@^0.1.2:
19782037
resolved "https://registry.yarnpkg.com/exit/-/exit-0.1.2.tgz#0632638f8d877cc82107d30a0fff1a17cba1cd0c"
19792038
integrity sha1-BjJjj42HfMghB9MKD/8aF8uhzQw=
19802039

1981-
expect@^29.0.0, expect@^29.2.0:
2040+
expect@^29.2.0:
19822041
version "29.2.0"
19832042
resolved "https://registry.yarnpkg.com/expect/-/expect-29.2.0.tgz#b90c6df52be7abfd9f206f273fbcf8b33d8f332d"
19842043
integrity sha512-03ClF3GWwUqd9Grgkr9ZSdaCJGMRA69PQ8jT7o+Bx100VlGiAFf9/8oIm9Qve7ZVJhuJxFftqFhviZJRxxNfvg==
@@ -2636,6 +2695,16 @@ jest-diff@^29.2.0:
26362695
jest-get-type "^29.2.0"
26372696
pretty-format "^29.2.0"
26382697

2698+
jest-diff@^29.2.0:
2699+
version "29.2.0"
2700+
resolved "https://registry.yarnpkg.com/jest-diff/-/jest-diff-29.2.0.tgz#b1e11ac1a1401fc4792ef8ba406b48f1ae7d2bc5"
2701+
integrity sha512-GsH07qQL+/D/GxlnU+sSg9GL3fBOcuTlmtr3qr2pnkiODCwubNN2/7slW4m3CvxDsEus/VEOfQKRFLyXsUlnZw==
2702+
dependencies:
2703+
chalk "^4.0.0"
2704+
diff-sequences "^29.2.0"
2705+
jest-get-type "^29.2.0"
2706+
pretty-format "^29.2.0"
2707+
26392708
jest-docblock@^29.2.0:
26402709
version "29.2.0"
26412710
resolved "https://registry.yarnpkg.com/jest-docblock/-/jest-docblock-29.2.0.tgz#307203e20b637d97cee04809efc1d43afc641e82"
@@ -2666,6 +2735,11 @@ jest-environment-node@^29.2.0:
26662735
jest-mock "^29.2.0"
26672736
jest-util "^29.2.0"
26682737

2738+
jest-get-type@^27.5.1:
2739+
version "27.5.1"
2740+
resolved "https://registry.yarnpkg.com/jest-get-type/-/jest-get-type-27.5.1.tgz#3cd613c507b0f7ace013df407a1c1cd578bcb4f1"
2741+
integrity sha512-2KY95ksYSaK7DMBWQn6dQz3kqAf3BB64y2udeG+hv4KfSOb9qwcYQstTJc1KCbsix+wLZWZYN8t7nwX3GOBLRw==
2742+
26692743
jest-get-type@^29.2.0:
26702744
version "29.2.0"
26712745
resolved "https://registry.yarnpkg.com/jest-get-type/-/jest-get-type-29.2.0.tgz#726646f927ef61d583a3b3adb1ab13f3a5036408"
@@ -2698,6 +2772,16 @@ jest-leak-detector@^29.2.0:
26982772
jest-get-type "^29.2.0"
26992773
pretty-format "^29.2.0"
27002774

2775+
jest-matcher-utils@^27.0.0:
2776+
version "27.5.1"
2777+
resolved "https://registry.yarnpkg.com/jest-matcher-utils/-/jest-matcher-utils-27.5.1.tgz#9c0cdbda8245bc22d2331729d1091308b40cf8ab"
2778+
integrity sha512-z2uTx/T6LBaCoNWNFWwChLBKYxTMcGBRjAt+2SbP929/Fflb9aa5LGma654Rz8z9HLxsrUaYzxE9T/EFIL/PAw==
2779+
dependencies:
2780+
chalk "^4.0.0"
2781+
jest-diff "^29.2.0"
2782+
jest-get-type "^29.2.0"
2783+
pretty-format "^29.2.0"
2784+
27012785
jest-matcher-utils@^29.2.0:
27022786
version "29.2.0"
27032787
resolved "https://registry.yarnpkg.com/jest-matcher-utils/-/jest-matcher-utils-29.2.0.tgz#d1d73add0e0efb0e316a50f296977505dc053e02"
@@ -2919,7 +3003,7 @@ jest-worker@^29.2.0:
29193003
merge-stream "^2.0.0"
29203004
supports-color "^8.0.0"
29213005

2922-
jest@^29.2:
3006+
jest@^29.1:
29233007
version "29.2.0"
29243008
resolved "https://registry.yarnpkg.com/jest/-/jest-29.2.0.tgz#e7997bc603f31e04edbbe87dd24cf6e7c432abac"
29253009
integrity sha512-6krPemKUXCEu5Fh3j6ZVoLMjpTQVm0OCU+7f3K/9gllX8wNIE6NSCQ6s0q2RDoiKLRaQlVRHyscjSPRPqCI0Fg==
@@ -3313,6 +3397,15 @@ pretty-format@^29.0.0, pretty-format@^29.2.0:
33133397
ansi-styles "^5.0.0"
33143398
react-is "^18.0.0"
33153399

3400+
pretty-format@^29.2.0:
3401+
version "29.2.0"
3402+
resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-29.2.0.tgz#1d4ea56fb46079b44efd9ed59c14f70f2950a61b"
3403+
integrity sha512-QCSUFdwOi924g24czhOH5eTkXxUCqlLGZBRCySlwDYHIXRJkdGyjJc9nZaqhlFBZws8dq5Dvk0lCilsmlfsPxw==
3404+
dependencies:
3405+
"@jest/schemas" "^29.0.0"
3406+
ansi-styles "^5.0.0"
3407+
react-is "^18.0.0"
3408+
33163409
progress@^2.0.0:
33173410
version "2.0.3"
33183411
resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.3.tgz#7e8cf8d8f5b8f239c1bc68beb4eb78567d572ef8"
@@ -3356,6 +3449,11 @@ react-is@^18.0.0:
33563449
resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.2.0.tgz#199431eeaaa2e09f86427efbb4f1473edb47609b"
33573450
integrity sha512-xWGDIW6x921xtzPkhiULtthJHoJvBbF3q26fzloPCK0hsvxtPVelvftw3zjbHWSkR2km9Z+4uxbDDK/6Zw9B8w==
33583451

3452+
react-is@^18.0.0:
3453+
version "18.2.0"
3454+
resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.2.0.tgz#199431eeaaa2e09f86427efbb4f1473edb47609b"
3455+
integrity sha512-xWGDIW6x921xtzPkhiULtthJHoJvBbF3q26fzloPCK0hsvxtPVelvftw3zjbHWSkR2km9Z+4uxbDDK/6Zw9B8w==
3456+
33593457
readdirp@~3.6.0:
33603458
version "3.6.0"
33613459
resolved "https://registry.yarnpkg.com/readdirp/-/readdirp-3.6.0.tgz#74a370bd857116e245b29cc97340cd431a02a6c7"

Diff for: modules/runners/lambdas/runners/src/scale-runners/scale-up.test.ts

-18
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,6 @@ describe('scaleUp with GHES', () => {
227227
expect(createRunner).toBeCalledWith(expectedRunnerParams);
228228
});
229229

230-
it('creates a runner with legacy event check_run', async () => {
231-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
232-
expect(createRunner).toBeCalledWith(expectedRunnerParams);
233-
});
234-
235230
it('creates a runner with labels in a specific group', async () => {
236231
process.env.RUNNER_EXTRA_LABELS = 'label1,label2';
237232
process.env.RUNNER_GROUP_NAME = 'TEST_GROUP';
@@ -396,14 +391,6 @@ describe('scaleUp with public GH', () => {
396391
expect(listEC2Runners).not.toBeCalled();
397392
});
398393

399-
it('does not list runners when no workflows are queued (check_run)', async () => {
400-
mockOctokit.checks.get.mockImplementation(() => ({
401-
data: { status: 'completed' },
402-
}));
403-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
404-
expect(listEC2Runners).not.toBeCalled();
405-
});
406-
407394
describe('on org level', () => {
408395
beforeEach(() => {
409396
process.env.ENABLE_ORGANIZATION_RUNNERS = 'true';
@@ -443,11 +430,6 @@ describe('scaleUp with public GH', () => {
443430
expect(createRunner).toBeCalledWith(expectedRunnerParams);
444431
});
445432

446-
it('creates a runner with legacy event check_run', async () => {
447-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
448-
expect(createRunner).toBeCalledWith(expectedRunnerParams);
449-
});
450-
451433
it('creates a runner with labels in s specific group', async () => {
452434
process.env.RUNNER_EXTRA_LABELS = 'label1,label2';
453435
process.env.RUNNER_GROUP_NAME = 'TEST_GROUP';

Diff for: modules/runners/lambdas/runners/src/scale-runners/scale-up.ts

-7
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,6 @@ async function isJobQueued(githubInstallationClient: Octokit, payload: ActionReq
104104
repo: payload.repositoryName,
105105
});
106106
isQueued = jobForWorkflowRun.data.status === 'queued';
107-
} else if (payload.eventType === 'check_run') {
108-
const checkRun = await githubInstallationClient.checks.get({
109-
check_run_id: payload.id,
110-
owner: payload.repositoryOwner,
111-
repo: payload.repositoryName,
112-
});
113-
isQueued = checkRun.data.status === 'queued';
114107
} else {
115108
throw Error(`Event ${payload.eventType} is not supported`);
116109
}

0 commit comments

Comments
 (0)