feat: tag runner volumes with the same tags as the instance (#3354)

* feat: tag runner volumes with the same tags as the instance

* docs: update contribution guide

* chore: git ignore terraform lock

* chore: revert git ignore terraform lock

Author: galargh

Diff for: .gitignore

@@ -22,4 +22,5 @@ secrets.auto.tfvars
 
 **/coverage/*
 
-node_modules/
+node_modules/
+

Diff for: CONTRIBUTING.md

@@ -63,17 +63,36 @@ Before you submit your pull request consider the following guidelines:
 
 * Create your patch, **including appropriate test cases**.
 * Install [Terraform](https://www.terraform.io/). We lock the version with [tfenv](https://github.com/tfutils/tfenv), check `required_version` in `versions.tf` for the current development version of the module.
-* Install [pre-commit hooks](https://pre-commit.com/). The hooks runs some basic checks. The commit will run the hooks, you can invoke the hooks manually `pre-commit run --all-files` as well.
+* Install [pre-commit hooks](https://pre-commit.com/). The hooks runs some basic checks. The commit will run the hooks, you can invoke the hooks manually `pre-commit run --all-files` as well. The hooks require tflint to be installed and terraform modules to be initialized.
+    * Install [tflint](https://github.com/terraform-linters/tflint). We use tflint to lint the terraform code.
+    * Initialize the terraform modules:
+
+        ```shell
+        terraform init
+        ```
+
 * For updating docs, you have to enable GitHub actions on your forked repository. Simply go to the tab Actions and enable actions.
-* Commit your changes using a descriptive commit message.
+* Commit your changes using a descriptive commit message:
 
     ```shell
     git commit -a
     ```
 
   Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
 
+* Install [node](https://nodejs.org/en/) and [yarn](https://yarnpkg.com/). We use yarn to lint, test and build the lambdas.
 * Build your changes locally to ensure all the tests pass:
+
+        ```shell
+        cd lambdas
+        yarn install
+        yarn format
+        yarn lint
+        yarn test
+        yarn build
+        cd ..
+        ```
+
 * Push your branch to Github:
 
     ```shell

Diff for: lambdas/functions/control-plane/src/aws/runners.test.ts

@@ -12,6 +12,7 @@ import {
 import { GetParameterCommand, GetParameterResult, PutParameterCommand, SSMClient } from '@aws-sdk/client-ssm';
 import { mockClient } from 'aws-sdk-client-mock';
 import 'aws-sdk-client-mock-jest';
+import { performance } from 'perf_hooks';
 
 import ScaleError from './../scale-runners/ScaleError';
 import { createRunner, listEC2Runners, terminateRunner } from './runners';
@@ -473,6 +474,12 @@ interface ExpectedFleetRequestValues {
 }
 
 function expectedCreateFleetRequest(expectedValues: ExpectedFleetRequestValues): CreateFleetCommandInput {
+  const tags = [
+    { Key: 'ghr:Application', Value: 'github-action-runner' },
+    { Key: 'ghr:created_by', Value: expectedValues.totalTargetCapacity > 1 ? 'pool-lambda' : 'scale-up-lambda' },
+    { Key: 'Type', Value: expectedValues.type },
+    { Key: 'Owner', Value: REPO_NAME },
+  ];
   const request: CreateFleetCommandInput = {
     LaunchTemplateConfigs: [
       {
@@ -507,12 +514,11 @@ function expectedCreateFleetRequest(expectedValues: ExpectedFleetRequestValues):
     TagSpecifications: [
       {
         ResourceType: 'instance',
-        Tags: [
-          { Key: 'ghr:Application', Value: 'github-action-runner' },
-          { Key: 'ghr:created_by', Value: expectedValues.totalTargetCapacity > 1 ? 'pool-lambda' : 'scale-up-lambda' },
-          { Key: 'Type', Value: expectedValues.type },
-          { Key: 'Owner', Value: REPO_NAME },
-        ],
+        Tags: tags,
+      },
+      {
+        ResourceType: 'volume',
+        Tags: tags,
       },
     ],
     TargetCapacitySpecification: {

Diff for: lambdas/functions/control-plane/src/aws/runners.ts

@@ -157,6 +157,12 @@ export async function createRunner(runnerParameters: Runners.RunnerInputParamete
   }
 
   const numberOfRunners = runnerParameters.numberOfRunners ? runnerParameters.numberOfRunners : 1;
+  const tags = [
+    { Key: 'ghr:Application', Value: 'github-action-runner' },
+    { Key: 'ghr:created_by', Value: numberOfRunners === 1 ? 'scale-up-lambda' : 'pool-lambda' },
+    { Key: 'Type', Value: runnerParameters.runnerType },
+    { Key: 'Owner', Value: runnerParameters.runnerOwner },
+  ];
 
   let fleet: CreateFleetResult;
   try {
@@ -186,12 +192,11 @@ export async function createRunner(runnerParameters: Runners.RunnerInputParamete
       TagSpecifications: [
         {
           ResourceType: 'instance',
-          Tags: [
-            { Key: 'ghr:Application', Value: 'github-action-runner' },
-            { Key: 'ghr:created_by', Value: numberOfRunners === 1 ? 'scale-up-lambda' : 'pool-lambda' },
-            { Key: 'Type', Value: runnerParameters.runnerType },
-            { Key: 'Owner', Value: runnerParameters.runnerOwner },
-          ],
+          Tags: tags,
+        },
+        {
+          ResourceType: 'volume',
+          Tags: tags,
         },
       ],
       Type: 'instant',