Skip to content

Commit f08ac1c

Browse files
seanmcnealymp911de
authored andcommitted
Extend SNIHostName check to reject hostnames with trailing dot.
[resolves #656]
1 parent 52a54b9 commit f08ac1c

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/main/java/io/r2dbc/postgresql/client/SSLConfig.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public static boolean isValidSniHostname(String input) {
108108
return false;
109109
}
110110
}
111-
return true;
111+
return !input.endsWith(".");
112112
}
113113

114114
//
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package io.r2dbc.postgresql.client;
2+
3+
import org.junit.jupiter.api.Test;
4+
5+
import static org.assertj.core.api.Assertions.assertThat;
6+
7+
/**
8+
* Unit tests for {@link SSLConfig}.
9+
*/
10+
final class SSLConfigTests {
11+
@Test
12+
public void testValidSniHostname(){
13+
assertThat(SSLConfig.isValidSniHostname("example.com")).isEqualTo(true);
14+
assertThat(SSLConfig.isValidSniHostname("example://.com")).isEqualTo(false);
15+
assertThat(SSLConfig.isValidSniHostname("example.com.")).isEqualTo(false);
16+
}
17+
}

0 commit comments

Comments
 (0)