Skip to content

Commit eb559fe

Browse files
committed
Polishing.
Simplify code. Use putIfAbsent instead of custom check. [#636][closes #641]
1 parent 9359974 commit eb559fe

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/main/java/io/r2dbc/postgresql/PostgresqlRow.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ final class PostgresqlRow implements io.r2dbc.postgresql.api.PostgresqlRow {
5959
this.data = Assert.requireNonNull(data, "data must not be null");
6060

6161
if (metadata instanceof PostgresqlRowMetadata) {
62-
this.columnNameIndexCacheMap = Assert.requireNonNull(
63-
((PostgresqlRowMetadata) metadata).getColumnNameIndexMap(),
64-
"columnNameIndexCacheMap must not be null");
62+
this.columnNameIndexCacheMap = ((PostgresqlRowMetadata) metadata).getColumnNameIndexMap();
6563
} else {
6664
this.columnNameIndexCacheMap = createColumnNameIndexMap(this.fields);
6765
}

src/main/java/io/r2dbc/postgresql/PostgresqlRowMetadata.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,13 @@ final class PostgresqlRowMetadata extends AbstractCollection<String> implements
4848

4949
PostgresqlRowMetadata(List<PostgresqlColumnMetadata> columnMetadatas) {
5050
this.columnMetadatas = Assert.requireNonNull(columnMetadatas, "columnMetadatas must not be null");
51-
this.nameKeyedColumns = new LinkedHashMap<>();
51+
this.nameKeyedColumns = new LinkedHashMap<>(columnMetadatas.size(), 1);
5252
this.columnNameIndexMap = new HashMap<>(columnMetadatas.size(), 1);
5353

5454
int i = 0;
5555
for (PostgresqlColumnMetadata columnMetadata : columnMetadatas) {
56-
if (!this.nameKeyedColumns.containsKey(columnMetadata.getName())) {
57-
this.nameKeyedColumns.put(columnMetadata.getName(), columnMetadata);
58-
}
59-
columnNameIndexMap.putIfAbsent(columnMetadata.getName().toLowerCase(Locale.ROOT), i++);
56+
this.nameKeyedColumns.putIfAbsent(columnMetadata.getName(), columnMetadata);
57+
this.columnNameIndexMap.putIfAbsent(columnMetadata.getName().toLowerCase(Locale.ROOT), i++);
6058
}
6159
}
6260

0 commit comments

Comments
 (0)