review comments addressed

Author: avinash-anand

src/main/java/io/r2dbc/postgresql/codec/DefaultCodecs.java

@@ -92,7 +92,9 @@ public DefaultCodecs(ByteBufAllocator byteBufAllocator) {
             new ShortArrayCodec(byteBufAllocator),
             new StringArrayCodec(byteBufAllocator),
             new IntegerArrayCodec(byteBufAllocator),
-            new LongArrayCodec(byteBufAllocator)
+            new LongArrayCodec(byteBufAllocator),
+
+            new PointCodec(byteBufAllocator)
         ));
     }
 

src/main/java/io/r2dbc/postgresql/codec/Point.java

@@ -6,8 +6,8 @@
  * <p>This implements a version of java.awt.Point, except it uses double to represent the coordinates.</p>
  */
 public class Point {
-    public double x;
-    public double y;
+    private double x;
+    private double y;
 
     /**
      * @param x coordinate
@@ -18,6 +18,22 @@ public Point(double x, double y) {
         this.y = y;
     }
 
+    public double getX() {
+        return x;
+    }
+
+    public void setX(double x) {
+        this.x = x;
+    }
+
+    public double getY() {
+        return y;
+    }
+
+    public void setY(double y) {
+        this.y = y;
+    }
+
     /**
      * Translate the point by the supplied amount.
      *

src/main/java/io/r2dbc/postgresql/codec/PointCodec.java

@@ -25,7 +25,7 @@ boolean doCanDecode(PostgresqlObjectId type, Format format) {
         Assert.requireNonNull(type, "type must not be null");
         Assert.requireNonNull(format, "format must not be null");
 
-        return POINT == type && format == FORMAT_BINARY;
+        return POINT == type;
     }
 
     @Override
@@ -34,16 +34,12 @@ Point doDecode(ByteBuf buffer, PostgresqlObjectId dataType, Format format, Class
         Assert.requireNonNull(type, "type must not be null");
         Assert.requireNonNull(format, "format must not be null");
 
-        try {
-            String decodedAsString = ByteBufUtils.decode(buffer);
-            String parenRemovedVal = decodedAsString.replaceAll("[()]", "");
-            String[] coordinatesAsString = parenRemovedVal.split(",");
-            double x = Double.parseDouble(coordinatesAsString[0]);
-            double y = Double.parseDouble(coordinatesAsString[1]);
-            return new Point(x, y);
-        } catch (NumberFormatException | NullPointerException | ArrayIndexOutOfBoundsException e) {
-            throw new IllegalArgumentException(e);
-        }
+        String decodedAsString = ByteBufUtils.decode(buffer);
+        String parenRemovedVal = decodedAsString.replaceAll("[()]", "");
+        String[] coordinatesAsString = parenRemovedVal.split(",");
+        double x = Double.parseDouble(coordinatesAsString[0]);
+        double y = Double.parseDouble(coordinatesAsString[1]);
+        return new Point(x, y);
     }
 
     /**
@@ -53,7 +49,7 @@ Point doDecode(ByteBuf buffer, PostgresqlObjectId dataType, Format format, Class
     @Override
     Parameter doEncode(Point value) {
         Assert.requireNonNull(value, "value must not be null");
-        String encodedValue = "(" + value.x + "," + value.y + ")";
+        String encodedValue = "(" + value.getX() + "," + value.getY() + ")";
         return create(POINT, FORMAT_BINARY, () -> ByteBufUtils.encode(this.byteBufAllocator, encodedValue));
     }
 

src/test/java/io/r2dbc/postgresql/AbstractCodecIntegrationTests.java

@@ -23,6 +23,7 @@
 import io.r2dbc.postgresql.api.PostgresqlStatement;
 import io.r2dbc.postgresql.codec.EnumCodec;
 import io.r2dbc.postgresql.codec.Json;
+import io.r2dbc.postgresql.codec.Point;
 import io.r2dbc.spi.Blob;
 import io.r2dbc.spi.Clob;
 import io.r2dbc.spi.Connection;
@@ -360,6 +361,11 @@ void offsetDateTime() {
         testCodec(OffsetDateTime.class, OffsetDateTime.now(), (actual, expected) -> assertThat(actual.isEqual(expected)).isTrue(), "TIMESTAMP WITH TIME ZONE");
     }
 
+    @Test
+    void point() {
+        testCodec(Point.class, new Point(1.12, 2.12), "POINT");
+    }
+
     @Test
     void shortArray() {
         testCodec(Short[].class, new Short[]{100, 200, 300}, "INT2[]");

src/test/java/io/r2dbc/postgresql/codec/PointCodecTest.java

@@ -40,7 +40,7 @@ void doCanDecode() {
         PointCodec codec = new PointCodec(TEST);
 
         assertThat(codec.doCanDecode(VARCHAR, FORMAT_BINARY)).isFalse();
-        assertThat(codec.doCanDecode(POINT, FORMAT_TEXT)).isFalse();
+        assertThat(codec.doCanDecode(POINT, FORMAT_TEXT)).isTrue();
         assertThat(codec.doCanDecode(POINT, FORMAT_BINARY)).isTrue();
     }