Skip to content

Commit 07666b1

Browse files
committed
Remove Codec.encodeNull(int) as we don't require each codec to implement null encoding with a given OID
[#378]
1 parent bcceab2 commit 07666b1

File tree

6 files changed

+4
-18
lines changed

6 files changed

+4
-18
lines changed

src/main/java/io/r2dbc/postgresql/codec/AbstractCodec.java

-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ public EncodedParameter encode(Object value, int dataType) {
9898
return doEncode((T) value, PostgresqlObjectId.valueOf(dataType));
9999
}
100100

101-
@Override
102101
public EncodedParameter encodeNull(int dataType) {
103102
return new EncodedParameter(Format.FORMAT_BINARY, dataType, NULL_VALUE);
104103
}

src/main/java/io/r2dbc/postgresql/codec/Codec.java

-9
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,6 @@ public interface Codec<T> {
9898
*/
9999
EncodedParameter encodeNull();
100100

101-
/**
102-
* Encode a {@code null} value using the given {@code dataType}.
103-
*
104-
* @param dataType the Postgres OID
105-
* @return the encoded {@code null} value
106-
* @since 0.9
107-
*/
108-
EncodedParameter encodeNull(int dataType);
109-
110101
/**
111102
* Returns the Java {@link Class type} of this codec.
112103
*

src/main/java/io/r2dbc/postgresql/codec/EnumCodec.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ public EncodedParameter encodeNull() {
105105
return encodeNull(this.oid);
106106
}
107107

108-
@Override
109-
public EncodedParameter encodeNull(int dataType) {
108+
private EncodedParameter encodeNull(int dataType) {
110109
return new EncodedParameter(Format.FORMAT_BINARY, dataType, NULL_VALUE);
111110
}
112111

src/main/java/io/r2dbc/postgresql/codec/HStoreCodec.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,7 @@ public EncodedParameter encodeNull() {
227227
return encodeNull(this.oid);
228228
}
229229

230-
@Override
231-
public EncodedParameter encodeNull(int dataType) {
230+
private EncodedParameter encodeNull(int dataType) {
232231
return new EncodedParameter(Format.FORMAT_BINARY, dataType, NULL_VALUE);
233232
}
234233

src/test/java/io/r2dbc/postgresql/CodecExtensionIntegrationTests.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ public EncodedParameter encodeNull() {
138138
return null;
139139
}
140140

141-
@Override
142-
public EncodedParameter encodeNull(int dataType) {
141+
private EncodedParameter encodeNull(int dataType) {
143142
return null;
144143
}
145144

src/test/java/io/r2dbc/postgresql/codec/DefaultCodecsUnitTests.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,7 @@ public EncodedParameter encodeNull() {
181181
return null;
182182
}
183183

184-
@Override
185-
public EncodedParameter encodeNull(int dataType) {
184+
private EncodedParameter encodeNull(int dataType) {
186185
return null;
187186
}
188187

0 commit comments

Comments
 (0)