Skip to content

Commit c7a6c67

Browse files
randycoulmanyannickcr
authored andcommitted
Fix spread props cash in jsx-no-target-blank
1 parent 00cdab8 commit c7a6c67

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/rules/jsx-no-target-blank.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = function(context) {
1515
var relFound = false;
1616
var attrs = node.parent.attributes;
1717
for (var idx in attrs) {
18-
if (attrs[idx].name.name === 'rel') {
18+
if (attrs[idx].name && attrs[idx].name.name === 'rel') {
1919
var tags = attrs[idx].value.value.split(' ');
2020
if (tags.indexOf('noopener') >= 0 && tags.indexOf('noreferrer') >= 0) {
2121
relFound = true;

tests/lib/rules/jsx-no-target-blank.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ ruleTester.run('jsx-no-target-blank', rule, {
2727
valid: [
2828
{code: '<a href="foobar"></a>', parserOptions: parserOptions},
2929
{code: '<a randomTag></a>', parserOptions: parserOptions},
30-
{code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>', parserOptions: parserOptions}
30+
{code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>', parserOptions: parserOptions},
31+
{code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>', parserOptions: parserOptions},
32+
{code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions}
3133
],
3234
invalid: [
3335
{code: '<a target="_blank"></a>', parserOptions: parserOptions,

0 commit comments

Comments
 (0)