Skip to content

Commit 839f1a6

Browse files
committed
Merge remote-tracking branch '328/feat/update_unused_styles_doc'
2 parents d973a65 + 3bb1442 commit 839f1a6

File tree

2 files changed

+49
-0
lines changed

2 files changed

+49
-0
lines changed

docs/rules/no-unused-styles.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,23 @@ const Hello = React.createClass({
9595
}
9696
});
9797
```
98+
99+
Dynamic styles are marked as used only if you use a local variable with the same name as the variable in the actual component .
100+
101+
```js
102+
const getStyles = () => {
103+
const styles = StyleSheet.create({
104+
name: {}
105+
})
106+
return styles;
107+
}
108+
const Hello = React.createClass({
109+
render: function() {
110+
const styles = getStyles();
111+
return <Text textStyle={styles.name}>Hello {this.props.name}</Text>;
112+
}
113+
});
114+
```
98115
Rules are also marked as used when they are used in tags that contain the word `style`.
99116

100117
```js

tests/lib/rules/no-unused-styles.js

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,21 @@ const tests = {
3131
}
3232
});
3333
`,
34+
}, {
35+
code: `
36+
const getStyles = () => {
37+
const styles = StyleSheet.create({
38+
name: {}
39+
})
40+
return styles;
41+
}
42+
const Hello = React.createClass({
43+
render: function() {
44+
const styles = getStyles();
45+
return <Text textStyle={styles.name}>Hello {this.props.name}</Text>;
46+
}
47+
});
48+
`,
3449
}, {
3550
code: `
3651
const Hello = React.createClass({
@@ -231,6 +246,23 @@ const tests = {
231246
errors: [{
232247
message: 'Unused style detected: styles.text',
233248
}],
249+
}, {
250+
code: `
251+
const getStyles = () => {
252+
return OtherStyleSheet.create({
253+
text: {}
254+
})
255+
}
256+
const Hi = React.createClass({
257+
render: function() {
258+
const globalStyles = getStyles();
259+
return <Text textStyle={globalStyles.text}>Hi {this.props.name}</Text>;
260+
}
261+
});
262+
`,
263+
errors: [{
264+
message: 'Unused style detected: undefined.text',
265+
}],
234266
}, {
235267
code: `
236268
const styles = StyleSheet.create({

0 commit comments

Comments
 (0)