Skip to content

Commit 5afd545

Browse files
dmitrizpetebacondarwin
authored andcommitted
docs(CONTRIBUTING): add warning about forced push
Add warning about the possible consequences of a forced push Closes angular#13747
1 parent 72b96ef commit 5afd545

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

CONTRIBUTING.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,19 @@ Before you submit your pull request consider the following guidelines:
123123
* If we suggest changes then:
124124
* Make the required updates.
125125
* Re-run the Angular test suite to ensure tests are still passing.
126-
* Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
126+
* Commit your changes to your branch (e.g. `my-fix-branch`).
127+
* Push the changes to your GitHub repository (this will update your Pull Request).
128+
129+
If the PR gets too outdated we may ask you to rebase and force push to update the PR:
127130

128131
```shell
129132
git rebase master -i
130133
git push origin my-fix-branch -f
131134
```
132135

136+
*WARNING. Squashing or reverting commits and forced push thereafter may remove GitHub comments
137+
on code that were previously made by you and others in your commits.*
138+
133139
That's it! Thank you for your contribution!
134140
135141
#### After your pull request is merged

0 commit comments

Comments
 (0)