Skip to content

Commit 4aca47f

Browse files
mgolpetebacondarwin
authored andcommitted
refactor(jqLite): wrap the jqueryVersion binding in a span
Protractor's by.binding selector selects the whole element in which the binding is contained as otherwise it can't know which bit of text has been interpolated. It's safer to wrap the binding in a span so that we're sure what the e2e tests are exactly testing.
1 parent 01883d9 commit 4aca47f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/e2e/fixtures/ng-jq-jquery/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html ng-app="test" ng-jq="jQuery_2_1_0">
33
<body>
4-
{{jqueryVersion}}
4+
<span>{{jqueryVersion}}</span>
55

66
<script src="http://ajax.googleapis.com/ajax/libs/jquery/2.1.0/jquery.min.js"></script>
77
<script>

test/e2e/fixtures/ng-jq/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html ng-app="test" ng-jq>
33
<body>
4-
{{jqueryVersion}}
4+
<span>{{jqueryVersion}}</span>
55

66
<script src="../../../../bower_components/jquery/dist/jquery.js"></script>
77
<script type="text/javascript">

0 commit comments

Comments
 (0)