Skip to content

Commit fbaa2e9

Browse files
authored
PMM-7 fix linters. (#161)
1 parent 82694ff commit fbaa2e9

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

cmd/postgres_exporter/percona_compatibility_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ import (
77
"bufio"
88
_ "embed"
99
"fmt"
10-
"github.com/stretchr/testify/assert"
11-
"io/ioutil"
1210
"net/http"
11+
"os"
1312
"regexp"
1413
"sort"
1514
"strings"
1615
"testing"
1716
"time"
17+
18+
"github.com/stretchr/testify/assert"
1819
)
1920

2021
//go:embed percona-reference-metrics.txt
@@ -34,7 +35,7 @@ func TestReferenceCompatibility(t *testing.T) {
3435
resp, err := client.Do(req)
3536
assert.Nil(t, err)
3637
defer resp.Body.Close()
37-
currentMetricsBytes, err := ioutil.ReadAll(resp.Body)
38+
currentMetricsBytes, err := os.ReadAll(resp.Body)
3839
assert.Nil(t, err)
3940

4041
currentMetrics := toMap(t, string(currentMetricsBytes))

cmd/postgres_exporter/percona_exporter.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"crypto/sha256"
55
"database/sql"
66
"fmt"
7-
"io/ioutil"
7+
"os"
88
"path/filepath"
99
"strings"
1010

@@ -87,7 +87,7 @@ func initializePerconaExporters(dsn []string, servers *Servers) (func(), *Export
8787

8888
func (e *Exporter) loadCustomQueries(res MetricResolution, version semver.Version, server *Server) {
8989
if e.userQueriesPath[res] != "" {
90-
fi, err := ioutil.ReadDir(e.userQueriesPath[res])
90+
fi, err := os.ReadDir(e.userQueriesPath[res])
9191
if err != nil {
9292
level.Error(logger).Log("msg", fmt.Sprintf("failed read dir %q for custom query", e.userQueriesPath[res]),
9393
"err", err)
@@ -110,7 +110,7 @@ func (e *Exporter) loadCustomQueries(res MetricResolution, version semver.Versio
110110

111111
func (e *Exporter) addCustomQueriesFromFile(path string, version semver.Version, server *Server) {
112112
// Calculate the hashsum of the useQueries
113-
userQueriesData, err := ioutil.ReadFile(path)
113+
userQueriesData, err := os.ReadFile(path)
114114
if err != nil {
115115
level.Error(logger).Log("msg", "Failed to reload user queries:"+path, "err", err)
116116
e.userQueriesError.WithLabelValues(path, "").Set(1)

percona_tests/performance_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package percona_tests
33
import (
44
"flag"
55
"fmt"
6-
"io/ioutil"
6+
"os"
77
"strconv"
88
"strings"
99
"testing"
@@ -154,7 +154,7 @@ func doTest(iterations int, fileName, argsFile string) (cpu, hwm, data int64, _
154154
}
155155

156156
func getCPUMem(pid int) (hwm, data int64) {
157-
contents, err := ioutil.ReadFile(fmt.Sprintf("/proc/%d/status", pid))
157+
contents, err := os.ReadFile(fmt.Sprintf("/proc/%d/status", pid))
158158
if err != nil {
159159
return 0, 0
160160
}
@@ -178,7 +178,7 @@ func getCPUMem(pid int) (hwm, data int64) {
178178
}
179179

180180
func getCPUTime(pid int) (total int64) {
181-
contents, err := ioutil.ReadFile(fmt.Sprintf("/proc/%d/stat", pid))
181+
contents, err := os.ReadFile(fmt.Sprintf("/proc/%d/stat", pid))
182182
if err != nil {
183183
return
184184
}

0 commit comments

Comments
 (0)