Skip to content

Commit 4ce42b7

Browse files
committed
Use standardized identifier for ARM target build filenames
A convention has been established of using "ARM" in the host target identifiers (e.g., "ARM64") of the build artifact filenames in Arduino tooling projects. Previously the Arduino IDE 2.x project departed from that convention by instead using "arm" (e.g., "arm64"). The inconsistency is hereby resolved by using "ARM" in the filenames of the artifacts generated by the build process as well as in the names of the tester build workflow artifacts.
1 parent 21bd427 commit 4ce42b7

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ env:
9898
certificate-extension: p12
9999
mergeable-channel-file: 'true'
100100
artifacts:
101-
- path: '*macOS_arm64.dmg'
102-
name: macOS_arm64_dmg
103-
- path: '*macOS_arm64.zip'
104-
name: macOS_arm64_zip
101+
- path: '*macOS_ARM64.dmg'
102+
name: macOS_ARM64_dmg
103+
- path: '*macOS_ARM64.zip'
104+
name: macOS_ARM64_zip
105105
106106
jobs:
107107
run-determination:

electron-app/scripts/package.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,17 +106,17 @@ async function getArtifactName(version) {
106106
}
107107
case 'darwin': {
108108
if (arch === 'arm64') {
109-
return `${name}_${version}_macOS_arm64.\$\{ext}`;
109+
return `${name}_${version}_macOS_ARM64.\$\{ext}`;
110110
}
111111
return `${name}_${version}_macOS_64bit.\$\{ext}`;
112112
}
113113
case 'linux': {
114114
switch (arch) {
115115
case 'arm': {
116-
return `${name}_${version}_Linux_armv7.\$\{ext}`;
116+
return `${name}_${version}_Linux_ARMv7.\$\{ext}`;
117117
}
118118
case 'arm64': {
119-
return `${name}_${version}_Linux_arm64.\$\{ext}`;
119+
return `${name}_${version}_Linux_ARM64.\$\{ext}`;
120120
}
121121
case 'x64': {
122122
return `${name}_${version}_Linux_64bit.\$\{ext}`;

0 commit comments

Comments
 (0)