fix: eslint configs

pedronauck · pedronauck · commit 280981f4e1c1 · 2019-06-26T17:24:49.000-03:00
diff --git a/.eslintignore b/.eslintignore
@@ -1 +1 @@
-**/dist
+**/**/dist/**
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,9 +1,10 @@
 {
   "typescript.tsdk": "node_modules/typescript/lib",
+  "javascript.format.enable": false,
   "eslint.autoFixOnSave": true,
   "eslint.validate": [
-    "javascript",
-    "javascriptreact",
+    { "language": "javascript", "autoFix": true },
+    { "language": "javascriptreact", "autoFix": true },
     { "language": "typescript", "autoFix": true },
     { "language": "typescriptreact", "autoFix": true }
   ]
diff --git a/core/docz-core/.eslintignore b/core/docz-core/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/core/docz-core/.eslintrc.js b/core/docz-core/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/core/docz-core/package.json b/core/docz-core/package.json
@@ -56,6 +56,7 @@
     "@types/shelljs": "^0.8.5",
     "@types/signale": "^1.2.1",
     "cpy": "^7.3.0",
-    "docz-rollup": "^1.2.0"
+    "docz-rollup": "^1.2.0",
+    "eslint-config-docz-ts": "^1.2.0"
   }
 }
diff --git a/core/docz-core/src/bundler/config.ts b/core/docz-core/src/bundler/config.ts
@@ -3,7 +3,9 @@ import { ServerHooks as Hooks } from '../lib/Bundler'
 
 import * as paths from '../config/paths'
 
-export const createConfig = (args: Args, env: Env) => async (hooks: Hooks) => {
+export const createConfig = (args: Args, _env: Env) => async (
+  _hooks: Hooks
+) => {
   return {
     gatsbyConfig: {
       siteMetadata: {
diff --git a/core/docz-core/src/bundler/server.ts b/core/docz-core/src/bundler/server.ts
@@ -6,7 +6,7 @@ import { Config as Args } from '../config/argv'
 import { ServerHooks as Hooks } from '../lib/Bundler'
 import { devServerMachine } from '../machines/devServer'
 
-export const server = (args: Args) => async (config: any, hooks: Hooks) => {
+export const server = (args: Args) => async (config: any, _hooks: Hooks) => {
   const doczrcFilepath = await findUp(finds('docz'))
   const machine = devServerMachine.withContext({
     args,
diff --git a/core/docz-core/src/commands/serve.ts b/core/docz-core/src/commands/serve.ts
@@ -4,7 +4,7 @@ import sh from 'shelljs'
 
 import * as paths from '../config/paths'
 
-export const serve = async (args: Arguments<any>) => {
+export const serve = async (_args: Arguments<any>) => {
   sh.cd(paths.docz)
   spawn.sync('yarn', ['serve'], { stdio: 'inherit' })
 }
diff --git a/core/docz-rollup/.eslintrc.js b/core/docz-rollup/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-js',
 }
diff --git a/core/docz-rollup/package.json b/core/docz-rollup/package.json
@@ -30,5 +30,8 @@
     "rollup-plugin-postcss": "^2.0.3",
     "rollup-plugin-progress": "^1.1.1",
     "rollup-plugin-typescript2": "^0.21.2"
+  },
+  "devDependencies": {
+    "eslint-config-docz-js": "^1.2.0"
   }
 }
diff --git a/core/docz-rollup/src/plugins/size.js b/core/docz-rollup/src/plugins/size.js
@@ -7,9 +7,7 @@ const filesize = require('filesize')
 const gzip = require('gzip-size')
 const logUpdate = require('log-update')
 
-const cwd = process.cwd()
 const label = `${chalk.cyan.bold(figures.arrowRight)}`
-
 const placeholder = text => chalk.gray(`${text}:`)
 const getFilesize = file => filesize(fs.statSync(file).size)
 const getGzipSize = file => filesize(gzip.sync(fs.readFileSync(file, 'utf-8')))
@@ -19,7 +17,6 @@ module.exports = dest => ({
   generateBundle(opts, bundle, isWrite) {
     if (!isWrite) return
 
-    const destDir = path.join(cwd, dest)
     const keys = Object.keys(bundle)
     const builds = keys.map(key => bundle[key])
 
diff --git a/core/docz-utils/.eslintignore b/core/docz-utils/.eslintignore
@@ -0,0 +1 @@
+lib
diff --git a/core/docz-utils/.eslintrc.js b/core/docz-utils/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/core/docz-utils/package.json b/core/docz-utils/package.json
@@ -44,6 +44,7 @@
     "unist-util-visit": "^1.4.1"
   },
   "devDependencies": {
-    "docz-rollup": "^1.2.0"
+    "docz-rollup": "^1.2.0",
+    "eslint-config-docz-ts": "^1.2.0"
   }
 }
diff --git a/core/docz-utils/src/format.ts b/core/docz-utils/src/format.ts
@@ -10,7 +10,7 @@ export const formatter = (code: string) =>
   } as any)
 
 export const format = (code: string): Promise<string> =>
-  new Promise((resolve, reject) => {
+  new Promise(resolve => {
     try {
       const result = formatter(code)
 
diff --git a/core/docz/.eslintignore b/core/docz/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/core/docz/.eslintrc.js b/core/docz/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/core/docz/package.json b/core/docz/package.json
@@ -49,7 +49,8 @@
     "@types/node": "^12.0.10",
     "@types/reach__router": "^1.2.4",
     "@types/react": "^16.8.22",
-    "docz-rollup": "^1.2.0"
+    "docz-rollup": "^1.2.0",
+    "eslint-config-docz-ts": "^1.2.0"
   },
   "resolutions": {
     "react": "^16.8.6"
diff --git a/core/docz/src/hooks/useWindowSize.ts b/core/docz/src/hooks/useWindowSize.ts
@@ -12,7 +12,7 @@ const getSize = (initialWidth: number, initialHeight: number) => ({
 
 export const useWindowSize = (
   throttleMs: number = 300,
-  initialWidth = Infinity,
+  _initialWidth = Infinity,
   initialHeight = Infinity
 ) => {
   const [windowSize, setWindowSize] = useState(
diff --git a/core/gatsby-theme-docz/.eslintignore b/core/gatsby-theme-docz/.eslintignore
diff --git a/core/gatsby-theme-docz/.eslintrc.js b/core/gatsby-theme-docz/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-js',
 }
diff --git a/core/gatsby-theme-docz/lib/createPages.js b/core/gatsby-theme-docz/lib/createPages.js
@@ -23,7 +23,7 @@ const ENTRIES_QUERY = `
   }
 `
 
-module.exports = ({ graphql, actions, ...props }) => {
+module.exports = ({ graphql, actions }) => {
   return graphql(ENTRIES_QUERY).then(({ data, errors }) => {
     const hasErrors = errors && errors.length > 0
     const entries = get('allDoczEntries.edges', data)
diff --git a/core/gatsby-theme-docz/lib/sourceNodes.js b/core/gatsby-theme-docz/lib/sourceNodes.js
@@ -53,7 +53,7 @@ module.exports = async ({ actions, createNodeId }, opts) => {
     const values = Object.entries(map)
     const contentDigest = digest(JSON.stringify(values))
 
-    values.forEach(([key, entry]) => {
+    values.forEach(([, entry]) => {
       if (!entry) return null
       createNode({
         ...entry,
diff --git a/core/gatsby-theme-docz/package.json b/core/gatsby-theme-docz/package.json
@@ -63,11 +63,6 @@
   "devDependencies": {
     "babel-eslint": "10.0.2",
     "eslint": "^5.16.0",
-    "eslint-config-react-app": "^4.0.1",
-    "eslint-plugin-flowtype": "3.11.1",
-    "eslint-plugin-import": "2.18.0",
-    "eslint-plugin-jsx-a11y": "6.2.1",
-    "eslint-plugin-react": "7.14.2",
-    "eslint-plugin-react-hooks": "^1.6.0"
+    "eslint-config-docz-js": "^1.2.0"
   }
 }
diff --git a/core/gatsby-theme-docz/src/components/Header/index.js b/core/gatsby-theme-docz/src/components/Header/index.js
@@ -4,7 +4,6 @@ import { Link, useConfig, useCurrentDoc } from 'docz'
 import styled from '@emotion/styled'
 
 import { themeProp } from '~utils/theme'
-import { breakpoints } from '~theme/breakpoints'
 
 import { Edit, Sun, Menu, Github } from '../Icons'
 import * as styles from './styles'
diff --git a/core/rehype-docz/.eslintignore b/core/rehype-docz/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/core/rehype-docz/.eslintrc.js b/core/rehype-docz/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/core/rehype-docz/package.json b/core/rehype-docz/package.json
@@ -29,6 +29,7 @@
   "devDependencies": {
     "@mdx-js/mdx": "^1.0.21",
     "docz-rollup": "^1.2.0",
+    "eslint-config-docz-ts": "^1.2.0",
     "remark-docz": "^1.2.0"
   }
 }
diff --git a/core/remark-docz/.eslintignore b/core/remark-docz/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/core/remark-docz/.eslintrc.js b/core/remark-docz/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/core/remark-docz/package.json b/core/remark-docz/package.json
@@ -27,6 +27,7 @@
   },
   "devDependencies": {
     "@mdx-js/mdx": "^1.0.21",
-    "docz-rollup": "^1.2.0"
+    "docz-rollup": "^1.2.0",
+    "eslint-config-docz-ts": "^1.2.0"
   }
 }
diff --git a/core/remark-docz/src/index.ts b/core/remark-docz/src/index.ts
@@ -99,21 +99,13 @@ const imageToJsx = (node: any): string =>
 
 // turns `html` nodes into `jsx` nodes
 export default () => (tree: any) => {
-  visit(
-    tree,
-    'image',
-    (node: any, idx: any): void => {
-      // check if a node has just open tag
-      node.type = 'jsx'
-      node.value = imageToJsx(node)
-    }
-  )
-  visit(
-    tree,
-    'jsx',
-    (node: any, idx: any): void => {
-      // check if a node has just open tag
-      mergeNodeWithoutCloseTag(tree, node, idx)
-    }
-  )
+  visit(tree, 'image', (node: any): void => {
+    // check if a node has just open tag
+    node.type = 'jsx'
+    node.value = imageToJsx(node)
+  })
+  visit(tree, 'jsx', (node: any, idx: any): void => {
+    // check if a node has just open tag
+    mergeNodeWithoutCloseTag(tree, node, idx)
+  })
 }
diff --git a/other-packages/babel-plugin-export-metadata/.eslintrc.js b/other-packages/babel-plugin-export-metadata/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-js',
 }
diff --git a/other-packages/babel-plugin-export-metadata/package.json b/other-packages/babel-plugin-export-metadata/package.json
@@ -35,6 +35,7 @@
   "devDependencies": {
     "babel-jest": "^24.8.0",
     "docz-rollup": "^1.2.0",
+    "eslint-config-docz-js": "^1.2.0",
     "jest": "^24.8.0"
   }
 }
diff --git a/other-packages/babel-plugin-export-metadata/src/index.js b/other-packages/babel-plugin-export-metadata/src/index.js
@@ -64,13 +64,6 @@ const renameDefaultAddFileMetaProperties = (t, path, filename, name) => {
     SOURCE: sourceValue,
   })
 
-  // insert
-  const newNode = buildFileMeta({
-    ID: t.identifier(fallbackName),
-    NAME: t.stringLiteral(fallbackName),
-    FILENAME: t.stringLiteral(filename),
-  })
-
   pathToInsert.replaceWithMultiple(nameExport)
 }
 
diff --git a/other-packages/eslint-config-docz-js/CHANGELOG.md b/other-packages/eslint-config-docz-js/CHANGELOG.md
diff --git a/other-packages/eslint-config-docz-js/index.js b/other-packages/eslint-config-docz-js/index.js
@@ -0,0 +1,32 @@
+module.exports = {
+  parser: 'babel-eslint',
+  extends: ['plugin:react/recommended', 'plugin:prettier/recommended'],
+  rules: {
+    'no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false,
+        argsIgnorePattern: '^_',
+      },
+    ],
+    'comma-dangle': ['error', 'always-multiline'],
+    'no-mixed-operators': 'error',
+    'no-console': 'off',
+    'no-undef': 'off',
+    'react/prop-types': 'off',
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+  settings: {
+    react: {
+      version: 'detect',
+    },
+  },
+}
diff --git a/other-packages/eslint-config-docz-js/package.json b/other-packages/eslint-config-docz-js/package.json
@@ -0,0 +1,26 @@
+{
+  "name": "eslint-config-docz-js",
+  "version": "1.2.0",
+  "description": "Eslint config of Docz for Javascript",
+  "license": "MIT",
+  "author": {
+    "name": "Pedro Nauck",
+    "email": "pedronauck@gmail.com"
+  },
+  "main": "index.js",
+  "files": [
+    "index.js",
+    "package.json"
+  ],
+  "scripts": {
+    "fix": "run-s fix:*",
+    "fix:prettier": "prettier \"src/**/*.js\" --write"
+  },
+  "dependencies": {
+    "babel-eslint": "^10.0.2",
+    "eslint": "^5.16.0",
+    "eslint-config-prettier": "^5.0.0",
+    "eslint-plugin-prettier": "^3.1.0",
+    "eslint-plugin-react": "^7.13.0"
+  }
+}
diff --git a/other-packages/eslint-config-docz-ts/CHANGELOG.md b/other-packages/eslint-config-docz-ts/CHANGELOG.md
@@ -0,0 +1,16 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
+# [1.2.0](https://github.com/pedronauck/docz/compare/v1.1.0...v1.2.0) (2019-05-08)
+
+**Note:** Version bump only for package eslint-config-docz
+
+
+
+
+
+# [1.1.0](https://github.com/pedronauck/docz/compare/v1.0.4...v1.1.0) (2019-05-01)
+
+**Note:** Version bump only for package eslint-config-docz
diff --git a/other-packages/eslint-config-docz-ts/index.js b/other-packages/eslint-config-docz-ts/index.js
@@ -12,7 +12,15 @@ module.exports = {
     'no-console': 'off',
     'no-undef': 'off',
     'react/prop-types': 'off',
-    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false,
+        argsIgnorePattern: '^_',
+      },
+    ],
     '@typescript-eslint/indent': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
diff --git a/other-packages/eslint-config-docz-ts/package.json b/other-packages/eslint-config-docz-ts/package.json
@@ -1,15 +1,15 @@
 {
-  "name": "eslint-config-docz",
+  "name": "eslint-config-docz-ts",
   "version": "1.2.0",
-  "description": "Eslint config of Docz",
+  "description": "Eslint config of Docz for Typescript",
   "license": "MIT",
   "author": {
     "name": "Pedro Nauck",
     "email": "pedronauck@gmail.com"
   },
-  "main": "src/index.js",
+  "main": "index.js",
   "files": [
-    "src/",
+    "index.js",
     "package.json"
   ],
   "scripts": {
diff --git a/other-packages/load-cfg/.eslintignore b/other-packages/load-cfg/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/other-packages/load-cfg/.eslintrc.js b/other-packages/load-cfg/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['eslint-config-docz'],
+  extends: 'docz-ts',
 }
diff --git a/other-packages/load-cfg/package.json b/other-packages/load-cfg/package.json
diff --git a/other-packages/react-docgen-actual-name-handler/.eslintignore b/other-packages/react-docgen-actual-name-handler/.eslintignore
diff --git a/other-packages/react-docgen-actual-name-handler/.eslintrc.js b/other-packages/react-docgen-actual-name-handler/.eslintrc.js
diff --git a/other-packages/react-docgen-actual-name-handler/package.json b/other-packages/react-docgen-actual-name-handler/package.json
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,10 @@`
`1`	`1`	`{`
`2`	`2`	`"typescript.tsdk": "node_modules/typescript/lib",`
	`3`	`+ "javascript.format.enable": false,`
`3`	`4`	`"eslint.autoFixOnSave": true,`
`4`	`5`	`"eslint.validate": [`
`5`		`- "javascript",`
`6`		`- "javascriptreact",`
	`6`	`+ { "language": "javascript", "autoFix": true },`
	`7`	`+ { "language": "javascriptreact", "autoFix": true },`
`7`	`8`	`{ "language": "typescript", "autoFix": true },`
`8`	`9`	`{ "language": "typescriptreact", "autoFix": true }`
`9`	`10`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`module.exports = {`
`2`		`- extends: ['eslint-config-docz'],`
	`2`	`+ extends: 'docz-ts',`
`3`	`3`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@`
`56`	`56`	`"@types/shelljs": "^0.8.5",`
`57`	`57`	`"@types/signale": "^1.2.1",`
`58`	`58`	`"cpy": "^7.3.0",`
`59`		`- "docz-rollup": "^1.2.0"`
	`59`	`+ "docz-rollup": "^1.2.0",`
	`60`	`+ "eslint-config-docz-ts": "^1.2.0"`
`60`	`61`	`}`
`61`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import sh from 'shelljs'`
`4`	`4`
`5`	`5`	`import * as paths from '../config/paths'`
`6`	`6`
`7`		`-export const serve = async (args: Arguments<any>) => {`
	`7`	`+export const serve = async (_args: Arguments<any>) => {`
`8`	`8`	`sh.cd(paths.docz)`
`9`	`9`	`spawn.sync('yarn', ['serve'], { stdio: 'inherit' })`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,5 +30,8 @@`
`30`	`30`	`"rollup-plugin-postcss": "^2.0.3",`
`31`	`31`	`"rollup-plugin-progress": "^1.1.1",`
`32`	`32`	`"rollup-plugin-typescript2": "^0.21.2"`
	`33`	`+ },`
	`34`	`+ "devDependencies": {`
	`35`	`+ "eslint-config-docz-js": "^1.2.0"`
`33`	`36`	`}`
`34`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@`
`44`	`44`	`"unist-util-visit": "^1.4.1"`
`45`	`45`	`},`
`46`	`46`	`"devDependencies": {`
`47`		`- "docz-rollup": "^1.2.0"`
	`47`	`+ "docz-rollup": "^1.2.0",`
	`48`	`+ "eslint-config-docz-ts": "^1.2.0"`
`48`	`49`	`}`
`49`	`50`	`}`
Original file line number	Diff line number	Diff line change
@@ -23,7 +23,7 @@ const ENTRIES_QUERY = `
`23`	`23`	`}`
`24`	`24`	`
`25`	`25`
`26`		`-module.exports = ({ graphql, actions, ...props }) => {`
	`26`	`+module.exports = ({ graphql, actions }) => {`
`27`	`27`	`return graphql(ENTRIES_QUERY).then(({ data, errors }) => {`
`28`	`28`	`const hasErrors = errors && errors.length > 0`
`29`	`29`	`const entries = get('allDoczEntries.edges', data)`
Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,6 @@`
`63`	`63`	`"devDependencies": {`
`64`	`64`	`"babel-eslint": "10.0.2",`
`65`	`65`	`"eslint": "^5.16.0",`
`66`		`- "eslint-config-react-app": "^4.0.1",`
`67`		`- "eslint-plugin-flowtype": "3.11.1",`
`68`		`- "eslint-plugin-import": "2.18.0",`
`69`		`- "eslint-plugin-jsx-a11y": "6.2.1",`
`70`		`- "eslint-plugin-react": "7.14.2",`
`71`		`- "eslint-plugin-react-hooks": "^1.6.0"`
	`66`	`+ "eslint-config-docz-js": "^1.2.0"`
`72`	`67`	`}`
`73`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@`
`29`	`29`	`"devDependencies": {`
`30`	`30`	`"@mdx-js/mdx": "^1.0.21",`
`31`	`31`	`"docz-rollup": "^1.2.0",`
	`32`	`+ "eslint-config-docz-ts": "^1.2.0",`
`32`	`33`	`"remark-docz": "^1.2.0"`
`33`	`34`	`}`
`34`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`},`
`28`	`28`	`"devDependencies": {`
`29`	`29`	`"@mdx-js/mdx": "^1.0.21",`
`30`		`- "docz-rollup": "^1.2.0"`
	`30`	`+ "docz-rollup": "^1.2.0",`
	`31`	`+ "eslint-config-docz-ts": "^1.2.0"`
`31`	`32`	`}`
`32`	`33`	`}`