Skip to content

Commit bad3ee5

Browse files
icywang86ruiPiali Das
authored and
Piali Das
committed
Increase timeout for createEndpoint in integration tests (aws#337)
* Change timeout to 45 minutes for createEndpoint in integ tests
1 parent 21dcae9 commit bad3ee5

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

tests/integ/test_chainer_train.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ def test_training_with_additional_hyperparameters(sagemaker_session, chainer_ful
6666
def test_attach_deploy(chainer_training_job, sagemaker_session):
6767
endpoint_name = 'test-chainer-attach-deploy-{}'.format(sagemaker_timestamp())
6868

69-
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
69+
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
7070
estimator = Chainer.attach(chainer_training_job, sagemaker_session=sagemaker_session)
7171
predictor = estimator.deploy(1, 'ml.m4.xlarge', endpoint_name=endpoint_name)
7272
_predict_and_assert(predictor)
7373

7474

7575
def test_deploy_model(chainer_training_job, sagemaker_session):
7676
endpoint_name = 'test-chainer-deploy-model-{}'.format(sagemaker_timestamp())
77-
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
77+
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
7878
desc = sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=chainer_training_job)
7979
model_data = desc['ModelArtifacts']['S3ModelArtifacts']
8080
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'mnist.py')
@@ -93,7 +93,7 @@ def test_async_fit(sagemaker_session):
9393
print("Waiting to re-attach to the training job: %s" % training_job_name)
9494
time.sleep(20)
9595

96-
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=35):
96+
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
9797
print("Re-attaching now to: %s" % training_job_name)
9898
estimator = Chainer.attach(training_job_name=training_job_name, sagemaker_session=sagemaker_session)
9999
predictor = estimator.deploy(1, "ml.c4.xlarge", endpoint_name=endpoint_name)

tests/integ/test_pytorch_train.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def fixture_training_job(sagemaker_session, pytorch_full_version):
4141
def test_sync_fit_deploy(pytorch_training_job, sagemaker_session):
4242
# TODO: add tests against local mode when it's ready to be used
4343
endpoint_name = 'test-pytorch-sync-fit-attach-deploy{}'.format(sagemaker_timestamp())
44-
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
44+
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
4545
estimator = PyTorch.attach(pytorch_training_job, sagemaker_session=sagemaker_session)
4646
predictor = estimator.deploy(1, 'ml.c4.xlarge', endpoint_name=endpoint_name)
4747
data = numpy.zeros(shape=(1, 1, 28, 28), dtype=numpy.float32)

tests/integ/test_randomcutforest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_randomcutforest(sagemaker_session):
3434
rcf.fit(rcf.record_set(train_input))
3535

3636
endpoint_name = name_from_base('randomcutforest')
37-
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
37+
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
3838
model = RandomCutForestModel(rcf.model_data, role='SageMakerRole', sagemaker_session=sagemaker_session)
3939
predictor = model.deploy(1, 'ml.c4.xlarge', endpoint_name=endpoint_name)
4040

tests/integ/test_tuner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ def test_attach_tuning_pytorch(sagemaker_session):
344344

345345
attached_tuner = HyperparameterTuner.attach(tuning_job_name, sagemaker_session=sagemaker_session)
346346
best_training_job = tuner.best_training_job()
347-
with timeout_and_delete_endpoint_by_name(best_training_job, sagemaker_session, minutes=20):
347+
with timeout_and_delete_endpoint_by_name(best_training_job, sagemaker_session):
348348
predictor = attached_tuner.deploy(1, 'ml.c4.xlarge')
349349
data = np.zeros(shape=(1, 1, 28, 28), dtype=np.float32)
350350
predictor.predict(data)

tests/integ/timeout.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def handler(signum, frame):
6060

6161

6262
@contextmanager
63-
def timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, seconds=0, minutes=35, hours=0):
63+
def timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, seconds=0, minutes=45, hours=0):
6464
with timeout(seconds=seconds, minutes=minutes, hours=hours) as t:
6565
no_errors = False
6666
try:

0 commit comments

Comments
 (0)