Skip to content

Commit d81d8ee

Browse files
gfyoungpcluo
authored andcommitted
MAINT: Remove self.assertNotEqual from testing (pandas-dev#16176)
1 parent f64025f commit d81d8ee

18 files changed

+40
-42
lines changed

pandas/tests/frame/test_api.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ def test_deepcopy(self):
247247
series = cp['A']
248248
series[:] = 10
249249
for idx, value in compat.iteritems(series):
250-
self.assertNotEqual(self.frame['A'][idx], value)
250+
assert self.frame['A'][idx] != value
251251

252252
# ---------------------------------------------------------------------
253253
# Transposing

pandas/tests/frame/test_indexing.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1890,7 +1890,7 @@ def test_nested_exception(self):
18901890
try:
18911891
repr(df)
18921892
except Exception as e:
1893-
self.assertNotEqual(type(e), UnboundLocalError)
1893+
assert type(e) != UnboundLocalError
18941894

18951895
def test_reindex_methods(self):
18961896
df = pd.DataFrame({'x': list(range(5))})

pandas/tests/frame/test_sorting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ def test_sort_index_inplace(self):
361361
df.sort_index(inplace=True)
362362
expected = frame
363363
assert_frame_equal(df, expected)
364-
self.assertNotEqual(a_id, id(df['A']))
364+
assert a_id != id(df['A'])
365365

366366
df = unordered.copy()
367367
df.sort_index(ascending=False, inplace=True)

pandas/tests/groupby/test_groupby.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ def test_frame_set_name_single(self):
10321032
assert result.index.name == 'A'
10331033

10341034
result = self.df.groupby('A', as_index=False).mean()
1035-
self.assertNotEqual(result.index.name, 'A')
1035+
assert result.index.name != 'A'
10361036

10371037
result = grouped.agg(np.mean)
10381038
assert result.index.name == 'A'

pandas/tests/indexes/test_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def test_constructor(self):
8181
assert index.name == 'name'
8282
tm.assert_numpy_array_equal(arr, index.values)
8383
arr[0] = "SOMEBIGLONGSTRING"
84-
self.assertNotEqual(index[0], "SOMEBIGLONGSTRING")
84+
assert index[0] != "SOMEBIGLONGSTRING"
8585

8686
# what to do here?
8787
# arr = np.array(5.)

pandas/tests/indexes/test_numeric.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ def test_constructor(self):
653653

654654
# this should not change index
655655
arr[0] = val
656-
self.assertNotEqual(new_index[0], val)
656+
assert new_index[0] != val
657657

658658
# interpret list-like
659659
expected = Int64Index([5, 0])

pandas/tests/io/formats/test_format.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -918,7 +918,7 @@ def test_wide_repr(self):
918918
assert "10 rows x %d columns" % (max_cols - 1) in rep_str
919919
set_option('display.expand_frame_repr', True)
920920
wide_repr = repr(df)
921-
self.assertNotEqual(rep_str, wide_repr)
921+
assert rep_str != wide_repr
922922

923923
with option_context('display.width', 120):
924924
wider_repr = repr(df)
@@ -944,7 +944,7 @@ def test_wide_repr_named(self):
944944
rep_str = repr(df)
945945
set_option('display.expand_frame_repr', True)
946946
wide_repr = repr(df)
947-
self.assertNotEqual(rep_str, wide_repr)
947+
assert rep_str != wide_repr
948948

949949
with option_context('display.width', 150):
950950
wider_repr = repr(df)
@@ -966,7 +966,7 @@ def test_wide_repr_multiindex(self):
966966
rep_str = repr(df)
967967
set_option('display.expand_frame_repr', True)
968968
wide_repr = repr(df)
969-
self.assertNotEqual(rep_str, wide_repr)
969+
assert rep_str != wide_repr
970970

971971
with option_context('display.width', 150):
972972
wider_repr = repr(df)
@@ -990,7 +990,7 @@ def test_wide_repr_multiindex_cols(self):
990990
rep_str = repr(df)
991991
set_option('display.expand_frame_repr', True)
992992
wide_repr = repr(df)
993-
self.assertNotEqual(rep_str, wide_repr)
993+
assert rep_str != wide_repr
994994

995995
with option_context('display.width', 150):
996996
wider_repr = repr(df)
@@ -1006,7 +1006,7 @@ def test_wide_repr_unicode(self):
10061006
rep_str = repr(df)
10071007
set_option('display.expand_frame_repr', True)
10081008
wide_repr = repr(df)
1009-
self.assertNotEqual(rep_str, wide_repr)
1009+
assert rep_str != wide_repr
10101010

10111011
with option_context('display.width', 150):
10121012
wider_repr = repr(df)

pandas/tests/io/formats/test_style.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ def test_deepcopy(self):
8585

8686
self.styler._update_ctx(self.attrs)
8787
self.styler.highlight_max()
88-
self.assertNotEqual(self.styler.ctx, s2.ctx)
88+
assert self.styler.ctx != s2.ctx
8989
assert s2._todo == []
90-
self.assertNotEqual(self.styler._todo, s2._todo)
90+
assert self.styler._todo != s2._todo
9191

9292
def test_clear(self):
9393
s = self.df.style.highlight_max()._compute()

pandas/tests/io/test_common.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_expand_user(self):
3838
filename = '~/sometest'
3939
expanded_name = common._expand_user(filename)
4040

41-
self.assertNotEqual(expanded_name, filename)
41+
assert expanded_name != filename
4242
assert isabs(expanded_name)
4343
assert os.path.expanduser(filename) == expanded_name
4444

@@ -68,7 +68,7 @@ def test_stringify_path_localpath(self):
6868
def test_get_filepath_or_buffer_with_path(self):
6969
filename = '~/sometest'
7070
filepath_or_buffer, _, _ = common.get_filepath_or_buffer(filename)
71-
self.assertNotEqual(filepath_or_buffer, filename)
71+
assert filepath_or_buffer != filename
7272
assert isabs(filepath_or_buffer)
7373
assert os.path.expanduser(filename) == filepath_or_buffer
7474

pandas/tests/scalar/test_period.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -938,8 +938,8 @@ def test_equal_Raises_Value(self):
938938
self.january1 == self.day
939939

940940
def test_notEqual(self):
941-
self.assertNotEqual(self.january1, 1)
942-
self.assertNotEqual(self.january1, self.february)
941+
assert self.january1 != 1
942+
assert self.january1 != self.february
943943

944944
def test_greater(self):
945945
assert self.february > self.january1

pandas/tests/scalar/test_timedelta.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ def test_timedelta_hash_equality(self):
560560

561561
# python timedeltas drop ns resolution
562562
ns_td = Timedelta(1, 'ns')
563-
self.assertNotEqual(hash(ns_td), hash(ns_td.to_pytimedelta()))
563+
assert hash(ns_td) != hash(ns_td.to_pytimedelta())
564564

565565
def test_implementation_limits(self):
566566
min_td = Timedelta(Timedelta.min)

pandas/tests/scalar/test_timestamp.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -873,8 +873,8 @@ def test_comparison(self):
873873

874874
other = Timestamp(stamp + 100)
875875

876-
self.assertNotEqual(val, other)
877-
self.assertNotEqual(val, other)
876+
assert val != other
877+
assert val != other
878878
assert val < other
879879
assert val <= other
880880
assert other > val
@@ -1375,9 +1375,9 @@ def test_timestamp_compare_with_early_datetime(self):
13751375
assert not stamp == datetime.min
13761376
assert not stamp == datetime(1600, 1, 1)
13771377
assert not stamp == datetime(2700, 1, 1)
1378-
self.assertNotEqual(stamp, datetime.min)
1379-
self.assertNotEqual(stamp, datetime(1600, 1, 1))
1380-
self.assertNotEqual(stamp, datetime(2700, 1, 1))
1378+
assert stamp != datetime.min
1379+
assert stamp != datetime(1600, 1, 1)
1380+
assert stamp != datetime(2700, 1, 1)
13811381
assert stamp > datetime(1600, 1, 1)
13821382
assert stamp >= datetime(1600, 1, 1)
13831383
assert stamp < datetime(2700, 1, 1)

pandas/tests/series/test_missing.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1078,8 +1078,8 @@ def test_spline_extrapolate(self):
10781078
def test_spline_smooth(self):
10791079
tm._skip_if_no_scipy()
10801080
s = Series([1, 2, np.nan, 4, 5.1, np.nan, 7])
1081-
self.assertNotEqual(s.interpolate(method='spline', order=3, s=0)[5],
1082-
s.interpolate(method='spline', order=3)[5])
1081+
assert (s.interpolate(method='spline', order=3, s=0)[5] !=
1082+
s.interpolate(method='spline', order=3)[5])
10831083

10841084
def test_spline_interpolation(self):
10851085
tm._skip_if_no_scipy()
@@ -1090,8 +1090,8 @@ def test_spline_interpolation(self):
10901090
expected1 = s.interpolate(method='spline', order=1)
10911091
assert_series_equal(result1, expected1)
10921092

1093-
# GH #10633
10941093
def test_spline_error(self):
1094+
# see gh-10633
10951095
tm._skip_if_no_scipy()
10961096

10971097
s = pd.Series(np.arange(10) ** 2)

pandas/tests/test_expressions.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ def testit():
293293
if op is not None:
294294
result = expr._can_use_numexpr(op, op_str, f, f,
295295
'evaluate')
296-
self.assertNotEqual(result, f._is_mixed_type)
296+
assert result != f._is_mixed_type
297297

298298
result = expr.evaluate(op, op_str, f, f,
299299
use_numexpr=True)
@@ -336,7 +336,7 @@ def testit():
336336

337337
result = expr._can_use_numexpr(op, op_str, f11, f12,
338338
'evaluate')
339-
self.assertNotEqual(result, f11._is_mixed_type)
339+
assert result != f11._is_mixed_type
340340

341341
result = expr.evaluate(op, op_str, f11, f12,
342342
use_numexpr=True)

pandas/tests/test_panel.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1636,7 +1636,7 @@ def test_swapaxes(self):
16361636
# this works, but return a copy
16371637
result = self.panel.swapaxes('items', 'items')
16381638
assert_panel_equal(self.panel, result)
1639-
self.assertNotEqual(id(self.panel), id(result))
1639+
assert id(self.panel) != id(result)
16401640

16411641
def test_transpose(self):
16421642
with catch_warnings(record=True):

pandas/tests/test_panel4d.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@ def test_swapaxes(self):
888888
# this works, but return a copy
889889
result = self.panel4d.swapaxes('items', 'items')
890890
assert_panel4d_equal(self.panel4d, result)
891-
self.assertNotEqual(id(self.panel4d), id(result))
891+
assert id(self.panel4d) != id(result)
892892

893893
def test_update(self):
894894

pandas/tests/tseries/test_offsets.py

+9-10
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ def test_eq(self):
541541
offset1 = DateOffset(days=1)
542542
offset2 = DateOffset(days=365)
543543

544-
self.assertNotEqual(offset1, offset2)
544+
assert offset1 != offset2
545545

546546

547547
class TestBusinessDay(Base):
@@ -775,12 +775,11 @@ def testEQ(self):
775775
for offset in [self.offset1, self.offset2, self.offset3, self.offset4]:
776776
assert offset == offset
777777

778-
self.assertNotEqual(BusinessHour(), BusinessHour(-1))
778+
assert BusinessHour() != BusinessHour(-1)
779779
assert BusinessHour(start='09:00') == BusinessHour()
780-
self.assertNotEqual(BusinessHour(start='09:00'),
781-
BusinessHour(start='09:01'))
782-
self.assertNotEqual(BusinessHour(start='09:00', end='17:00'),
783-
BusinessHour(start='17:00', end='09:01'))
780+
assert BusinessHour(start='09:00') != BusinessHour(start='09:01')
781+
assert (BusinessHour(start='09:00', end='17:00') !=
782+
BusinessHour(start='17:00', end='09:01'))
784783

785784
def test_hash(self):
786785
for offset in [self.offset1, self.offset2, self.offset3, self.offset4]:
@@ -4362,7 +4361,7 @@ def test_Hour(self):
43624361
assert Hour(3) + Hour(2) == Hour(5)
43634362
assert Hour(3) - Hour(2) == Hour()
43644363

4365-
self.assertNotEqual(Hour(4), Hour(1))
4364+
assert Hour(4) != Hour(1)
43664365

43674366
def test_Minute(self):
43684367
assertEq(Minute(), datetime(2010, 1, 1), datetime(2010, 1, 1, 0, 1))
@@ -4374,7 +4373,7 @@ def test_Minute(self):
43744373

43754374
assert Minute(3) + Minute(2) == Minute(5)
43764375
assert Minute(3) - Minute(2) == Minute()
4377-
self.assertNotEqual(Minute(5), Minute())
4376+
assert Minute(5) != Minute()
43784377

43794378
def test_Second(self):
43804379
assertEq(Second(), datetime(2010, 1, 1), datetime(2010, 1, 1, 0, 0, 1))
@@ -4464,8 +4463,8 @@ def test_tick_equalities(self):
44644463
assert t() == t(1)
44654464

44664465
# not equals
4467-
self.assertNotEqual(t(3), t(2))
4468-
self.assertNotEqual(t(3), t(-3))
4466+
assert t(3) != t(2)
4467+
assert t(3) != t(-3)
44694468

44704469
def test_tick_operators(self):
44714470
for t in self.ticks:

pandas/tests/tseries/test_timezones.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1191,8 +1191,7 @@ def test_cache_keys_are_distinct_for_pytz_vs_dateutil(self):
11911191
if tz_d is None:
11921192
# skip timezones that dateutil doesn't know about.
11931193
continue
1194-
self.assertNotEqual(tslib._p_tz_cache_key(
1195-
tz_p), tslib._p_tz_cache_key(tz_d))
1194+
assert tslib._p_tz_cache_key(tz_p) != tslib._p_tz_cache_key(tz_d)
11961195

11971196

11981197
class TestTimeZones(tm.TestCase):

0 commit comments

Comments
 (0)