Skip to content

Commit c31c6ba

Browse files
authored
TST: Test patching over fake instead of real method in accessor test (pandas-dev#55584)
1 parent ca39324 commit c31c6ba

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

pandas/tests/test_register_accessor.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,13 @@ def test_accessor_works():
8282

8383

8484
def test_overwrite_warns():
85-
# Need to restore mean
86-
mean = pd.Series.mean
87-
try:
88-
with tm.assert_produces_warning(UserWarning) as w:
89-
pd.api.extensions.register_series_accessor("mean")(MyAccessor)
85+
match = r".*MyAccessor.*fake.*Series.*"
86+
with tm.assert_produces_warning(UserWarning, match=match):
87+
with ensure_removed(pd.Series, "fake"):
88+
setattr(pd.Series, "fake", 123)
89+
pd.api.extensions.register_series_accessor("fake")(MyAccessor)
9090
s = pd.Series([1, 2])
91-
assert s.mean.prop == "item"
92-
msg = str(w[0].message)
93-
assert "mean" in msg
94-
assert "MyAccessor" in msg
95-
assert "Series" in msg
96-
finally:
97-
pd.Series.mean = mean
91+
assert s.fake.prop == "item"
9892

9993

10094
def test_raises_attribute_error():

0 commit comments

Comments
 (0)