Skip to content

Commit 2ff716a

Browse files
committed
Fix iteration condition for end_pos
* Binlog event at end_pos is the last event to be read (end_pos is inclusive) * iter() ends when fetchone() returns None
1 parent 5376718 commit 2ff716a

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

pymysqlreplication/event.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,6 @@ def _dump(self):
188188
print("Execution time: %d" % (self.execution_time))
189189
print("Query: %s" % (self.query))
190190

191-
192-
# TODO: check if instance attribute with the same name already exists
193-
# TODO: put all the instace attribute in separate class? called status_vars
194-
# TODO: does length need to be remembered?
195-
# TODO: ref(mysql doc. and mysql-server) for each hunk
196191
def _read_status_vars_value_for_key(self, key):
197192
"""parse status variable VALUE for given KEY
198193

0 commit comments

Comments
 (0)