Fixing ERROR maths/miller_rabin.py - ModuleNotFoundError and changing project_euler's isPrime to is_prime function names

Author: paulosgf

maths/miller_rabin.py

@@ -1,6 +1,6 @@
 import random
 
-from binary_exp_mod import bin_exp_mod
+from .binary_exp_mod import bin_exp_mod
 
 
 # This is a probabilistic check to test primality, useful for big numbers!

project_euler/problem_003/sol1.py

@@ -13,23 +13,23 @@
 import math
 
 
-def isprime(num: int) -> bool:
+def is_prime(num: int) -> bool:
     """
     Returns boolean representing primality of given number num.
 
-    >>> isprime(2)
+    >>> is_prime(2)
     True
-    >>> isprime(3)
+    >>> is_prime(3)
     True
-    >>> isprime(27)
+    >>> is_prime(27)
     False
-    >>> isprime(2999)
+    >>> is_prime(2999)
     True
-    >>> isprime(0)
+    >>> is_prime(0)
     Traceback (most recent call last):
         ...
     ValueError: Parameter num must be greater than or equal to two.
-    >>> isprime(1)
+    >>> is_prime(1)
     Traceback (most recent call last):
         ...
     ValueError: Parameter num must be greater than or equal to two.
@@ -84,18 +84,18 @@ def solution(n: int = 600851475143) -> int:
     if n <= 0:
         raise ValueError("Parameter n must be greater than or equal to one.")
     max_number = 0
-    if isprime(n):
+    if is_prime(n):
         return n
     while n % 2 == 0:
         n //= 2
-    if isprime(n):
+    if is_prime(n):
         return n
     for i in range(3, int(math.sqrt(n)) + 1, 2):
         if n % i == 0:
-            if isprime(n // i):
+            if is_prime(n // i):
                 max_number = n // i
                 break
-            elif isprime(i):
+            elif is_prime(i):
                 max_number = i
     return max_number
 

project_euler/problem_007/sol2.py

@@ -11,17 +11,18 @@
 References:
     - https://en.wikipedia.org/wiki/Prime_number
 """
+from typing import List
 
 
-def isprime(number: int) -> bool:
+def is_prime(number: int) -> bool:
     """
     Determines whether the given number is prime or not
 
-    >>> isprime(2)
+    >>> is_prime(2)
     True
-    >>> isprime(15)
+    >>> is_prime(15)
     False
-    >>> isprime(29)
+    >>> is_prime(29)
     True
     """
 
@@ -73,10 +74,10 @@ def solution(nth: int = 10001) -> int:
         raise TypeError("Parameter nth must be int or castable to int.") from None
     if nth <= 0:
         raise ValueError("Parameter nth must be greater than or equal to one.")
-    primes: list[int] = []
+    primes: List[int] = []
     num = 2
     while len(primes) < nth:
-        if isprime(num):
+        if is_prime(num):
             primes.append(num)
             num += 1
         else:

project_euler/problem_007/sol3.py

@@ -15,15 +15,15 @@
 import math
 
 
-def prime_check(number: int) -> bool:
+def is_prime(number: int) -> bool:
     """
     Determines whether a given number is prime or not
 
-    >>> prime_check(2)
+    >>> is_prime(2)
     True
-    >>> prime_check(15)
+    >>> is_prime(15)
     False
-    >>> prime_check(29)
+    >>> is_prime(29)
     True
     """
 
@@ -39,7 +39,7 @@ def prime_generator():
 
     num = 2
     while True:
-        if prime_check(num):
+        if is_prime(num):
             yield num
         num += 1
 

project_euler/problem_058/sol1.py

@@ -36,14 +36,14 @@
 from math import isqrt
 
 
-def isprime(number: int) -> int:
+def is_prime(number: int) -> int:
     """
     returns whether the given number is prime or not
-    >>> isprime(1)
+    >>> is_prime(1)
     0
-    >>> isprime(17)
+    >>> is_prime(17)
     1
-    >>> isprime(10000)
+    >>> is_prime(10000)
     0
     """
     if number == 1:
@@ -76,7 +76,7 @@ def solution(ratio: float = 0.1) -> int:
 
     while primes / (2 * j - 1) >= ratio:
         for i in range(j * j + j + 1, (j + 2) * (j + 2), j + 1):
-            primes = primes + isprime(i)
+            primes = primes + is_prime(i)
 
         j = j + 2
     return j